From: Paolo Abeni <pabeni@redhat.com>
To: Kuniyuki Iwashima <kuniyu@amazon.com>,
devnull+j.granados.samsung.com@kernel.org
Cc: Dai.Ngo@oracle.com, alex.aring@gmail.com,
alibuda@linux.alibaba.com, allison.henderson@oracle.com,
anna@kernel.org, bridge@lists.linux.dev, chuck.lever@oracle.com,
coreteam@netfilter.org, courmisch@gmail.com,
davem@davemloft.net, dccp@vger.kernel.org, dhowells@redhat.com,
dsahern@kernel.org, edumazet@google.com, fw@strlen.de,
geliang@kernel.org, guwen@linux.alibaba.com,
herbert@gondor.apana.org.au, horms@verge.net.au,
j.granados@samsung.com, ja@ssi.bg, jaka@linux.ibm.com,
jlayton@kernel.org, jmaloy@redhat.com, jreuter@yaina.de,
kadlec@netfilter.org, keescook@chromium.org, kolga@netapp.com,
kuba@kernel.org, linux-afs@lists.infradead.org,
linux-hams@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-nfs@vger.kernel.org, linux-rdma@vger.kernel.org,
linux-s390@vger.kernel.org, linux-sctp@vger.kernel.org,
linux-wpan@vger.kernel.org, linux-x25@vger.kernel.org,
lucien.xin@gmail.com, lvs-devel@vger.kernel.org,
marc.dionne@auristor.com, marcelo.leitner@gmail.com,
martineau@kernel.org, matttbe@kernel.org, mcgrof@kernel.org,
miquel.raynal@bootlin.com, mptcp@lists.linux.dev, ms@dev.tdt.de,
neilb@suse.de, netdev@vger.kernel.org,
netfilter-devel@vger.kernel.org, pablo@netfilter.org,
ralf@linux-mips.org, razor@blackwall.org,
rds-devel@oss.oracle.com, roopa@nvidia.com,
stefan@datenfreihafen.org, steffen.klassert@secunet.com,
tipc-discussion@lists.sourceforge.net, tom@talpey.com,
tonylu@linux.alibaba.com, trond.myklebust@hammerspace.com,
wenjia@linux.ibm.com, ying.xue@windriver.com
Subject: Re: [PATCH v3 1/4] networking: Remove the now superfluous sentinel elements from ctl_table array
Date: Tue, 16 Apr 2024 10:18:42 +0200 [thread overview]
Message-ID: <be056435353af60a564f457c79dacc16c6ea920e.camel@redhat.com> (raw)
In-Reply-To: <20240415231210.22785-1-kuniyu@amazon.com>
On Mon, 2024-04-15 at 16:12 -0700, Kuniyuki Iwashima wrote:
> From: Joel Granados via B4 Relay <devnull+j.granados.samsung.com@kernel.org>
> Date: Fri, 12 Apr 2024 16:48:29 +0200
> > From: Joel Granados <j.granados@samsung.com>
> >
> > This commit comes at the tail end of a greater effort to remove the
> > empty elements at the end of the ctl_table arrays (sentinels) which
> > will reduce the overall build time size of the kernel and run time
> > memory bloat by ~64 bytes per sentinel (further information Link :
> > https://lore.kernel.org/all/ZO5Yx5JFogGi%2FcBo@bombadil.infradead.org/)
> >
> > * Remove sentinel element from ctl_table structs.
> > * Remove extra element in ctl_table arrays declarations
> > * Remove instances where an array element is zeroed out to make it look
> > like a sentinel. This is not longer needed and is safe after commit
> > c899710fe7f9 ("networking: Update to register_net_sysctl_sz") added
> > the array size to the ctl_table registration
> > * Replace the for loop stop condition that tests for procname == NULL with
> > one that depends on array size
> > * Removed the "-1" that adjusted for having an extra empty element when
> > looping over ctl_table arrays
> > * Removing the unprivileged user check in ipv6_route_sysctl_init is
> > safe as it is replaced by calling ipv6_route_sysctl_table_size;
> > introduced in commit c899710fe7f9 ("networking: Update to
> > register_net_sysctl_sz")
> > * Replace empty array registration with the register_net_sysctl_sz call.
> >
> > Signed-off-by: Joel Granados <j.granados@samsung.com>
> > ---
> > net/core/neighbour.c | 5 +----
> > net/core/sysctl_net_core.c | 9 ++++-----
> > net/dccp/sysctl.c | 2 --
> > net/ieee802154/6lowpan/reassembly.c | 6 +-----
> > net/ipv4/devinet.c | 5 ++---
> > net/ipv4/ip_fragment.c | 2 --
> > net/ipv4/route.c | 8 ++------
> > net/ipv4/sysctl_net_ipv4.c | 7 +++----
> > net/ipv4/xfrm4_policy.c | 1 -
> > net/ipv6/addrconf.c | 5 +----
> > net/ipv6/icmp.c | 1 -
> > net/ipv6/reassembly.c | 2 --
> > net/ipv6/route.c | 5 -----
> > net/ipv6/sysctl_net_ipv6.c | 4 +---
> > net/ipv6/xfrm6_policy.c | 1 -
> > net/llc/sysctl_net_llc.c | 8 ++------
> > net/mpls/af_mpls.c | 3 +--
> > net/mptcp/ctrl.c | 1 -
> > net/netrom/sysctl_net_netrom.c | 1 -
> > net/phonet/sysctl.c | 1 -
> > net/rds/ib_sysctl.c | 1 -
> > net/rds/sysctl.c | 1 -
> > net/rds/tcp.c | 1 -
> > net/rose/sysctl_net_rose.c | 1 -
> > net/rxrpc/sysctl.c | 1 -
> > net/sctp/sysctl.c | 6 +-----
> > net/smc/smc_sysctl.c | 1 -
> > net/sunrpc/sysctl.c | 1 -
> > net/sunrpc/xprtrdma/svc_rdma.c | 1 -
> > net/sunrpc/xprtrdma/transport.c | 1 -
> > net/sunrpc/xprtsock.c | 1 -
> > net/tipc/sysctl.c | 1 -
> > net/unix/sysctl_net_unix.c | 1 -
> > net/x25/sysctl_net_x25.c | 1 -
> > net/xfrm/xfrm_sysctl.c | 5 +----
> > 35 files changed, 20 insertions(+), 81 deletions(-)
>
> You may want to split patch based on subsystem or the type of changes
> to make review easier.
I agree with Kuniyuki. I think the x25 chunks can me moved in the last
patch, and at least sunrpc and rds could go in separate patches,
possibly even xfrm and smc.
Thanks,
Paolo
next prev parent reply other threads:[~2024-04-16 8:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-12 14:48 [PATCH v3 0/4] sysctl: Remove sentinel elements from networking Joel Granados via B4 Relay
2024-04-12 14:48 ` [PATCH v3 1/4] networking: Remove the now superfluous sentinel elements from ctl_table array Joel Granados via B4 Relay
2024-04-15 23:12 ` Kuniyuki Iwashima
2024-04-16 8:18 ` Paolo Abeni [this message]
2024-04-16 12:32 ` Joel Granados
2024-04-16 9:45 ` Joel Granados
2024-04-12 14:48 ` [PATCH v3 2/4] netfilter: " Joel Granados via B4 Relay
2024-04-12 14:48 ` [PATCH v3 3/4] appletalk: " Joel Granados via B4 Relay
2024-04-12 14:48 ` [PATCH v3 4/4] ax.25: " Joel Granados via B4 Relay
2024-04-15 23:18 ` Kuniyuki Iwashima
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=be056435353af60a564f457c79dacc16c6ea920e.camel@redhat.com \
--to=pabeni@redhat.com \
--cc=Dai.Ngo@oracle.com \
--cc=alex.aring@gmail.com \
--cc=alibuda@linux.alibaba.com \
--cc=allison.henderson@oracle.com \
--cc=anna@kernel.org \
--cc=bridge@lists.linux.dev \
--cc=chuck.lever@oracle.com \
--cc=coreteam@netfilter.org \
--cc=courmisch@gmail.com \
--cc=davem@davemloft.net \
--cc=dccp@vger.kernel.org \
--cc=devnull+j.granados.samsung.com@kernel.org \
--cc=dhowells@redhat.com \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=fw@strlen.de \
--cc=geliang@kernel.org \
--cc=guwen@linux.alibaba.com \
--cc=herbert@gondor.apana.org.au \
--cc=horms@verge.net.au \
--cc=j.granados@samsung.com \
--cc=ja@ssi.bg \
--cc=jaka@linux.ibm.com \
--cc=jlayton@kernel.org \
--cc=jmaloy@redhat.com \
--cc=jreuter@yaina.de \
--cc=kadlec@netfilter.org \
--cc=keescook@chromium.org \
--cc=kolga@netapp.com \
--cc=kuba@kernel.org \
--cc=kuniyu@amazon.com \
--cc=linux-afs@lists.infradead.org \
--cc=linux-hams@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-sctp@vger.kernel.org \
--cc=linux-wpan@vger.kernel.org \
--cc=linux-x25@vger.kernel.org \
--cc=lucien.xin@gmail.com \
--cc=lvs-devel@vger.kernel.org \
--cc=marc.dionne@auristor.com \
--cc=marcelo.leitner@gmail.com \
--cc=martineau@kernel.org \
--cc=matttbe@kernel.org \
--cc=mcgrof@kernel.org \
--cc=miquel.raynal@bootlin.com \
--cc=mptcp@lists.linux.dev \
--cc=ms@dev.tdt.de \
--cc=neilb@suse.de \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=ralf@linux-mips.org \
--cc=razor@blackwall.org \
--cc=rds-devel@oss.oracle.com \
--cc=roopa@nvidia.com \
--cc=stefan@datenfreihafen.org \
--cc=steffen.klassert@secunet.com \
--cc=tipc-discussion@lists.sourceforge.net \
--cc=tom@talpey.com \
--cc=tonylu@linux.alibaba.com \
--cc=trond.myklebust@hammerspace.com \
--cc=wenjia@linux.ibm.com \
--cc=ying.xue@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).