Linux-RDMA Archive mirror
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Nathan Chancellor <nathan@kernel.org>
Cc: Jason Gunthorpe <jgg@nvidia.com>,
	Konstantin Taranov <kotaranov@linux.microsoft.com>,
	kotaranov@microsoft.com, sharmaajay@microsoft.com,
	longli@microsoft.com, leon@kernel.org,
	linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH rdma-next 1/1] RDMA/mana_ib: fix missing ret value
Date: Fri, 26 Apr 2024 20:00:42 +0300	[thread overview]
Message-ID: <ZivduvnNzGnoAXAs@smile.fi.intel.com> (raw)
In-Reply-To: <20240426165815.GA2876951@dev-arch.thelio-3990X>

On Fri, Apr 26, 2024 at 09:58:15AM -0700, Nathan Chancellor wrote:
> On Fri, Apr 26, 2024 at 07:53:02PM +0300, Andy Shevchenko wrote:
> > On Tue, Apr 23, 2024 at 12:03:15PM -0300, Jason Gunthorpe wrote:
> > > On Tue, Apr 23, 2024 at 07:15:51AM -0700, Konstantin Taranov wrote:
> > > > From: Konstantin Taranov <kotaranov@microsoft.com>
> > > > 
> > > > Set ret to -ENODEV when netdev_master_upper_dev_get_rcu
> > > > returns NULL.
> > > > 
> > > > Fixes: 8b184e4f1c32 ("RDMA/mana_ib: Enable RoCE on port 1")
> > > > Signed-off-by: Konstantin Taranov <kotaranov@microsoft.com>
> > > > ---
> > > >  drivers/infiniband/hw/mana/device.c | 1 +
> > > >  1 file changed, 1 insertion(+)
> > > 
> > > Applied to for-next, thanks
> > 
> > So, what's wrong with my patch that had been sent _before_ this one?
> 
> Was it?
> 
> This patch:
> 
>   $ date -d 'Tue, 23 Apr 2024 07:15:51 -0700' -u
>   Tue Apr 23 02:15:51 PM UTC 2024
> 
> Your patch: https://lore.kernel.org/20240423204258.3669706-1-andriy.shevchenko@linux.intel.com/
> 
>   $ date -d 'Tue, 23 Apr 2024 23:42:58 +0300' -u
>   Tue Apr 23 08:42:58 PM UTC 2024
> 
> Seems like this one beat yours by six hours?

Repeating myself from another thread:

"""
Oh, my... Sorry, I missed PM, it was mine sent after that one!
I guess time for weekend.
"""

Sorry for the noise and have a nice weekend!

-- 
With Best Regards,
Andy Shevchenko



      reply	other threads:[~2024-04-26 17:00 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-23 14:15 [PATCH rdma-next 1/1] RDMA/mana_ib: fix missing ret value Konstantin Taranov
2024-04-23 15:03 ` Jason Gunthorpe
2024-04-26 16:53   ` Andy Shevchenko
2024-04-26 16:58     ` Nathan Chancellor
2024-04-26 17:00       ` Andy Shevchenko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZivduvnNzGnoAXAs@smile.fi.intel.com \
    --to=andriy.shevchenko@intel.com \
    --cc=jgg@nvidia.com \
    --cc=kotaranov@linux.microsoft.com \
    --cc=kotaranov@microsoft.com \
    --cc=leon@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=longli@microsoft.com \
    --cc=nathan@kernel.org \
    --cc=sharmaajay@microsoft.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).