From: Yewon Choi <woni9911@gmail.com>
To: Allison Henderson <allison.henderson@oracle.com>,
Michal Kubiak <michal.kubiak@intel.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-rdma@vger.kernel.org,
rds-devel@oss.oracle.com, linux-kernel@vger.kernel.org,
"Dae R. Jeong" <threeearcat@gmail.com>
Subject: Re: [PATCH net] rds: introduce acquire/release ordering in acquire/release_in_xmit()
Date: Fri, 15 Mar 2024 18:24:57 +0900 [thread overview]
Message-ID: <ZfQT6X7KOpbQtF9k@libra05> (raw)
In-Reply-To: <4997357157f5735d07efdc7cd45388bd32375e5c.camel@oracle.com>
On Thu, Mar 14, 2024 at 10:37:29PM +0000, Allison Henderson wrote:
> On Thu, 2024-03-14 at 12:51 +0100, Michal Kubiak wrote:
> > On Thu, Mar 14, 2024 at 08:21:35PM +0900, Yewon Choi wrote:
> > > acquire/release_in_xmit() work as bit lock in rds_send_xmit(), so
> > > they
> > > are expected to ensure acquire/release memory ordering semantics.
> > > However, test_and_set_bit/clear_bit() don't imply such semantics,
> > > on
> > > top of this, following smp_mb__after_atomic() does not guarantee
> > > release
> > > ordering (memory barrier actually should be placed before
> > > clear_bit()).
> > >
> > > Instead, we use clear_bit_unlock/test_and_set_bit_lock() here.
> > >
> > > Signed-off-by: Yewon Choi <woni9911@gmail.com>
> >
> > Missing "Fixes" tag for the patch addressed to the "net" tree.
> >
Sorry for mistake, I'll correct this and send v2 patch.
> > Thanks,
> > Michal
>
> Yes, I think it needs:
>
> Fixes: 1f9ecd7eacfd ("RDS: Pass rds_conn_path to rds_send_xmit()")
>
> Since that is the last patch to modify the affected code. Other than
> that I think the patch looks good. With the tag fixed, you can add my
> rvb:
>
Also, test_and_set_bit/clear_bit() was first introduced in
commit 0f4b1c7e89e6. I think this can be added, too:
Fixes: 0f4b1c7e89e6 ("rds: fix rds_send_xmit() serialization")
> Reviewed-by: Allison Henderson <allison.henderson@oracle.com>
> >
>
Thank you for the reviewing.
Sincerely,
Yewon Choi
prev parent reply other threads:[~2024-03-15 9:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-14 11:21 [PATCH net] rds: introduce acquire/release ordering in acquire/release_in_xmit() Yewon Choi
2024-03-14 11:51 ` Michal Kubiak
2024-03-14 22:37 ` Allison Henderson
2024-03-15 9:24 ` Yewon Choi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZfQT6X7KOpbQtF9k@libra05 \
--to=woni9911@gmail.com \
--cc=allison.henderson@oracle.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=michal.kubiak@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rds-devel@oss.oracle.com \
--cc=threeearcat@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).