From: Song Liu <song@kernel.org>
To: Linux regressions mailing list <regressions@lists.linux.dev>
Cc: Yu Kuai <yukuai1@huaweicloud.com>,
linan666@huaweicloud.com, linux-raid@vger.kernel.org,
linux-kernel@vger.kernel.org, yi.zhang@huawei.com,
houtao1@huawei.com, yangerkun@huawei.com,
"yukuai (C)" <yukuai3@huawei.com>
Subject: Re: [PATCH 2/2] md: create symlink with disk holder after mddev resume
Date: Tue, 6 Feb 2024 09:00:47 -0800 [thread overview]
Message-ID: <CAPhsuW5ZhW3fR8LwKsMrRV6bVMbXJfonkBqVMVQqw=FAJg3V4A@mail.gmail.com> (raw)
In-Reply-To: <a92ca042-b981-4f35-beec-ebf416e4239b@leemhuis.info>
On Tue, Feb 6, 2024 at 6:46 AM Linux regression tracking (Thorsten
Leemhuis) <regressions@leemhuis.info> wrote:
>
> Hi, Thorsten here, the Linux kernel's regression tracker.
>
> On 21.12.23 09:49, Yu Kuai wrote:
> > 在 2023/12/21 15:11, linan666@huaweicloud.com 写道:
> >> From: Li Nan <linan122@huawei.com>
> >>
> >> There is a risk of deadlock when a process gets disk->open_mutex after
> >> suspending mddev, because other processes may hold open_mutex while
> >> submitting io. For example:
> >> [...]
> > Nice catch! This patch looks good except that the new flag
> > 'SymlinkCreated' doesn't look accurate, perhaps 'HolderLinked'
> > will make more sense.
> >
> >> Fix it by getting disk->open_mutex after mddev resume, iterating each
> >> mddev->disk to create symlink for rdev which has not been created yet.
> >> and moving bd_unlink_disk_holder() to mddev_unlock(), rdev has been
> >> deleted from mddev->disks here, which can avoid concurrent bind and
> >> unbind,
> >>
> >> Fixes: 1b0a2d950ee2 ("md: use new apis to suspend array for ioctls
> >> involed array reconfiguration")
>
> Hey, what happened to that patch? It looks a lot like things stalled
> here. I'm asking, because there is a regression report that claims
> 1b0a2d950ee2 to be the culprit that might or might not be causes by the
> problem this patch tries to fix:
> https://bugzilla.kernel.org/show_bug.cgi?id=218459
Thanks for the heads-up. Replied to the thread.
Song
prev parent reply other threads:[~2024-02-06 17:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-21 7:11 [PATCH 0/2] md: bugfix of creating symlink with disk holder linan666
2023-12-21 7:11 ` [PATCH 1/2] md: fix WARN_ON if create symlink fail in bind_rdev_to_array() linan666
2023-12-21 18:58 ` Song Liu
2023-12-22 1:16 ` Li Nan
2023-12-25 1:11 ` Song Liu
2023-12-25 1:35 ` Yu Kuai
2023-12-21 7:11 ` [PATCH 2/2] md: create symlink with disk holder after mddev resume linan666
2023-12-21 8:49 ` Yu Kuai
2024-02-06 14:46 ` Linux regression tracking (Thorsten Leemhuis)
2024-02-06 17:00 ` Song Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPhsuW5ZhW3fR8LwKsMrRV6bVMbXJfonkBqVMVQqw=FAJg3V4A@mail.gmail.com' \
--to=song@kernel.org \
--cc=houtao1@huawei.com \
--cc=linan666@huaweicloud.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=regressions@lists.linux.dev \
--cc=yangerkun@huawei.com \
--cc=yi.zhang@huawei.com \
--cc=yukuai1@huaweicloud.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).