From: Song Liu <song@kernel.org>
To: linan666@huaweicloud.com
Cc: gqjiang@suse.com, neilb@suse.com, linux-raid@vger.kernel.org,
linux-kernel@vger.kernel.org, yukuai3@huawei.com,
yi.zhang@huawei.com, houtao1@huawei.com, yangerkun@huawei.com
Subject: Re: [PATCH] md: fix kmemleak of rdev->serial
Date: Mon, 12 Feb 2024 15:23:59 -0800 [thread overview]
Message-ID: <CAPhsuW4_CX8tiRrZFMxUXK+E-=izTncqmwvrqX-pXG1wOLs=qg@mail.gmail.com> (raw)
In-Reply-To: <20240208085556.2412922-1-linan666@huaweicloud.com>
On Thu, Feb 8, 2024 at 1:00 AM <linan666@huaweicloud.com> wrote:
>
> From: Li Nan <linan122@huawei.com>
>
> If kobject_add() is fail in bind_rdev_to_array(), 'rdev->serial' will be
> alloc not be freed, and kmemleak occurs.
>
> unreferenced object 0xffff88815a350000 (size 49152):
> comm "mdadm", pid 789, jiffies 4294716910
> hex dump (first 32 bytes):
> 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
> 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
> backtrace (crc f773277a):
> [<0000000058b0a453>] kmemleak_alloc+0x61/0xe0
> [<00000000366adf14>] __kmalloc_large_node+0x15e/0x270
> [<000000002e82961b>] __kmalloc_node.cold+0x11/0x7f
> [<00000000f206d60a>] kvmalloc_node+0x74/0x150
> [<0000000034bf3363>] rdev_init_serial+0x67/0x170
> [<0000000010e08fe9>] mddev_create_serial_pool+0x62/0x220
> [<00000000c3837bf0>] bind_rdev_to_array+0x2af/0x630
> [<0000000073c28560>] md_add_new_disk+0x400/0x9f0
> [<00000000770e30ff>] md_ioctl+0x15bf/0x1c10
> [<000000006cfab718>] blkdev_ioctl+0x191/0x3f0
> [<0000000085086a11>] vfs_ioctl+0x22/0x60
> [<0000000018b656fe>] __x64_sys_ioctl+0xba/0xe0
> [<00000000e54e675e>] do_syscall_64+0x71/0x150
> [<000000008b0ad622>] entry_SYSCALL_64_after_hwframe+0x6c/0x74
>
> Fixes: 963c555e75b0 ("md: introduce mddev_create/destroy_wb_pool for the change of member device")
> Signed-off-by: Li Nan <linan122@huawei.com>
LGTM. Applied to md-6.9.
Thanks,
Song
prev parent reply other threads:[~2024-02-12 23:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-08 8:55 [PATCH] md: fix kmemleak of rdev->serial linan666
2024-02-12 23:23 ` Song Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPhsuW4_CX8tiRrZFMxUXK+E-=izTncqmwvrqX-pXG1wOLs=qg@mail.gmail.com' \
--to=song@kernel.org \
--cc=gqjiang@suse.com \
--cc=houtao1@huawei.com \
--cc=linan666@huaweicloud.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=neilb@suse.com \
--cc=yangerkun@huawei.com \
--cc=yi.zhang@huawei.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).