From: tada keisuke <keisuke1.tada@kioxia.com>
To: "song@kernel.org" <song@kernel.org>,
"yukuai3@huawei.com" <yukuai3@huawei.com>
Cc: "linux-raid@vger.kernel.org" <linux-raid@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: [PATCH v2 09/11] md: add atomic mode switching when removing disk
Date: Thu, 18 Apr 2024 05:44:23 +0000 [thread overview]
Message-ID: <415ab1a1454a44129e997d51822ed533@kioxia.com> (raw)
This patch depends on patch 08.
To minimize the number of execution of atomic mode switching, not only adding atomic mode switching, but also remove judgment is divided into two stages.
Latency is minimized because only rdev to be removed is switched to atomic mode, not all rdevs.
Signed-off-by: Keisuke TADA <keisuke1.tada@kioxia.com>
Signed-off-by: Toshifumi OHTAKE <toshifumi.ootake@kioxia.com>
---
drivers/md/md.c | 12 ++++++++++--
1 file changed, 10 insertions(+), 2 deletions(-)
diff --git a/drivers/md/md.c b/drivers/md/md.c
index 7e6966e65d0d..5f785353353d 100644
--- a/drivers/md/md.c
+++ b/drivers/md/md.c
@@ -9291,8 +9291,11 @@ static bool rdev_removeable(struct md_rdev *rdev)
return false;
/* Fautly rdev is not used, it's safe to remove it. */
- if (test_bit(Faulty, &rdev->flags))
- return true;
+ if (nr_pending_is_percpu_mode(rdev) && test_bit(Faulty, &rdev->flags)) {
+ percpu_ref_switch_to_atomic_sync(&rdev->nr_pending);
+ if (nr_pending_is_zero(rdev))
+ return true;
+ }
/* Journal disk can only be removed if it's faulty. */
if (test_bit(Journal, &rdev->flags))
@@ -9346,6 +9349,11 @@ static bool md_spares_need_change(struct mddev *mddev)
{
struct md_rdev *rdev;
+ rdev_for_each_rcu(rdev, mddev) {
+ if (test_bit(Faulty, &rdev->flags))
+ percpu_ref_switch_to_atomic_sync(&rdev->nr_pending);
+ }
+
rcu_read_lock();
rdev_for_each_rcu(rdev, mddev) {
if (rdev_removeable(rdev) || rdev_addable(rdev)) {
--
2.34.1
reply other threads:[~2024-04-18 5:44 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=415ab1a1454a44129e997d51822ed533@kioxia.com \
--to=keisuke1.tada@kioxia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=song@kernel.org \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).