From: Mariusz Tkaczyk <mariusz.tkaczyk@linux.intel.com>
To: Yu Kuai <yukuai1@huaweicloud.com>
Cc: agk@redhat.com, snitzer@kernel.org, mpatocka@redhat.com,
song@kernel.org, xni@redhat.com, dm-devel@lists.linux.dev,
linux-kernel@vger.kernel.org, linux-raid@vger.kernel.org,
yukuai3@huawei.com, yi.zhang@huawei.com, yangerkun@huawei.com
Subject: Re: [PATCH md-6.10 1/9] md: rearrange recovery_flage
Date: Mon, 13 May 2024 17:12:33 +0200 [thread overview]
Message-ID: <20240513170958.00002282@linux.intel.com> (raw)
In-Reply-To: <20240509011900.2694291-2-yukuai1@huaweicloud.com>
On Thu, 9 May 2024 09:18:52 +0800
Yu Kuai <yukuai1@huaweicloud.com> wrote:
There is typo in subject.
> From: Yu Kuai <yukuai3@huawei.com>
>
> Currently there are lots of flags and the names are confusing, since
> there are two main types of flags, sync thread runnng status and sync
> thread action, rearrange and update comment to improve code readability,
> there are no functional changes.
>
> Signed-off-by: Yu Kuai <yukuai3@huawei.com>
> ---
> drivers/md/md.h | 52 ++++++++++++++++++++++++++++++++++++-------------
> 1 file changed, 38 insertions(+), 14 deletions(-)
>
> diff --git a/drivers/md/md.h b/drivers/md/md.h
> index 029dd0491a36..2a1cb7b889e5 100644
> --- a/drivers/md/md.h
> +++ b/drivers/md/md.h
> @@ -551,22 +551,46 @@ struct mddev {
> };
>
> enum recovery_flags {
> + /* flags for sync thread running status */
> +
> + /*
> + * set when one of sync action is set and new sync thread need to be
> + * registered, or just add/remove spares from conf.
> + */
> + MD_RECOVERY_NEEDED,
> + /* sync thread is running, or about to be started */
> + MD_RECOVERY_RUNNING,
> + /* sync thread needs to be aborted for some reason */
> + MD_RECOVERY_INTR,
> + /* sync thread is done and is waiting to be unregistered */
> + MD_RECOVERY_DONE,
> + /* running sync thread must abort immediately, and not restart */
> + MD_RECOVERY_FROZEN,
> + /* waiting for pers->start() to finish */
> + MD_RECOVERY_WAIT,
> + /* interrupted because io-error */
> + MD_RECOVERY_ERROR,
> +
> + /* flags determines sync action */
> +
> + /* if just this flag is set, action is resync. */
> + MD_RECOVERY_SYNC,
> + /*
> + * paired with MD_RECOVERY_SYNC, if MD_RECOVERY_CHECK is not set,
> + * action is repair, means user requested resync.
> + */
> + MD_RECOVERY_REQUESTED,
> /*
> - * If neither SYNC or RESHAPE are set, then it is a recovery.
> + * paired with MD_RECOVERY_SYNC and MD_RECOVERY_REQUESTED, action is
> + * check.
> */
> - MD_RECOVERY_RUNNING, /* a thread is running, or about to be
> started */
> - MD_RECOVERY_SYNC, /* actually doing a resync, not a recovery
> */
> - MD_RECOVERY_RECOVER, /* doing recovery, or need to try it. */
> - MD_RECOVERY_INTR, /* resync needs to be aborted for some
> reason */
> - MD_RECOVERY_DONE, /* thread is done and is waiting to be
> reaped */
> - MD_RECOVERY_NEEDED, /* we might need to start a
> resync/recover */
> - MD_RECOVERY_REQUESTED, /* user-space has requested a sync
> (used with SYNC) */
> - MD_RECOVERY_CHECK, /* user-space request for check-only, no
> repair */
> - MD_RECOVERY_RESHAPE, /* A reshape is happening */
> - MD_RECOVERY_FROZEN, /* User request to abort, and not
> restart, any action */
> - MD_RECOVERY_ERROR, /* sync-action interrupted because
> io-error */
> - MD_RECOVERY_WAIT, /* waiting for pers->start() to finish */
> - MD_RESYNCING_REMOTE, /* remote node is running resync thread
> */
> + MD_RECOVERY_CHECK,
> + /* recovery, or need to try it */
> + MD_RECOVERY_RECOVER,
> + /* reshape */
> + MD_RECOVERY_RESHAPE,
> + /* remote node is running resync thread */
> + MD_RESYNCING_REMOTE,
> };
>
> enum md_ro_state {
I don't know if it is better readable but I know that Kernel coding style comes
with different approach. I used it for enum mddev_flags in md.h please take a
look.
Also, I get used to comment above, not below enum values but I don't have strong
justification here.
Thanks,
Mariusz
next prev parent reply other threads:[~2024-05-13 15:12 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-09 1:18 [PATCH RFC md-6.10 0/9] md: refactor and cleanup for sync action Yu Kuai
2024-05-09 1:18 ` [PATCH md-6.10 1/9] md: rearrange recovery_flage Yu Kuai
2024-05-13 15:12 ` Mariusz Tkaczyk [this message]
2024-05-14 1:36 ` Yu Kuai
2024-05-14 5:51 ` Xiao Ni
2024-05-14 6:10 ` Yu Kuai
2024-05-14 6:39 ` Xiao Ni
2024-05-09 1:18 ` [PATCH md-6.10 2/9] md: add a new enum type sync_action Yu Kuai
2024-05-14 6:13 ` Xiao Ni
2024-05-09 1:18 ` [PATCH md-6.10 3/9] md: add new helpers for sync_action Yu Kuai
2024-05-14 6:52 ` Xiao Ni
2024-05-14 7:39 ` Yu Kuai
2024-05-14 8:40 ` Xiao Ni
2024-05-14 8:52 ` Yu Kuai
2024-05-20 11:51 ` Su Yue
2024-05-21 2:30 ` Yu Kuai
2024-05-21 3:25 ` Xiao Ni
2024-05-21 3:50 ` Su Yue
2024-05-09 1:18 ` [PATCH md-6.10 4/9] md: factor out helper to start reshape from action_store() Yu Kuai
2024-05-09 1:18 ` [PATCH md-6.10 5/9] md: replace sysfs api sync_action with new helpers Yu Kuai
2024-05-20 15:01 ` kernel test robot
2024-05-21 2:20 ` Yu Kuai
2024-05-21 3:01 ` Oliver Sang
2024-05-21 3:11 ` Yu Kuai
2024-05-21 3:21 ` Xiao Ni
2024-05-22 2:46 ` Yu Kuai
2024-05-09 1:18 ` [PATCH md-6.10 6/9] md: use new helers in md_do_sync() Yu Kuai
2024-05-09 1:18 ` [PATCH md-6.10 7/9] md: replace last_sync_action with new enum type Yu Kuai
2024-05-09 1:18 ` [PATCH md-6.10 8/9] md: factor out helpers for different sync_action in md_do_sync() Yu Kuai
2024-05-14 7:27 ` Xiao Ni
2024-05-09 1:19 ` [PATCH md-6.10 9/9] md: pass in max_sectors for pers->sync_request() Yu Kuai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240513170958.00002282@linux.intel.com \
--to=mariusz.tkaczyk@linux.intel.com \
--cc=agk@redhat.com \
--cc=dm-devel@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=mpatocka@redhat.com \
--cc=snitzer@kernel.org \
--cc=song@kernel.org \
--cc=xni@redhat.com \
--cc=yangerkun@huawei.com \
--cc=yi.zhang@huawei.com \
--cc=yukuai1@huaweicloud.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).