From: Mariusz Tkaczyk <mariusz.tkaczyk@linux.intel.com>
To: jes@trained-monkey.org
Cc: linux-raid@vger.kernel.org
Subject: Re: [PATCH 00/13] Custom drives policies verification
Date: Mon, 11 Mar 2024 11:05:33 +0100 [thread overview]
Message-ID: <20240311110533.00001b02@linux.intel.com> (raw)
In-Reply-To: <20240229115217.26543-1-mariusz.tkaczyk@linux.intel.com>
On Thu, 29 Feb 2024 12:52:04 +0100
Mariusz Tkaczyk <mariusz.tkaczyk@linux.intel.com> wrote:
> validate_geometry_imsm() over the years became huge and complicated.
> It is extremely hard to develop or optimize this code now. What the
> most important, it doesn't address all scenarios. For example if
> container contains disks under different controllers (spare container),
> "autolayout" feature allows to create raid array. This code has a lot
> of dependencies and it is almost impossible to add support of this
> scenario without breaking something else.
>
> There is also get_disk_controller_domain() which in my understating is a
> part of validate_geometry_imsm() functionality moved outside, fit ideally
> to mdmonitor needs.
>
> Drive encryption determining will be added to IMSM soon. The encryption
> status of the drive will be determined for every drive. There is no
> simple way to add it.
>
> The solution added in this serie addresses those problems by making one
> easily extendable api to analyze every disk separately, outside
> validate_geometry().
>
> First five patches are optimizations with no functional changes. New
> functionality replaces get_disk_controller_domain(). It should also
> cover some verifications done in validate_geometry_imsm() and
> add_to_super_imsm() but to lower regression risk these parts are
> not removed yet.
>
> Mariusz Tkaczyk (13):
> mdadm: Add functions for spare criteria verification
> mdadm: drop get_required_spare_criteria()
> Manage: fix check after dereference issue
> Manage: implement manage_add_external()
> mdadm: introduce sysfs_get_container_devnm()
> mdadm.h: Introduce custom device policies
> mdadm: test_and_add device policies implementation
> Create: Use device policies
> Manage: check device policies in manage_add_external()
> Monitor, Incremental: use device policies
> imsm: test_and_add_device_policies() implementation
> mdadm: drop get_disk_controller_domain()
> Revert "policy.c: Avoid to take spare without defined domain by imsm"
>
> Create.c | 48 +++++++---
> Incremental.c | 77 ++++++++++-----
> Manage.c | 195 +++++++++++++++++++++----------------
> Monitor.c | 50 ++--------
> mdadm.h | 90 +++++++++--------
> platform-intel.h | 1 -
> policy.c | 110 +++++++++++++++++----
> super-intel.c | 245 ++++++++++++++++++++++++++++++++---------------
> sysfs.c | 23 +++++
> util.c | 117 ++++++++++++----------
> 10 files changed, 606 insertions(+), 350 deletions(-)
>
No comments..
Applied!
Thanks,
Mariusz
prev parent reply other threads:[~2024-03-11 10:05 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-29 11:52 [PATCH 00/13] Custom drives policies verification Mariusz Tkaczyk
2024-02-29 11:52 ` [PATCH 01/13] mdadm: Add functions for spare criteria verification Mariusz Tkaczyk
2024-02-29 11:52 ` [PATCH 02/13] mdadm: drop get_required_spare_criteria() Mariusz Tkaczyk
2024-02-29 11:52 ` [PATCH 03/13] Manage: fix check after dereference issue Mariusz Tkaczyk
2024-02-29 11:52 ` [PATCH 04/13] Manage: implement manage_add_external() Mariusz Tkaczyk
2024-02-29 11:52 ` [PATCH 05/13] mdadm: introduce sysfs_get_container_devnm() Mariusz Tkaczyk
2024-02-29 11:52 ` [PATCH 06/13] mdadm.h: Introduce custom device policies Mariusz Tkaczyk
2024-02-29 11:52 ` [PATCH 07/13] mdadm: test_and_add device policies implementation Mariusz Tkaczyk
2024-02-29 11:52 ` [PATCH 08/13] Create: Use device policies Mariusz Tkaczyk
2024-02-29 11:52 ` [PATCH 09/13] Manage: check device policies in manage_add_external() Mariusz Tkaczyk
2024-02-29 11:52 ` [PATCH 10/13] Monitor, Incremental: use device policies Mariusz Tkaczyk
2024-02-29 11:52 ` [PATCH 11/13] imsm: test_and_add_device_policies() implementation Mariusz Tkaczyk
2024-02-29 11:52 ` [PATCH 12/13] mdadm: drop get_disk_controller_domain() Mariusz Tkaczyk
2024-02-29 11:52 ` [PATCH 13/13] Revert "policy.c: Avoid to take spare without defined domain by imsm" Mariusz Tkaczyk
2024-03-11 10:05 ` Mariusz Tkaczyk [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240311110533.00001b02@linux.intel.com \
--to=mariusz.tkaczyk@linux.intel.com \
--cc=jes@trained-monkey.org \
--cc=linux-raid@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).