From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Johan Jonker <jbx6244@yandex.com>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
linux-pwm@vger.kernel.org, Conor Dooley <conor+dt@kernel.org>,
Heiko Stuebner <heiko@sntech.de>,
devicetree@vger.kernel.org, linux-rockchip@lists.infradead.org,
Rob Herring <robh+dt@kernel.org>,
Thierry Reding <thierry.reding@gmail.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
kernel@pengutronix.de
Subject: Re: [PATCH] dt-bindings: pwm: rockchip: Allow "interrupts" prooperty
Date: Mon, 29 Jan 2024 12:41:45 +0100 [thread overview]
Message-ID: <dsq5f77dkwfzjegisz6waaqln4b4hbyhoafeygsisdhfzjy2ud@v4pdwvkkupbh> (raw)
In-Reply-To: <b03fc42e-653a-49b2-8835-6cfb7a7bb39e@yandex.com>
[-- Attachment #1: Type: text/plain, Size: 1071 bytes --]
Hello Johan,
On Wed, Jan 24, 2024 at 10:40:15AM +0100, Johan Jonker wrote:
> The interrupt registers are located outside the PWM range and have nothing to do with the PWM driver.
> Adding them to a PWM binding is just bogus.
> They are a left over from the manufacturer tree that use them in a IR detection driver.
> Heiko keeps them because someone outside mainline kernel might use them?
> They should be removed and remodeled in a new sort of MFD node that handles all operating 3 modes.
After some more feedback on irc, I sent a patch removing the interrupts
property. However I failed to Cc: you on it. This first patch catched
your attention even without you being explicitly Cc:d, so I hoped the
new patch also hit your inbox. Find it at
https://lore.kernel.org/linux-pwm/20240129113205.2453029-2-u.kleine-koenig@pengutronix.de
and tell me if you want a bounce.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2024-01-29 11:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-06 14:26 [PATCH] dt-bindings: pwm: rockchip: Allow "interrupts" prooperty Uwe Kleine-König
2024-01-06 16:57 ` Uwe Kleine-König
2024-01-06 17:10 ` Krzysztof Kozlowski
2024-01-06 21:25 ` Johan Jonker
2024-01-06 23:25 ` Uwe Kleine-König
2024-01-07 10:30 ` Krzysztof Kozlowski
2024-01-24 8:26 ` Uwe Kleine-König
2024-01-24 9:40 ` Johan Jonker
2024-01-29 11:41 ` Uwe Kleine-König [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dsq5f77dkwfzjegisz6waaqln4b4hbyhoafeygsisdhfzjy2ud@v4pdwvkkupbh \
--to=u.kleine-koenig@pengutronix.de \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=jbx6244@yandex.com \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robh+dt@kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).