From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Nicolas Ferre <nicolas.ferre@microchip.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Claudiu Beznea <claudiu.beznea@tuxon.dev>,
Boris Brezillon <bbrezillon@kernel.org>
Cc: Thierry Reding <thierry.reding@gmail.com>,
linux-pwm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
kernel@pengutronix.de
Subject: [PATCH 0/2] pwm: atmel-hlcdc: Two improvements
Date: Fri, 26 Jan 2024 12:59:34 +0100 [thread overview]
Message-ID: <cover.1706269232.git.u.kleine-koenig@pengutronix.de> (raw)
Hello,
while looking through various pwm drivers I found these two
improvements.
The conditional clk_disable_unprepare() in .suspend() makes me wonder if
the PWM continues to operate during suspend. Can someone with the
hardware confirm that? If so, is it really necessary to restore the
registers (by calling atmel_hlcdc_pwm_apply())?
Other drivers have a logic in .suspend() that makes them return -EBUSY
if the pwm is still enabled. So I further wonder if there is an
application for the atmel-hlcdc driver to handle the pwm being enabled
there. Any hints are welcome. I already wondered if it's safe to let the
pwm core return -EBUSY for a suspend request if the hardware is enabled.
So the answer to my question is relevant to this plan, too.
Best regards
Uwe
Uwe Kleine-König (2):
pwm: atmel-hlcdc: Fix clock imbalance related to suspend support
pwm: atmel-hlcdc: Don't use pwm consumer API
drivers/pwm/pwm-atmel-hlcdc.c | 12 +++++-------
1 file changed, 5 insertions(+), 7 deletions(-)
base-commit: 7be3ba1e5644170feb2cb587860015de97fc7d8a
--
2.43.0
next reply other threads:[~2024-01-26 11:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-26 11:59 Uwe Kleine-König [this message]
2024-01-26 12:04 ` [PATCH 1/2] pwm: atmel-hlcdc: Fix clock imbalance related to suspend support Uwe Kleine-König
2024-02-03 15:47 ` claudiu beznea
2024-01-26 12:04 ` [PATCH 2/2] pwm: atmel-hlcdc: Don't use pwm consumer API Uwe Kleine-König
2024-02-03 15:47 ` claudiu beznea
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1706269232.git.u.kleine-koenig@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=alexandre.belloni@bootlin.com \
--cc=bbrezillon@kernel.org \
--cc=claudiu.beznea@tuxon.dev \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pwm@vger.kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).