From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Stephen Boyd <sboyd@kernel.org>
Cc: linux-pwm@vger.kernel.org, Sean Anderson <sean.anderson@seco.com>,
Michael Turquette <mturquette@baylibre.com>,
Russell King <linux@armlinux.org.uk>,
Maxime Ripard <mripard@kernel.org>,
Thierry Reding <thierry.reding@gmail.com>,
kernel@pengutronix.de, Michal Simek <michal.simek@amd.com>,
linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/2] clk: Add a devm variant of clk_rate_exclusive_get()
Date: Fri, 5 Jan 2024 00:01:18 +0100 [thread overview]
Message-ID: <5l6flihq3uqt26f3ewnfu73nmochf6333xlmjrcaah5bihwiv7@742tycpiszno> (raw)
In-Reply-To: <c1effbda6f323aa58935e1990ba3aed8.sboyd@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 1452 bytes --]
Hello Stephen,
On Thu, Jan 04, 2024 at 01:38:27PM -0800, Stephen Boyd wrote:
> Quoting Uwe Kleine-König (2024-01-04 10:06:29)
> > On Mon, Dec 18, 2023 at 02:01:41PM +0100, Uwe Kleine-K�nig wrote:
> > > If you don't require to add something like:
> > >
> > > ret = clk_rate_exclusive_get(clk);
> > > if (ret)
> > > return ret;
> > >
> > > where we currently have just
> > >
> > > clk_rate_exclusive_get(clk);
> > >
> > > the patch can just be applied (using git am -3) not even hitting a merge
> > > conflict without that other series.
> >
> > I wonder what you think about this. This devm_clk_rate_exclusive_get()
> > would be very useful and simplify a few more drivers.
> >
> > Do you intend to take the patch as is, or should I rework it to check
> > for the zero it returns?
>
> Please check the return value even if it is always zero. The discussion
> about handling the return value can continue in parallel.
The discussion in the other thread died, but maybe that's because of the
holidays. Anyhow, I sent a v2 that checks the return value and intend to
rebase and resend my series making clk_rate_exclusive_get() return void
if there is no further contribution by Maxime in a few months.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2024-01-04 23:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-12 18:09 [PATCH 0/2] clk: Add a devm variant of clk_rate_exclusive_get() Uwe Kleine-König
2023-12-12 18:09 ` [PATCH 1/2] " Uwe Kleine-König
2023-12-18 0:17 ` Stephen Boyd
2023-12-18 13:01 ` Uwe Kleine-König
2024-01-04 18:06 ` Uwe Kleine-König
2024-01-04 21:38 ` Stephen Boyd
2024-01-04 23:01 ` Uwe Kleine-König [this message]
2023-12-12 18:09 ` [PATCH 2/2] pwm: xilinx: Simplify using devm functions Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5l6flihq3uqt26f3ewnfu73nmochf6333xlmjrcaah5bihwiv7@742tycpiszno \
--to=u.kleine-koenig@pengutronix.de \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=michal.simek@amd.com \
--cc=mripard@kernel.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
--cc=sean.anderson@seco.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).