From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Benson Leung <bleung@chromium.org>, linux-pwm@vger.kernel.org
Cc: Guenter Roeck <groeck@chromium.org>,
chrome-platform@lists.linux.dev, kernel@pengutronix.de,
Tzung-Bi Shih <tzungbi@kernel.org>
Subject: [PATCH v5 002/111] pwm: cros-ec: Change prototype of helpers to prepare further changes
Date: Thu, 25 Jan 2024 13:08:24 +0100 [thread overview]
Message-ID: <578f3c0f4394ed97da2d7ff1a4d2f4b95f3b24f6.1706182805.git.u.kleine-koenig@pengutronix.de> (raw)
In-Reply-To: <cover.1706182805.git.u.kleine-koenig@pengutronix.de>
pwm_chip allocation and registration is about to change. For that the
number of PWM devices must be known earlier in cros_ec_pwm_probe(). So
make cros_ec_pwm_get_duty() and cros_ec_num_pwms() independent of
struct cros_ec_pwm_device which is only available later.
Reviewed-by: Tzung-Bi Shih <tzungbi@kernel.org>
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
drivers/pwm/pwm-cros-ec.c | 17 ++++++++++-------
1 file changed, 10 insertions(+), 7 deletions(-)
diff --git a/drivers/pwm/pwm-cros-ec.c b/drivers/pwm/pwm-cros-ec.c
index 339cedf3a7b1..e556f6218dd7 100644
--- a/drivers/pwm/pwm-cros-ec.c
+++ b/drivers/pwm/pwm-cros-ec.c
@@ -93,9 +93,8 @@ static int cros_ec_pwm_set_duty(struct cros_ec_pwm_device *ec_pwm, u8 index,
return cros_ec_cmd_xfer_status(ec, msg);
}
-static int cros_ec_pwm_get_duty(struct cros_ec_pwm_device *ec_pwm, u8 index)
+static int cros_ec_pwm_get_duty(struct cros_ec_device *ec, bool use_pwm_type, u8 index)
{
- struct cros_ec_device *ec = ec_pwm->ec;
struct {
struct cros_ec_command msg;
union {
@@ -115,7 +114,7 @@ static int cros_ec_pwm_get_duty(struct cros_ec_pwm_device *ec_pwm, u8 index)
msg->insize = sizeof(*resp);
msg->outsize = sizeof(*params);
- if (ec_pwm->use_pwm_type) {
+ if (use_pwm_type) {
ret = cros_ec_dt_type_to_pwm_type(index, ¶ms->pwm_type);
if (ret) {
dev_err(ec->dev, "Invalid PWM type index: %d\n", index);
@@ -171,7 +170,7 @@ static int cros_ec_pwm_get_state(struct pwm_chip *chip, struct pwm_device *pwm,
struct cros_ec_pwm *channel = &ec_pwm->channel[pwm->hwpwm];
int ret;
- ret = cros_ec_pwm_get_duty(ec_pwm, pwm->hwpwm);
+ ret = cros_ec_pwm_get_duty(ec_pwm->ec, ec_pwm->use_pwm_type, pwm->hwpwm);
if (ret < 0) {
dev_err(chip->dev, "error getting initial duty: %d\n", ret);
return ret;
@@ -226,13 +225,17 @@ static const struct pwm_ops cros_ec_pwm_ops = {
* of PWMs it supports directly, so we have to read the pwm duty cycle for
* subsequent channels until we get an error.
*/
-static int cros_ec_num_pwms(struct cros_ec_pwm_device *ec_pwm)
+static int cros_ec_num_pwms(struct cros_ec_device *ec)
{
int i, ret;
/* The index field is only 8 bits */
for (i = 0; i <= U8_MAX; i++) {
- ret = cros_ec_pwm_get_duty(ec_pwm, i);
+ /*
+ * Note that this function is only called when use_pwm_type is
+ * false. With use_pwm_type == true the number of PWMs is fixed.
+ */
+ ret = cros_ec_pwm_get_duty(ec, false, i);
/*
* We look for SUCCESS, INVALID_COMMAND, or INVALID_PARAM
* responses; everything else is treated as an error.
@@ -283,7 +286,7 @@ static int cros_ec_pwm_probe(struct platform_device *pdev)
if (ec_pwm->use_pwm_type) {
chip->npwm = CROS_EC_PWM_DT_COUNT;
} else {
- ret = cros_ec_num_pwms(ec_pwm);
+ ret = cros_ec_num_pwms(ec);
if (ret < 0)
return dev_err_probe(dev, ret, "Couldn't find PWMs\n");
chip->npwm = ret;
--
2.43.0
next prev parent reply other threads:[~2024-01-25 12:10 UTC|newest]
Thread overview: 130+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-25 12:08 [PATCH v5 000/111] pwm: Improve lifetime tracking for pwm_chips Uwe Kleine-König
2024-01-25 12:08 ` [PATCH v5 001/111] pwm: Reorder symbols in core.c Uwe Kleine-König
2024-01-25 12:08 ` Uwe Kleine-König [this message]
2024-01-25 12:08 ` [PATCH v5 003/111] pwm: Provide a macro to get the parent device of a given chip Uwe Kleine-König
2024-01-25 14:14 ` AngeloGioacchino Del Regno
2024-01-25 19:32 ` Florian Fainelli
2024-01-25 20:29 ` Uwe Kleine-König
2024-01-25 20:54 ` Uwe Kleine-König
2024-01-25 12:08 ` [PATCH v5 004/111] pwm: ab8500: Make use of pwmchip_parent() macro Uwe Kleine-König
2024-01-25 12:08 ` [PATCH v5 005/111] pwm: atmel: " Uwe Kleine-König
2024-01-25 12:08 ` [PATCH v5 006/111] pwm: atmel-tcb: " Uwe Kleine-König
2024-01-25 12:08 ` [PATCH v5 007/111] pwm: bcm-kona: " Uwe Kleine-König
2024-01-25 12:08 ` [PATCH v5 008/111] pwm: crc: " Uwe Kleine-König
2024-01-25 12:08 ` [PATCH v5 009/111] pwm: cros-ec: " Uwe Kleine-König
2024-01-25 12:08 ` [PATCH v5 010/111] pwm: dwc: " Uwe Kleine-König
2024-01-25 12:08 ` [PATCH v5 011/111] pwm: ep93xx: " Uwe Kleine-König
2024-01-25 12:08 ` [PATCH v5 012/111] pwm: fsl-ftm: " Uwe Kleine-König
2024-01-25 12:08 ` [PATCH v5 013/111] pwm: img: Make use of parent device pointer in driver data Uwe Kleine-König
2024-01-25 12:08 ` [PATCH v5 014/111] pwm: imx27: Make use of pwmchip_parent() macro Uwe Kleine-König
2024-01-25 12:08 ` [PATCH v5 015/111] pwm: jz4740: " Uwe Kleine-König
2024-01-25 12:08 ` [PATCH v5 016/111] pwm: lpc18xx-sct: Make use of parent device pointer in driver data Uwe Kleine-König
2024-01-25 12:08 ` [PATCH v5 017/111] pwm: lpss: Make use of pwmchip_parent() macro Uwe Kleine-König
2024-01-25 12:08 ` [PATCH v5 018/111] pwm: mediatek: " Uwe Kleine-König
2024-01-25 14:13 ` AngeloGioacchino Del Regno
2024-01-25 12:08 ` [PATCH v5 019/111] pwm: meson: " Uwe Kleine-König
2024-01-25 12:08 ` [PATCH v5 020/111] pwm: mtk-disp: " Uwe Kleine-König
2024-01-25 14:13 ` AngeloGioacchino Del Regno
2024-01-25 12:08 ` [PATCH v5 021/111] pwm: omap: " Uwe Kleine-König
2024-01-25 12:08 ` [PATCH v5 022/111] pwm: pca9685: Store parent device in driver data Uwe Kleine-König
2024-01-25 12:08 ` [PATCH v5 023/111] pwm: raspberrypi-poe: Make use of pwmchip_parent() macro Uwe Kleine-König
2024-01-25 12:08 ` [PATCH v5 024/111] pwm: rcar: " Uwe Kleine-König
2024-01-25 12:08 ` [PATCH v5 025/111] pwm: rz-mtu3: " Uwe Kleine-König
2024-01-25 12:08 ` [PATCH v5 026/111] pwm: samsung: " Uwe Kleine-König
2024-01-25 12:08 ` [PATCH v5 027/111] pwm: sifive: " Uwe Kleine-König
2024-01-25 12:08 ` [PATCH v5 028/111] pwm: stm32-lp: " Uwe Kleine-König
2024-01-25 12:08 ` [PATCH v5 029/111] pwm: stm32: " Uwe Kleine-König
2024-01-25 12:08 ` [PATCH v5 030/111] pwm: stmpe: " Uwe Kleine-König
2024-01-25 12:08 ` [PATCH v5 031/111] pwm: sun4i: " Uwe Kleine-König
2024-01-25 12:08 ` [PATCH v5 032/111] pwm: tiecap: " Uwe Kleine-König
2024-01-25 12:08 ` [PATCH v5 033/111] pwm: tiehrpwm: " Uwe Kleine-König
2024-01-25 12:08 ` [PATCH v5 034/111] pwm: twl-led: " Uwe Kleine-König
2024-01-25 12:08 ` [PATCH v5 035/111] pwm: twl: " Uwe Kleine-König
2024-01-25 12:08 ` [PATCH v5 036/111] pwm: vt8500: " Uwe Kleine-König
2024-01-25 12:09 ` [PATCH v5 038/111] staging: greybus: pwm: " Uwe Kleine-König
2024-01-26 14:46 ` Alex Elder
2024-01-26 17:14 ` Uwe Kleine-König
2024-01-25 12:09 ` [PATCH v5 039/111] pwm: Provide wrappers for storing and getting driver private data Uwe Kleine-König
2024-01-25 14:13 ` AngeloGioacchino Del Regno
2024-01-25 12:09 ` [PATCH v5 040/111] pwm: Provide devm_pwmchip_alloc() function Uwe Kleine-König
2024-01-26 14:56 ` Alex Elder
2024-01-26 17:10 ` Uwe Kleine-König
2024-01-25 12:09 ` [PATCH v5 041/111] pwm: ab8500: Make use of " Uwe Kleine-König
2024-01-25 12:09 ` [PATCH v5 042/111] pwm: apple: " Uwe Kleine-König
2024-01-25 12:09 ` [PATCH v5 043/111] pwm: atmel-hlcdc: " Uwe Kleine-König
2024-01-25 12:09 ` [PATCH v5 044/111] pwm: atmel: " Uwe Kleine-König
2024-01-25 12:09 ` [PATCH v5 045/111] pwm: atmel-tcb: " Uwe Kleine-König
2024-01-25 12:09 ` [PATCH v5 046/111] pwm: bcm2835: " Uwe Kleine-König
2024-01-25 12:09 ` [PATCH v5 047/111] pwm: bcm-iproc: " Uwe Kleine-König
2024-01-25 12:09 ` [PATCH v5 048/111] pwm: bcm-kona: " Uwe Kleine-König
2024-01-25 12:09 ` [PATCH v5 049/111] pwm: berlin: " Uwe Kleine-König
2024-01-25 12:09 ` [PATCH v5 050/111] pwm: brcmstb: " Uwe Kleine-König
2024-01-25 12:09 ` [PATCH v5 051/111] pwm: clk: " Uwe Kleine-König
2024-01-25 12:09 ` [PATCH v5 052/111] pwm: clps711x: " Uwe Kleine-König
2024-01-25 12:09 ` [PATCH v5 053/111] pwm: crc: " Uwe Kleine-König
2024-01-25 12:09 ` [PATCH v5 054/111] pwm: cros-ec: " Uwe Kleine-König
2024-01-25 12:09 ` [PATCH v5 055/111] pwm: dwc: " Uwe Kleine-König
2024-01-25 12:09 ` [PATCH v5 056/111] pwm: ep93xx: " Uwe Kleine-König
2024-01-25 12:09 ` [PATCH v5 057/111] pwm: fsl-ftm: " Uwe Kleine-König
2024-01-25 12:09 ` [PATCH v5 058/111] pwm: hibvt: " Uwe Kleine-König
2024-01-25 12:09 ` [PATCH v5 059/111] pwm: img: " Uwe Kleine-König
2024-01-25 12:09 ` [PATCH v5 060/111] pwm: imx1: " Uwe Kleine-König
2024-01-25 12:09 ` [PATCH v5 061/111] pwm: imx27: " Uwe Kleine-König
2024-01-25 12:09 ` [PATCH v5 062/111] pwm: imx-tpm: " Uwe Kleine-König
2024-01-25 12:09 ` [PATCH v5 063/111] pwm: intel-lgm: " Uwe Kleine-König
2024-01-25 12:09 ` [PATCH v5 064/111] pwm: iqs620a: " Uwe Kleine-König
2024-01-25 12:09 ` [PATCH v5 065/111] pwm: jz4740: " Uwe Kleine-König
2024-01-25 12:09 ` [PATCH v5 066/111] pwm: keembay: " Uwe Kleine-König
2024-01-25 12:09 ` [PATCH v5 067/111] pwm: lp3943: " Uwe Kleine-König
2024-01-25 12:09 ` [PATCH v5 068/111] pwm: lpc18xx-sct: " Uwe Kleine-König
2024-01-25 12:09 ` [PATCH v5 069/111] pwm: lpc32xx: " Uwe Kleine-König
2024-01-25 12:09 ` [PATCH v5 070/111] pwm: lpss-*: " Uwe Kleine-König
2024-01-25 12:09 ` [PATCH v5 071/111] pwm: mediatek: " Uwe Kleine-König
2024-01-25 12:09 ` [PATCH v5 072/111] pwm: meson: " Uwe Kleine-König
2024-01-25 12:09 ` [PATCH v5 073/111] pwm: microchip-core: " Uwe Kleine-König
2024-01-25 12:09 ` [PATCH v5 074/111] pwm: mtk-disp: " Uwe Kleine-König
2024-01-25 14:13 ` AngeloGioacchino Del Regno
2024-01-25 12:09 ` [PATCH v5 075/111] pwm: mxs: " Uwe Kleine-König
2024-01-25 12:09 ` [PATCH v5 076/111] pwm: ntxec: " Uwe Kleine-König
2024-01-25 12:09 ` [PATCH v5 077/111] pwm: omap-dmtimer: " Uwe Kleine-König
2024-01-25 12:09 ` [PATCH v5 078/111] pwm: pca9685: " Uwe Kleine-König
2024-01-25 12:09 ` [PATCH v5 079/111] pwm: pxa: " Uwe Kleine-König
2024-01-25 12:09 ` [PATCH v5 080/111] pwm: raspberrypi-poe: " Uwe Kleine-König
2024-01-25 12:09 ` [PATCH v5 081/111] pwm: rcar: " Uwe Kleine-König
2024-01-25 12:09 ` [PATCH v5 082/111] pwm: renesas-tpu: " Uwe Kleine-König
2024-01-25 12:09 ` [PATCH v5 083/111] pwm: rockchip: " Uwe Kleine-König
2024-01-25 12:09 ` [PATCH v5 084/111] pwm: rz-mtu3: " Uwe Kleine-König
2024-01-25 12:09 ` [PATCH v5 085/111] pwm: samsung: " Uwe Kleine-König
2024-01-25 12:09 ` [PATCH v5 086/111] pwm: sifive: " Uwe Kleine-König
2024-01-25 12:09 ` [PATCH v5 087/111] pwm: sl28cpld: " Uwe Kleine-König
2024-01-25 12:26 ` Michael Walle
2024-01-25 13:19 ` Uwe Kleine-König
2024-01-25 13:28 ` Michael Walle
2024-01-25 16:33 ` Uwe Kleine-König
2024-01-26 8:15 ` Michael Walle
2024-01-25 12:09 ` [PATCH v5 088/111] pwm: spear: " Uwe Kleine-König
2024-01-25 12:09 ` [PATCH v5 089/111] pwm: sprd: " Uwe Kleine-König
2024-01-25 12:09 ` [PATCH v5 090/111] pwm: sti: " Uwe Kleine-König
2024-01-25 12:09 ` [PATCH v5 091/111] pwm: stm32-lp: " Uwe Kleine-König
2024-01-25 12:09 ` [PATCH v5 092/111] pwm: stm32: " Uwe Kleine-König
2024-01-25 12:09 ` [PATCH v5 093/111] pwm: stmpe: " Uwe Kleine-König
2024-01-25 12:09 ` [PATCH v5 094/111] pwm: sun4i: " Uwe Kleine-König
2024-01-25 12:09 ` [PATCH v5 095/111] pwm: sunplus: " Uwe Kleine-König
2024-01-25 12:09 ` [PATCH v5 096/111] pwm: tegra: " Uwe Kleine-König
2024-01-25 12:09 ` [PATCH v5 097/111] pwm: tiecap: " Uwe Kleine-König
2024-01-25 12:10 ` [PATCH v5 098/111] pwm: twl-led: " Uwe Kleine-König
2024-01-25 12:10 ` [PATCH v5 099/111] pwm: twl: " Uwe Kleine-König
2024-01-25 12:10 ` [PATCH v5 100/111] pwm: visconti: " Uwe Kleine-König
2024-01-25 12:10 ` [PATCH v5 101/111] pwm: vt8500: " Uwe Kleine-König
2024-01-25 12:10 ` [PATCH v5 102/111] pwm: xilinx: " Uwe Kleine-König
2024-01-25 12:10 ` [PATCH v5 103/111] gpio: mvebu: " Uwe Kleine-König
2024-01-25 14:38 ` Linus Walleij
2024-01-25 12:10 ` [PATCH v5 104/111] drm/bridge: ti-sn65dsi86: " Uwe Kleine-König
2024-01-25 17:48 ` Doug Anderson
2024-01-25 20:36 ` Uwe Kleine-König
2024-01-25 12:10 ` [PATCH v5 105/111] leds: qcom-lpg: " Uwe Kleine-König
2024-01-25 12:10 ` [PATCH v5 107/111] pwm: Ensure that pwm_chips are allocated using pwmchip_alloc() Uwe Kleine-König
2024-01-25 12:10 ` [PATCH v5 108/111] pwm: Ensure a struct pwm has the same lifetime as its pwm_chip Uwe Kleine-König
2024-01-25 12:10 ` [PATCH v5 109/111] pwm: Ensure the memory backing a PWM chip isn't freed while used Uwe Kleine-König
2024-01-25 12:10 ` [PATCH v5 110/111] pwm: Make pwmchip_[sg]et_drvdata() a wrapper around dev_set_drvdata() Uwe Kleine-König
2024-01-25 12:10 ` [PATCH v5 111/111] WIP: pwm: Add support for pwmchip devices for faster and easier userspace access Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=578f3c0f4394ed97da2d7ff1a4d2f4b95f3b24f6.1706182805.git.u.kleine-koenig@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=bleung@chromium.org \
--cc=chrome-platform@lists.linux.dev \
--cc=groeck@chromium.org \
--cc=kernel@pengutronix.de \
--cc=linux-pwm@vger.kernel.org \
--cc=tzungbi@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).