From: Thomas Zimmermann <tzimmermann@suse.de>
To: lee@kernel.org, andy@kernel.org, daniel.thompson@linaro.org,
jingoohan1@gmail.com, deller@gmx.de, robin@protonic.nl,
javierm@redhat.com
Cc: dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org,
linux-input@vger.kernel.org, linux-pwm@vger.kernel.org,
Thomas Zimmermann <tzimmermann@suse.de>
Subject: [PATCH v3 02/10] auxdisplay/ht16k33: Remove struct backlight_ops.check_fb
Date: Mon, 4 Mar 2024 17:29:47 +0100 [thread overview]
Message-ID: <20240304163220.19144-3-tzimmermann@suse.de> (raw)
In-Reply-To: <20240304163220.19144-1-tzimmermann@suse.de>
The driver sets struct fb_info.bl_dev to the correct backlight
device. Thus rely on the backlight core code to match backlight
and framebuffer devices, and remove the extra check_fb() function
from struct backlight_ops.
v3:
* use 'check_fb()' in commit message (Andy)
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Cc: Robin van der Gracht <robin@protonic.nl>
Acked-by: Robin van der Gracht <robin@protonic.nl>
Acked-by: Andy Shevchenko <andy@kernel.org>
Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
---
drivers/auxdisplay/ht16k33.c | 8 --------
1 file changed, 8 deletions(-)
diff --git a/drivers/auxdisplay/ht16k33.c b/drivers/auxdisplay/ht16k33.c
index a90430b7d07ba..0a858db32486b 100644
--- a/drivers/auxdisplay/ht16k33.c
+++ b/drivers/auxdisplay/ht16k33.c
@@ -325,16 +325,8 @@ static int ht16k33_bl_update_status(struct backlight_device *bl)
return ht16k33_brightness_set(priv, brightness);
}
-static int ht16k33_bl_check_fb(struct backlight_device *bl, struct fb_info *fi)
-{
- struct ht16k33_priv *priv = bl_get_data(bl);
-
- return (fi == NULL) || (fi->par == priv);
-}
-
static const struct backlight_ops ht16k33_bl_ops = {
.update_status = ht16k33_bl_update_status,
- .check_fb = ht16k33_bl_check_fb,
};
/*
--
2.44.0
next prev parent reply other threads:[~2024-03-04 16:32 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-04 16:29 [PATCH v3 00/10] backlight: Replace struct fb_info in interfaces Thomas Zimmermann
2024-03-04 16:29 ` [PATCH v3 01/10] backlight: Match backlight device against struct fb_info.bl_dev Thomas Zimmermann
2024-03-04 16:29 ` Thomas Zimmermann [this message]
2024-03-04 16:29 ` [PATCH v3 03/10] hid/hid-picolcd: Fix initialization order Thomas Zimmermann
2024-03-04 16:29 ` [PATCH v3 04/10] hid/hid-picolcd: Remove struct backlight_ops.check_fb Thomas Zimmermann
2024-03-04 16:29 ` [PATCH v3 05/10] backlight/aat2870-backlight: Remove struct backlight.check_fb Thomas Zimmermann
2024-03-04 16:29 ` [PATCH v3 06/10] backlight/pwm-backlight: Remove struct backlight_ops.check_fb Thomas Zimmermann
2024-03-04 16:29 ` [PATCH v3 07/10] fbdev/sh_mobile_lcdc_fb: " Thomas Zimmermann
2024-03-04 16:29 ` [PATCH v3 08/10] fbdev/ssd1307fb: Init backlight before registering framebuffer Thomas Zimmermann
2024-03-04 16:29 ` [PATCH v3 09/10] fbdev/ssd1307fb: Remove struct backlight_ops.check_fb Thomas Zimmermann
2024-03-04 16:29 ` [PATCH v3 10/10] backlight: Add controls_device callback to struct backlight_ops Thomas Zimmermann
2024-03-05 9:36 ` [PATCH v3 00/10] backlight: Replace struct fb_info in interfaces Lee Jones
2024-03-05 10:00 ` Thomas Zimmermann
2024-03-05 10:30 ` Lee Jones
2024-03-05 10:44 ` Lee Jones
2024-03-05 14:53 ` Lee Jones
2024-03-05 16:04 ` Thomas Zimmermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240304163220.19144-3-tzimmermann@suse.de \
--to=tzimmermann@suse.de \
--cc=andy@kernel.org \
--cc=daniel.thompson@linaro.org \
--cc=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=javierm@redhat.com \
--cc=jingoohan1@gmail.com \
--cc=lee@kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=robin@protonic.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).