From: Raag Jadav <raag.jadav@intel.com>
To: u.kleine-koenig@pengutronix.de, jarkko.nikula@linux.intel.com,
mika.westerberg@linux.intel.com,
andriy.shevchenko@linux.intel.com, lakshmi.sowjanya.d@intel.com
Cc: linux-pwm@vger.kernel.org, linux-kernel@vger.kernel.org,
Raag Jadav <raag.jadav@intel.com>
Subject: [PATCH v4 2/4] pwm: dwc: drop redundant error check
Date: Mon, 19 Feb 2024 09:08:33 +0530 [thread overview]
Message-ID: <20240219033835.11369-3-raag.jadav@intel.com> (raw)
In-Reply-To: <20240219033835.11369-1-raag.jadav@intel.com>
pcim_iomap_table() fails only if pcim_iomap_regions() fails. No need to
check for failure if the latter is already successful.
Suggested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Raag Jadav <raag.jadav@intel.com>
Tested-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
---
drivers/pwm/pwm-dwc.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/pwm/pwm-dwc.c b/drivers/pwm/pwm-dwc.c
index c0e586688e57..7dbb72c80ef5 100644
--- a/drivers/pwm/pwm-dwc.c
+++ b/drivers/pwm/pwm-dwc.c
@@ -51,11 +51,8 @@ static int dwc_pwm_probe(struct pci_dev *pci, const struct pci_device_id *id)
return ret;
}
+ /* No need to check for failure, pcim_iomap_regions() does it for us. */
dwc->base = pcim_iomap_table(pci)[0];
- if (!dwc->base) {
- dev_err(dev, "Base address missing\n");
- return -ENOMEM;
- }
ret = devm_pwmchip_add(dev, chip);
if (ret)
--
2.35.3
next prev parent reply other threads:[~2024-02-19 3:38 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-19 3:38 [PATCH v4 0/4] DesignWare PWM improvements Raag Jadav
2024-02-19 3:38 ` [PATCH v4 1/4] pwm: dwc: Fix PM regression Raag Jadav
2024-02-19 7:22 ` Uwe Kleine-König
2024-02-19 9:05 ` Raag Jadav
2024-02-19 3:38 ` Raag Jadav [this message]
2024-02-19 7:11 ` [PATCH v4 2/4] pwm: dwc: drop redundant error check Thorsten Scherer
2024-02-19 7:27 ` Uwe Kleine-König
2024-02-19 9:15 ` Raag Jadav
2024-02-19 8:00 ` Thorsten Scherer
2024-02-19 3:38 ` [PATCH v4 3/4] pwm: dwc: Add 16 channel support for Intel Elkhart Lake Raag Jadav
2024-02-19 3:38 ` [PATCH v4 4/4] pwm: dwc: simplify error handling Raag Jadav
2024-02-20 16:00 ` [PATCH v4 0/4] DesignWare PWM improvements Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240219033835.11369-3-raag.jadav@intel.com \
--to=raag.jadav@intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=jarkko.nikula@linux.intel.com \
--cc=lakshmi.sowjanya.d@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).