From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Paul Cercueil <paul@crapouillou.net>,
Thierry Reding <thierry.reding@gmail.com>
Cc: linux-mips@vger.kernel.org, linux-pwm@vger.kernel.org,
kernel@pengutronix.de
Subject: [PATCH] pwm: jz4740: Add trailing \n to error messages
Date: Thu, 23 Nov 2023 09:33:23 +0100 [thread overview]
Message-ID: <20231123083322.405390-1-u.kleine-koenig@pengutronix.de> (raw)
Error messages are supposed to end in \n. Add the line terminator to the
two error messages that lack this.
Suggested-by: Paul Cercueil <paul@crapouillou.net>
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
Hello,
this was noticed by Paul in
https://lore.kernel.org/linux-pwm/ba21c20b20364a39d5ffff81dac8bd300a746dbb.camel@crapouillou.net.
Instead of sneaking this into a patch that probably won't get applied
quickly, make this explicit.
I based it on top of my PR that can be found at
https://lore.kernel.org/linux-pwm/20231121112029.gyv3gqirlycysyr4@pengutronix.de,
but applies just fine to v6.7-rc1.
If you want a fixes-line, that would be:
Fixes: 485b56f08f33 ("pwm: jz4740: Improve algorithm of clock calculation")
for the first hunk and
Fixes: ce1f9cece057 ("pwm: jz4740: Use clocks from TCU driver")
for the second. If this is backported to something before
v5.10-rc1~57^2~11, there is another instance with a missing \n.
Best regards
Uwe
drivers/pwm/pwm-jz4740.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/pwm/pwm-jz4740.c b/drivers/pwm/pwm-jz4740.c
index e9375de60ad6..73f96cef1662 100644
--- a/drivers/pwm/pwm-jz4740.c
+++ b/drivers/pwm/pwm-jz4740.c
@@ -149,7 +149,7 @@ static int jz4740_pwm_apply(struct pwm_chip *chip, struct pwm_device *pwm,
*/
rate = clk_round_rate(clk, tmp);
if (rate < 0) {
- dev_err(chip->dev, "Unable to round rate: %ld", rate);
+ dev_err(chip->dev, "Unable to round rate: %ld\n", rate);
return rate;
}
@@ -170,7 +170,7 @@ static int jz4740_pwm_apply(struct pwm_chip *chip, struct pwm_device *pwm,
err = clk_set_rate(clk, rate);
if (err) {
- dev_err(chip->dev, "Unable to set rate: %d", err);
+ dev_err(chip->dev, "Unable to set rate: %d\n", err);
return err;
}
base-commit: 869de350ff3834145273a6d39faedea878c6715a
--
2.42.0
next reply other threads:[~2023-11-23 8:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-23 8:33 Uwe Kleine-König [this message]
2023-11-24 12:43 ` [PATCH] pwm: jz4740: Add trailing \n to error messages Thierry Reding
2023-12-04 17:12 ` Uwe Kleine-König
2023-11-28 16:59 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231123083322.405390-1-u.kleine-koenig@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=kernel@pengutronix.de \
--cc=linux-mips@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=paul@crapouillou.net \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).