From: "Ricardo B. Marliere" <ricardo@marliere.net>
To: Yisen Zhuang <yisen.zhuang@huawei.com>,
Salil Mehta <salil.mehta@huawei.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
Paolo Abeni <pabeni@redhat.com>,
Loic Poulain <loic.poulain@linaro.org>,
Sergey Ryazanov <ryazanov.s.a@gmail.com>,
Johannes Berg <johannes@sipsolutions.net>,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-ppp@vger.kernel.org,
"Ricardo B. Marliere" <ricardo@marliere.net>
Subject: [PATCH net-next 6/6] nfc: core: make nfc_class constant
Date: Sat, 02 Mar 2024 14:06:02 -0300 [thread overview]
Message-ID: <20240302-class_cleanup-net-next-v1-6-8fa378595b93@marliere.net> (raw)
In-Reply-To: <20240302-class_cleanup-net-next-v1-0-8fa378595b93@marliere.net>
Since commit 43a7206b0963 ("driver core: class: make class_register() take
a const *"), the driver core allows for struct class to be in read-only
memory, so move the nfc_class structure to be declared at build time
placing it into read-only memory, instead of having to be dynamically
allocated at boot time.
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Suggested-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Ricardo B. Marliere <ricardo@marliere.net>
---
include/net/nfc/nfc.h | 2 +-
net/nfc/core.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/net/nfc/nfc.h b/include/net/nfc/nfc.h
index 5dee575fbe86..3d07abacf08b 100644
--- a/include/net/nfc/nfc.h
+++ b/include/net/nfc/nfc.h
@@ -196,7 +196,7 @@ struct nfc_dev {
};
#define to_nfc_dev(_dev) container_of(_dev, struct nfc_dev, dev)
-extern struct class nfc_class;
+extern const struct class nfc_class;
struct nfc_dev *nfc_allocate_device(const struct nfc_ops *ops,
u32 supported_protocols,
diff --git a/net/nfc/core.c b/net/nfc/core.c
index eb2c0959e5b6..e58dc6405054 100644
--- a/net/nfc/core.c
+++ b/net/nfc/core.c
@@ -1015,7 +1015,7 @@ static void nfc_check_pres_timeout(struct timer_list *t)
schedule_work(&dev->check_pres_work);
}
-struct class nfc_class = {
+const struct class nfc_class = {
.name = "nfc",
.dev_release = nfc_release,
};
--
2.43.0
next prev parent reply other threads:[~2024-03-02 17:06 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-02 17:05 [PATCH net-next 0/6] net: constify struct class usage Ricardo B. Marliere
2024-03-02 17:05 ` [PATCH net-next 1/6] net: hns: make hnae_class constant Ricardo B. Marliere
2024-03-04 17:52 ` Simon Horman
2024-03-02 17:05 ` [PATCH net-next 2/6] net: wan: framer: make framer_class constant Ricardo B. Marliere
2024-03-04 17:52 ` Simon Horman
2024-03-05 7:17 ` Herve Codina
2024-03-02 17:05 ` [PATCH net-next 3/6] net: ppp: make ppp_class constant Ricardo B. Marliere
2024-03-04 17:53 ` Simon Horman
2024-03-04 20:19 ` Breno Leitao
2024-03-02 17:06 ` [PATCH net-next 4/6] net: wwan: hwsim: make wwan_hwsim_class constant Ricardo B. Marliere
2024-03-02 17:06 ` [PATCH net-next 5/6] net: wwan: core: make wwan_class constant Ricardo B. Marliere
2024-03-02 17:06 ` Ricardo B. Marliere [this message]
2024-03-04 17:53 ` [PATCH net-next 6/6] nfc: core: make nfc_class constant Simon Horman
2024-03-04 20:19 ` Breno Leitao
2024-03-05 20:00 ` [PATCH net-next 0/6] net: constify struct class usage patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240302-class_cleanup-net-next-v1-6-8fa378595b93@marliere.net \
--to=ricardo@marliere.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=johannes@sipsolutions.net \
--cc=krzysztof.kozlowski@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-ppp@vger.kernel.org \
--cc=loic.poulain@linaro.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=ryazanov.s.a@gmail.com \
--cc=salil.mehta@huawei.com \
--cc=yisen.zhuang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).