From: Guillaume Nault <g.nault@alphalink.fr>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Paul Mackerras <paulus@samba.org>,
linux-ppp@vger.kernel.org, Networking <netdev@vger.kernel.org>,
mitch@sfgoth.com, mostrows@earthlink.net, jchapman@katalix.com,
xeb@mail.ru, David Miller <davem@davemloft.net>,
Al Viro <viro@zeniv.linux.org.uk>,
y2038 Mailman List <y2038@lists.linaro.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next 1/5] pppoe: fix PPPOEIOCSFWD compat handling
Date: Thu, 30 Aug 2018 13:09:57 +0000 [thread overview]
Message-ID: <20180830130957.GD1473@alphalink.fr> (raw)
In-Reply-To: <CAK8P3a1WSa5yPWXYGieAc0+Xk=CAy_G-RhNNcQBsGQGOU-8WfA@mail.gmail.com>
On Thu, Aug 30, 2018 at 01:54:48PM +0200, Arnd Bergmann wrote:
> On Thu, Aug 30, 2018 at 1:04 PM Guillaume Nault <g.nault@alphalink.fr> wrote:
> >
> > On Wed, Aug 29, 2018 at 04:03:26PM +0200, Arnd Bergmann wrote:
> > > Support for handling the PPPOEIOCSFWD ioctl in compat mode was added in
> > > linux-2.5.69 along with hundreds of other commands, but was always broken
> > > sincen only the structure is compatible, but the command number is not,
> > > due to the size being sizeof(size_t), or at first sizeof(sizeof((struct
> > > sockaddr_pppox)), which is different on 64-bit architectures.
> > >
> > And the implementation was broken until 2016 (see 29e73269aa4d ("pppoe:
> > fix reference counting in PPPoE proxy")), and nobody ever noticed. I
> > should probably have removed this ioctl entirely instead of fixing it.
> > Clearly, it has never been used.
> >
> > If you think it's worth fixing (as opposed to dropping this ioctl or
> > its compat mode), then,
> > Acked-by: Guillaume Nault <g.nault@alphalink.fr>
>
> I don't care much, but fixing it seems seems easier than coming
> up with a convincing rationale for dropping.
>
> I'll update the changelog text to include your additional background
> information though, unless someone else prefers to have it dropped.
>
Sounds good. Thanks.
prev parent reply other threads:[~2018-08-30 13:09 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-29 14:03 [PATCH net-next 1/5] pppoe: fix PPPOEIOCSFWD compat handling Arnd Bergmann
2018-08-29 14:03 ` [PATCH net-next 2/5] ppp: move simple ioctl compat handling out of fs_compat_ioctl.c Arnd Bergmann
2018-08-29 14:03 ` [PATCH net-next 3/5] ppp: move PPPIOCSCOMPRESS32 to ppp-generic.c Arnd Bergmann
2018-08-30 11:04 ` Guillaume Nault
2018-08-29 14:03 ` [PATCH net-next 4/5] ppp: move PPPIOCSPASS32/PPPIOCSACTIVE32 to ppp_generic.c Arnd Bergmann
2018-08-30 11:05 ` Guillaume Nault
2018-08-29 14:03 ` [PATCH net-next 5/5] ppp: handle PPPIOCGIDLE for 64-bit time_t Arnd Bergmann
2018-08-30 11:06 ` Guillaume Nault
2018-08-30 11:47 ` Arnd Bergmann
2018-08-30 11:04 ` [PATCH net-next 1/5] pppoe: fix PPPOEIOCSFWD compat handling Guillaume Nault
2018-08-30 11:54 ` Arnd Bergmann
2018-08-30 13:09 ` Guillaume Nault [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180830130957.GD1473@alphalink.fr \
--to=g.nault@alphalink.fr \
--cc=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=jchapman@katalix.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-ppp@vger.kernel.org \
--cc=mitch@sfgoth.com \
--cc=mostrows@earthlink.net \
--cc=netdev@vger.kernel.org \
--cc=paulus@samba.org \
--cc=viro@zeniv.linux.org.uk \
--cc=xeb@mail.ru \
--cc=y2038@lists.linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).