From: Sebastian Reichel <sebastian.reichel@collabora.com>
To: Conor Dooley <conor@kernel.org>
Cc: Herman van Hazendonk <github.com@herrie.org>,
benwolsieffer@gmail.com, chris.chapuis@gmail.com,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: power: supply: max8903: specify flt-gpios as input
Date: Tue, 30 Apr 2024 16:51:42 +0200 [thread overview]
Message-ID: <n7mahydeipds3zwynt73gpfrujsu54yo7xwztesqrxem7eumqk@7wa6nhm6iyfc> (raw)
In-Reply-To: <20240415-pretty-recite-127842ed9a10@spud>
[-- Attachment #1: Type: text/plain, Size: 1700 bytes --]
Hi,
On Mon, Apr 15, 2024 at 05:28:22PM +0100, Conor Dooley wrote:
> On Mon, Apr 15, 2024 at 05:16:45PM +0200, Herman van Hazendonk wrote:
> > The FLT pin was incorrected documented as an output. The MAX8903 uses it to
> > signal to the processor that a charging fault has occurred.
>
> I guess this is just a matter of framing? Input to the hardware running
> the OS but an output from the max8903?
>
> I'm okay with whatever wording causing less confusion, which may mean
> something that specifics what this is relative to?
well, this definitely improves things, since the other GPIOs
from the same file are all described with the hardware running
the OS being the reference. So this makes things at least
uniform.
> >
> > Signed-off-by: Herman van Hazendonk <github.com@herrie.org>
>
> The SoB email should match the from email fyi.
It does for this patch, so I took it.
Greetings,
-- Sebastian
> Cheers,
> Conor.
>
> > ---
> > .../devicetree/bindings/power/supply/maxim,max8903.yaml | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/power/supply/maxim,max8903.yaml b/Documentation/devicetree/bindings/power/supply/maxim,max8903.yaml
> > index a8d625f285f1..86af38378999 100644
> > --- a/Documentation/devicetree/bindings/power/supply/maxim,max8903.yaml
> > +++ b/Documentation/devicetree/bindings/power/supply/maxim,max8903.yaml
> > @@ -34,7 +34,7 @@ properties:
> >
> > flt-gpios:
> > maxItems: 1
> > - description: Fault pin (active low, output)
> > + description: Fault pin (active low, input)
> >
> > dcm-gpios:
> > maxItems: 1
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2024-04-30 14:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-15 15:16 [PATCH 1/2] dt-bindings: power: supply: max8903: specify flt-gpios as input Herman van Hazendonk
2024-04-15 16:28 ` Conor Dooley
2024-04-30 14:51 ` Sebastian Reichel [this message]
2024-04-30 14:44 ` Sebastian Reichel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=n7mahydeipds3zwynt73gpfrujsu54yo7xwztesqrxem7eumqk@7wa6nhm6iyfc \
--to=sebastian.reichel@collabora.com \
--cc=benwolsieffer@gmail.com \
--cc=chris.chapuis@gmail.com \
--cc=conor+dt@kernel.org \
--cc=conor@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=github.com@herrie.org \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).