From: Cristian Marussi <cristian.marussi@arm.com>
To: Lukasz Luba <lukasz.luba@arm.com>
Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
dietmar.eggemann@arm.com, linux-arm-kernel@lists.infradead.org,
sudeep.holla@arm.com, linux-samsung-soc@vger.kernel.org,
rafael@kernel.org, viresh.kumar@linaro.org,
quic_sibis@quicinc.com
Subject: Re: [PATCH 2/2] cpufreq: scmi: Update Energy Model with allowed performance limits
Date: Wed, 1 May 2024 10:26:43 +0100 [thread overview]
Message-ID: <ZjIK0-7ixgp0WQ4x@pluto> (raw)
In-Reply-To: <20240403162315.1458337-3-lukasz.luba@arm.com>
On Wed, Apr 03, 2024 at 05:23:15PM +0100, Lukasz Luba wrote:
> The Energy Model (EM) supports performance limits updates. Use the SCMI
> notifications to get information from FW about allowed frequency scope for
> the CPUs.
>
> Signed-off-by: Lukasz Luba <lukasz.luba@arm.com>
> ---
> drivers/cpufreq/scmi-cpufreq.c | 19 ++++++++++++++++---
> 1 file changed, 16 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/cpufreq/scmi-cpufreq.c b/drivers/cpufreq/scmi-cpufreq.c
> index d946b7a082584..90c8448578cb1 100644
> --- a/drivers/cpufreq/scmi-cpufreq.c
> +++ b/drivers/cpufreq/scmi-cpufreq.c
> @@ -185,12 +185,25 @@ static int scmi_limit_notify_cb(struct notifier_block *nb, unsigned long event,
> {
> struct scmi_data *priv = container_of(nb, struct scmi_data, limit_notify_nb);
> struct scmi_perf_limits_report *limit_notify = data;
> + unsigned int limit_freq_max_khz, limit_freq_min_khz;
> struct cpufreq_policy *policy = priv->policy;
> - unsigned int limit_freq_khz;
> + struct em_perf_domain *pd;
> + int ret;
> +
> + limit_freq_max_khz = limit_notify->range_max_freq / HZ_PER_KHZ;
> + limit_freq_min_khz = limit_notify->range_min_freq / HZ_PER_KHZ;
Note that these values could be zeroed if the notification is good but
the range_min/range_max values could NOT be mapped to a frequency
equivalent (due to some FW errors).
I would probably have to add a warn about this error in the core SCMI
notification path (or drop the notif as a whole); if not here you could
end-up just setting max/min to 0 if the fw has messed up the
notification range_min/range_max.
Or is it just that, especially max_feq = 0 is NOT plausible value and you
will need anyway to check it here ?
>
> - limit_freq_khz = limit_notify->range_max_freq / HZ_PER_KHZ;
> + pd = em_cpu_get(policy->cpu);
> + if (pd) {
> + ret = em_update_performance_limits(pd, limit_freq_min_khz,
> + limit_freq_max_khz);
> + if (ret)
> + dev_warn(priv->cpu_dev,
> + "EM perf limits update failed\n");
> + }
>
> - policy->max = clamp(limit_freq_khz, policy->cpuinfo.min_freq, policy->cpuinfo.max_freq);
> + policy->max = clamp(limit_freq_max_khz, policy->cpuinfo.min_freq,
> + policy->cpuinfo.max_freq);
FWIW, regarding the SCMI bits.
LGTM.
Reviewed-by: Cristian Marussi <cristian.marussi@arm.com>
Thanks,
Cristian
next prev parent reply other threads:[~2024-05-01 9:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-03 16:23 [PATCH 0/2] Update Energy Model with perfromance limits Lukasz Luba
2024-04-03 16:23 ` [PATCH 1/2] PM: EM: Add min/max available performance state limits Lukasz Luba
2024-04-09 14:47 ` Hongyan Xia
2024-04-22 7:24 ` Lukasz Luba
2024-04-22 7:46 ` Dietmar Eggemann
2024-04-03 16:23 ` [PATCH 2/2] cpufreq: scmi: Update Energy Model with allowed performance limits Lukasz Luba
2024-04-22 13:11 ` Dietmar Eggemann
2024-04-22 13:55 ` Lukasz Luba
2024-05-01 9:26 ` Cristian Marussi [this message]
2024-04-05 9:56 ` [PATCH 0/2] Update Energy Model with perfromance limits Jonathan Cameron
2024-04-05 10:11 ` Lukasz Luba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZjIK0-7ixgp0WQ4x@pluto \
--to=cristian.marussi@arm.com \
--cc=dietmar.eggemann@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=lukasz.luba@arm.com \
--cc=quic_sibis@quicinc.com \
--cc=rafael@kernel.org \
--cc=sudeep.holla@arm.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).