From: xiongxin <xiongxin@kylinos.cn>
To: Pavel Machek <pavel@ucw.cz>, Xueqin Luo <luoxueqin@kylinos.cn>
Cc: rafael@kernel.org, len.brown@intel.com, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] PM: hibernate: add retry mechanism for S4 image loading failures
Date: Wed, 1 May 2024 15:43:03 +0800 [thread overview]
Message-ID: <4a1de64c-4be8-450d-9f12-e8ec9ac42778@kylinos.cn> (raw)
In-Reply-To: <ZjHgLlAC3ArqFLH0@ucw.cz>
On 2024/5/1 14:24, Pavel Machek wrote:
>> During the S4 resume process, there's a rare chance of image loading
>> failure. We provide three retries to load it successfully. If the
>> recovery fails after these attempts, print out the handle CRC32
>> value. When the CRC32 value obtained on each retry are inconsistent,
>> there may be a memory anomaly. When the values are consistent, it
>> might indicate corrupted swapped memory data.
>>
>> Signed-off-by: Xueqin Luo <luoxueqin@kylinos.cn>
>
> NAK. If machine is so broken it can't load memory image, it is not
> safe to continue.
>
> Pavel
Through a large number of tests, we found that when the CRC32 check
fails, the retry mechanism may make Image loading successful again. Even
if the final loading attempt fails, we can quickly analyze this anomaly
by examining the CRC32 values. If the CRC32 values from three attempts
are inconsistent, it may indicate a memory leakage issue; if they are
consistent, it may suggest changes in data within the disk.
>> ---
>> kernel/power/hibernate.c | 8 ++++++++
>> kernel/power/swap.c | 14 ++++++++------
>> 2 files changed, 16 insertions(+), 6 deletions(-)
>>
>> diff --git a/kernel/power/hibernate.c b/kernel/power/hibernate.c
>> index 43b1a82e800c..d9bcf38221ef 100644
>> --- a/kernel/power/hibernate.c
>> +++ b/kernel/power/hibernate.c
>> @@ -703,6 +703,7 @@ static int load_image_and_restore(void)
>> {
>> int error;
>> unsigned int flags;
>> + int cnt = 0;
>>
>> pm_pr_dbg("Loading hibernation image.\n");
>>
>> @@ -713,7 +714,14 @@ static int load_image_and_restore(void)
>> goto Unlock;
>> }
>>
>> +retry:
>> error = swsusp_read(&flags);
>> + if (error && (cnt++ < 3)) {
>> + pr_err("Failed to load hibernation image, trying to load again...\n");
>> + swsusp_free();
>> + goto retry;
>> + }
>> +
>> swsusp_close();
>> if (!error)
>> error = hibernation_restore(flags & SF_PLATFORM_MODE);
>> diff --git a/kernel/power/swap.c b/kernel/power/swap.c
>> index 5bc04bfe2db1..4b866c645cd7 100644
>> --- a/kernel/power/swap.c
>> +++ b/kernel/power/swap.c
>> @@ -1489,15 +1489,17 @@ static int load_compressed_image(struct swap_map_handle *handle,
>> ret = snapshot_write_finalize(snapshot);
>> if (!ret && !snapshot_image_loaded(snapshot))
>> ret = -ENODATA;
>> - if (!ret) {
>> - if (swsusp_header->flags & SF_CRC32_MODE) {
>> - if(handle->crc32 != swsusp_header->crc32) {
>> - pr_err("Invalid image CRC32!\n");
>> - ret = -ENODATA;
>> - }
>> + }
>> + if (!ret) {
>> + if (swsusp_header->flags & SF_CRC32_MODE) {
>> + if (handle->crc32 != swsusp_header->crc32) {
>> + pr_err("Invalid image CRC32, swsusp header CRC32: %u, handle CRC32: %u\n",
>> + swsusp_header->crc32, handle->crc32);
>> + ret = -ENODATA;
>> }
>> }
>> }
>> +
>> swsusp_show_speed(start, stop, nr_to_read, "Read");
>> out_clean:
>> hib_finish_batch(&hb);
>> 2.25.1
prev parent reply other threads:[~2024-05-01 7:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-01 6:12 [PATCH -next] PM: hibernate: add retry mechanism for S4 image loading failures Xueqin Luo
2024-05-01 6:24 ` Pavel Machek
2024-05-01 7:43 ` xiongxin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4a1de64c-4be8-450d-9f12-e8ec9ac42778@kylinos.cn \
--to=xiongxin@kylinos.cn \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=luoxueqin@kylinos.cn \
--cc=pavel@ucw.cz \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).