* [PATCH v2] thermal/drivers/mediatek/lvts_thermal: Remove filtered mode for mt8188
@ 2024-05-16 10:44 Julien Panis
2024-06-04 17:42 ` Daniel Lezcano
2024-06-12 17:12 ` [thermal: thermal/fixes] " thermal-bot for Julien Panis
0 siblings, 2 replies; 3+ messages in thread
From: Julien Panis @ 2024-05-16 10:44 UTC (permalink / raw
To: Rafael J. Wysocki, Daniel Lezcano, Zhang Rui, Lukasz Luba,
Matthias Brugger, AngeloGioacchino Del Regno, Nicolas Pitre
Cc: linux-pm, linux-kernel, linux-arm-kernel, linux-mediatek,
Julien Panis
Filtered mode is not supported on mt8188 SoC and is the source of bad
results. Move to immediate mode which provides good temperatures.
Fixes: f4745f546e60 ("thermal/drivers/mediatek/lvts_thermal: Add MT8188 support")
Reviewed-by: Nicolas Pitre <npitre@baylibre.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Signed-off-by: Julien Panis <jpanis@baylibre.com>
---
Filtered mode was set by mistake and difficulties with the test setup
prevented from catching this earlier. Use default mode (immediate mode)
instead.
---
Changes in v2:
- Add the Fixes tag.
- Link to v1: https://lore.kernel.org/r/20240515-mtk-thermal-mt8188-mode-fix-v1-1-e656b310b67f@baylibre.com
---
drivers/thermal/mediatek/lvts_thermal.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/drivers/thermal/mediatek/lvts_thermal.c b/drivers/thermal/mediatek/lvts_thermal.c
index 0bb3a495b56e..82c355c466cf 100644
--- a/drivers/thermal/mediatek/lvts_thermal.c
+++ b/drivers/thermal/mediatek/lvts_thermal.c
@@ -1458,7 +1458,6 @@ static const struct lvts_ctrl_data mt8188_lvts_mcu_data_ctrl[] = {
},
VALID_SENSOR_MAP(1, 1, 1, 1),
.offset = 0x0,
- .mode = LVTS_MSR_FILTERED_MODE,
},
{
.lvts_sensor = {
@@ -1469,7 +1468,6 @@ static const struct lvts_ctrl_data mt8188_lvts_mcu_data_ctrl[] = {
},
VALID_SENSOR_MAP(1, 1, 0, 0),
.offset = 0x100,
- .mode = LVTS_MSR_FILTERED_MODE,
}
};
@@ -1483,7 +1481,6 @@ static const struct lvts_ctrl_data mt8188_lvts_ap_data_ctrl[] = {
},
VALID_SENSOR_MAP(0, 1, 0, 0),
.offset = 0x0,
- .mode = LVTS_MSR_FILTERED_MODE,
},
{
.lvts_sensor = {
@@ -1496,7 +1493,6 @@ static const struct lvts_ctrl_data mt8188_lvts_ap_data_ctrl[] = {
},
VALID_SENSOR_MAP(1, 1, 1, 0),
.offset = 0x100,
- .mode = LVTS_MSR_FILTERED_MODE,
},
{
.lvts_sensor = {
@@ -1507,7 +1503,6 @@ static const struct lvts_ctrl_data mt8188_lvts_ap_data_ctrl[] = {
},
VALID_SENSOR_MAP(1, 1, 0, 0),
.offset = 0x200,
- .mode = LVTS_MSR_FILTERED_MODE,
},
{
.lvts_sensor = {
@@ -1518,7 +1513,6 @@ static const struct lvts_ctrl_data mt8188_lvts_ap_data_ctrl[] = {
},
VALID_SENSOR_MAP(1, 1, 0, 0),
.offset = 0x300,
- .mode = LVTS_MSR_FILTERED_MODE,
}
};
---
base-commit: 82d92a9a1b9ea0ea52aff27cddd05009b4edad49
change-id: 20240515-mtk-thermal-mt8188-mode-fix-e583d9a31da1
Best regards,
--
Julien Panis <jpanis@baylibre.com>
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] thermal/drivers/mediatek/lvts_thermal: Remove filtered mode for mt8188
2024-05-16 10:44 [PATCH v2] thermal/drivers/mediatek/lvts_thermal: Remove filtered mode for mt8188 Julien Panis
@ 2024-06-04 17:42 ` Daniel Lezcano
2024-06-12 17:12 ` [thermal: thermal/fixes] " thermal-bot for Julien Panis
1 sibling, 0 replies; 3+ messages in thread
From: Daniel Lezcano @ 2024-06-04 17:42 UTC (permalink / raw
To: Julien Panis, Rafael J. Wysocki, Zhang Rui, Lukasz Luba,
Matthias Brugger, AngeloGioacchino Del Regno, Nicolas Pitre
Cc: linux-pm, linux-kernel, linux-arm-kernel, linux-mediatek
On 16/05/2024 12:44, Julien Panis wrote:
> Filtered mode is not supported on mt8188 SoC and is the source of bad
> results. Move to immediate mode which provides good temperatures.
>
> Fixes: f4745f546e60 ("thermal/drivers/mediatek/lvts_thermal: Add MT8188 support")
> Reviewed-by: Nicolas Pitre <npitre@baylibre.com>
> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> Signed-off-by: Julien Panis <jpanis@baylibre.com>
> ---
> Filtered mode was set by mistake and difficulties with the test setup
> prevented from catching this earlier. Use default mode (immediate mode)
> instead.
> ---
Applied for v6.10-rc3
Thanks
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
^ permalink raw reply [flat|nested] 3+ messages in thread
* [thermal: thermal/fixes] thermal/drivers/mediatek/lvts_thermal: Remove filtered mode for mt8188
2024-05-16 10:44 [PATCH v2] thermal/drivers/mediatek/lvts_thermal: Remove filtered mode for mt8188 Julien Panis
2024-06-04 17:42 ` Daniel Lezcano
@ 2024-06-12 17:12 ` thermal-bot for Julien Panis
1 sibling, 0 replies; 3+ messages in thread
From: thermal-bot for Julien Panis @ 2024-06-12 17:12 UTC (permalink / raw
To: linux-pm
Cc: Nicolas Pitre, AngeloGioacchino Del Regno, Julien Panis,
Daniel Lezcano, rui.zhang, amitk
The following commit has been merged into the thermal/fixes branch of thermal:
Commit-ID: d9fef76e89498bf99cdb03f77b7091d7e95d7edd
Gitweb: https://git.kernel.org/pub/scm/linux/kernel/git/thermal/linux.git//d9fef76e89498bf99cdb03f77b7091d7e95d7edd
Author: Julien Panis <jpanis@baylibre.com>
AuthorDate: Thu, 16 May 2024 12:44:37 +02:00
Committer: Daniel Lezcano <daniel.lezcano@linaro.org>
CommitterDate: Tue, 04 Jun 2024 19:40:51 +02:00
thermal/drivers/mediatek/lvts_thermal: Remove filtered mode for mt8188
Filtered mode is not supported on mt8188 SoC and is the source of bad
results. Move to immediate mode which provides good temperatures.
Fixes: f4745f546e60 ("thermal/drivers/mediatek/lvts_thermal: Add MT8188 support")
Reviewed-by: Nicolas Pitre <npitre@baylibre.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Signed-off-by: Julien Panis <jpanis@baylibre.com>
Link: https://lore.kernel.org/r/20240516-mtk-thermal-mt8188-mode-fix-v2-1-40a317442c62@baylibre.com
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
---
drivers/thermal/mediatek/lvts_thermal.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/drivers/thermal/mediatek/lvts_thermal.c b/drivers/thermal/mediatek/lvts_thermal.c
index 0bb3a49..82c355c 100644
--- a/drivers/thermal/mediatek/lvts_thermal.c
+++ b/drivers/thermal/mediatek/lvts_thermal.c
@@ -1458,7 +1458,6 @@ static const struct lvts_ctrl_data mt8188_lvts_mcu_data_ctrl[] = {
},
VALID_SENSOR_MAP(1, 1, 1, 1),
.offset = 0x0,
- .mode = LVTS_MSR_FILTERED_MODE,
},
{
.lvts_sensor = {
@@ -1469,7 +1468,6 @@ static const struct lvts_ctrl_data mt8188_lvts_mcu_data_ctrl[] = {
},
VALID_SENSOR_MAP(1, 1, 0, 0),
.offset = 0x100,
- .mode = LVTS_MSR_FILTERED_MODE,
}
};
@@ -1483,7 +1481,6 @@ static const struct lvts_ctrl_data mt8188_lvts_ap_data_ctrl[] = {
},
VALID_SENSOR_MAP(0, 1, 0, 0),
.offset = 0x0,
- .mode = LVTS_MSR_FILTERED_MODE,
},
{
.lvts_sensor = {
@@ -1496,7 +1493,6 @@ static const struct lvts_ctrl_data mt8188_lvts_ap_data_ctrl[] = {
},
VALID_SENSOR_MAP(1, 1, 1, 0),
.offset = 0x100,
- .mode = LVTS_MSR_FILTERED_MODE,
},
{
.lvts_sensor = {
@@ -1507,7 +1503,6 @@ static const struct lvts_ctrl_data mt8188_lvts_ap_data_ctrl[] = {
},
VALID_SENSOR_MAP(1, 1, 0, 0),
.offset = 0x200,
- .mode = LVTS_MSR_FILTERED_MODE,
},
{
.lvts_sensor = {
@@ -1518,7 +1513,6 @@ static const struct lvts_ctrl_data mt8188_lvts_ap_data_ctrl[] = {
},
VALID_SENSOR_MAP(1, 1, 0, 0),
.offset = 0x300,
- .mode = LVTS_MSR_FILTERED_MODE,
}
};
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-06-12 17:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-05-16 10:44 [PATCH v2] thermal/drivers/mediatek/lvts_thermal: Remove filtered mode for mt8188 Julien Panis
2024-06-04 17:42 ` Daniel Lezcano
2024-06-12 17:12 ` [thermal: thermal/fixes] " thermal-bot for Julien Panis
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).