From: Hans de Goede <hdegoede@redhat.com>
To: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Pavel Machek" <pavel@ucw.cz>, "Lee Jones" <lee@kernel.org>,
"Kate Hsuan" <hpa@redhat.com>,
"Sebastian Reichel" <sre@kernel.org>
Cc: "Hans de Goede" <hdegoede@redhat.com>,
platform-driver-x86@vger.kernel.org,
"André Apitzsch" <git@apitzsch.eu>,
linux-leds@vger.kernel.org, linux-pm@vger.kernel.org
Subject: [PATCH v9 7/7] platform: x86-android-tablets: Xiaomi pad2 RGB LED fwnode updates
Date: Sat, 4 May 2024 18:41:05 +0200 [thread overview]
Message-ID: <20240504164105.114017-8-hdegoede@redhat.com> (raw)
In-Reply-To: <20240504164105.114017-1-hdegoede@redhat.com>
From: Kate Hsuan <hpa@redhat.com>
Xiaomi pad2 RGB LED fwnode updates:
1. Set "label" instead "function" to change the LED classdev name from
"rgb:indicator" to "i2c-ktd2026:rgb:indicator" to match the usual
triplet name format for LED classdevs.
2. Set the trigger to the new "bq27520-0-charging-orange-full-green"
powersupply trigger type for multi-color LEDs.
3. Put the fwnode link for red before green in ktd2026_node_group[] so that
multi_index becomes "red green blue".
Signed-off-by: Kate Hsuan <hpa@redhat.com>
Reviewed-by: Andy Shevchenko <andy@kernel.org>
Co-developed-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
drivers/platform/x86/x86-android-tablets/other.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/platform/x86/x86-android-tablets/other.c b/drivers/platform/x86/x86-android-tablets/other.c
index ce487b3c972c..198ea894d071 100644
--- a/drivers/platform/x86/x86-android-tablets/other.c
+++ b/drivers/platform/x86/x86-android-tablets/other.c
@@ -609,8 +609,8 @@ static const struct software_node ktd2026_node = {
static const struct property_entry ktd2026_rgb_led_props[] = {
PROPERTY_ENTRY_U32("reg", 0),
PROPERTY_ENTRY_U32("color", LED_COLOR_ID_RGB),
- PROPERTY_ENTRY_STRING("function", "indicator"),
- PROPERTY_ENTRY_STRING("linux,default-trigger", "bq27520-0-charging"),
+ PROPERTY_ENTRY_STRING("label", "i2c-ktd2026:rgb:indicator"),
+ PROPERTY_ENTRY_STRING("linux,default-trigger", "bq27520-0-charging-orange-full-green"),
{ }
};
@@ -656,9 +656,9 @@ static const struct software_node ktd2026_red_led_node = {
static const struct software_node *ktd2026_node_group[] = {
&ktd2026_node,
&ktd2026_rgb_led_node,
+ &ktd2026_red_led_node,
&ktd2026_green_led_node,
&ktd2026_blue_led_node,
- &ktd2026_red_led_node,
NULL
};
--
2.44.0
next prev parent reply other threads:[~2024-05-04 16:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-04 16:40 [PATCH v9 0/7] KTD2026 indicator LED for X86 Xiaomi Pad2 Hans de Goede
2024-05-04 16:40 ` [PATCH v9 1/7] leds: rgb: leds-ktd202x: Get device properties through fwnode to support ACPI Hans de Goede
2024-05-04 16:41 ` [PATCH v9 2/7] leds: rgb: leds-ktd202x: I2C ID tables for KTD2026 and 2027 Hans de Goede
2024-05-04 16:41 ` [PATCH v9 3/7] leds: rgb: leds-ktd202x: Initialize mutex earlier Hans de Goede
2024-05-04 16:41 ` [PATCH v9 4/7] leds: core: Add led_mc_set_brightness() function Hans de Goede
2024-05-04 16:41 ` [PATCH v9 5/7] leds: trigger: Add led_mc_trigger_event() function Hans de Goede
2024-05-04 16:41 ` [PATCH v9 6/7] power: supply: power-supply-leds: Add charging_orange_full_green trigger for RGB LED Hans de Goede
2024-05-04 16:41 ` Hans de Goede [this message]
2024-05-31 10:03 ` [PATCH v9 0/7] KTD2026 indicator LED for X86 Xiaomi Pad2 Lee Jones
2024-05-31 12:01 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240504164105.114017-8-hdegoede@redhat.com \
--to=hdegoede@redhat.com \
--cc=andy@kernel.org \
--cc=git@apitzsch.eu \
--cc=hpa@redhat.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=lee@kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=platform-driver-x86@vger.kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).