From: Wayne Chang <waynec@nvidia.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Jon Hunter <jonathanh@nvidia.com>,
"thierry.reding@gmail.com" <thierry.reding@gmail.com>,
JC Kuo <jckuo@nvidia.com>, "vkoul@kernel.org" <vkoul@kernel.org>,
"kishon@kernel.org" <kishon@kernel.org>,
"linux-phy@lists.infradead.org" <linux-phy@lists.infradead.org>,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: Re: [PATCH 2/2] usb: gadget: tegra-xudc: Fix USB3 PHY retrieval logic
Date: Thu, 7 Mar 2024 02:55:42 +0000 [thread overview]
Message-ID: <cc0eef54-28a4-41a8-9768-70c89c1601a9@nvidia.com> (raw)
In-Reply-To: <2024030542-broker-promptly-de99@gregkh>
Hi Greg,
Thanks for the review.
On 3/6/24 06:10, Greg KH wrote:
> External email: Use caution opening links or attachments
>
>
> On Wed, Mar 06, 2024 at 12:11:22AM +0800, Wayne Chang wrote:
>> This commit resolves an issue in the tegra-xudc USB gadget driver that
>> incorrectly fetched USB3 PHY instances. The problem stemmed from the
>> assumption of a one-to-one correspondence between USB2 and USB3 PHY
>> names and their association with physical USB ports in the device tree.
>>
>> Previously, the driver associated USB3 PHY names directly with the USB3
>> instance number, leading to mismatches when mapping the physical USB
>> ports. For instance, if using USB3-1 PHY, the driver expect the
>> corresponding PHY name as 'usb3-1'. However, the physical USB ports in
>> the device tree were designated as USB2-0 and USB3-0 as we only have
>> one device controller, causing a misalignment.
>>
>> This commit rectifies the issue by adjusting the PHY naming logic.
>> Now, the driver correctly correlates the USB2 and USB3 PHY instances,
>> allowing the USB2-0 and USB3-1 PHYs to form a physical USB port pair
>> while accurately reflecting their configuration in the device tree by
>> naming them USB2-0 and USB3-0, respectively.
>>
>> The change ensures that the PHY and PHY names align appropriately,
>> resolving the mismatch between physical USB ports and their associated
>> names in the device tree.
>>
>> Fixes: b4e19931c98a ("usb: gadget: tegra-xudc: Support multiple device modes")
>> Cc: stable@vger.kernel.org
> You mark patch 2/2 for stable, but not patch 1/2? That's not going to
> work well, is it? :(
Yes, sorry about that. I'll update in the next patchset.
> thanks,
>
> greg k-h
>
thanks,
Wayne.
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
prev parent reply other threads:[~2024-03-07 2:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-05 16:11 [PATCH 0/2] Fix incorrect USB3 phy parsing in tegra-xudc Wayne Chang
2024-03-05 16:11 ` [PATCH 1/2] phy: tegra: xusb: Add API to retrieve the port number of phy Wayne Chang
2024-03-05 16:11 ` [PATCH 2/2] usb: gadget: tegra-xudc: Fix USB3 PHY retrieval logic Wayne Chang
2024-03-05 22:10 ` Greg KH
2024-03-07 2:55 ` Wayne Chang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cc0eef54-28a4-41a8-9768-70c89c1601a9@nvidia.com \
--to=waynec@nvidia.com \
--cc=gregkh@linuxfoundation.org \
--cc=jckuo@nvidia.com \
--cc=jonathanh@nvidia.com \
--cc=kishon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=thierry.reding@gmail.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).