Re: [PATCH v2 2/2] Add dp PHY dt-bindings

From: "LIANKUN YANG (杨连坤)" <Liankun.Yang@mediatek.com>
To: "robh@kernel.org" <robh@kernel.org>
Cc: "linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>,
	"linux-mediatek@lists.infradead.org"
	<linux-mediatek@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"Mac Shen (沈俊)" <Mac.Shen@mediatek.com>,
	"Chunfeng Yun (云春峰)" <Chunfeng.Yun@mediatek.com>,
	"chunkuang.hu@kernel.org" <chunkuang.hu@kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"tzimmermann@suse.de" <tzimmermann@suse.de>,
	"mripard@kernel.org" <mripard@kernel.org>,
	"Jitao Shi (石记涛)" <jitao.shi@mediatek.com>,
	"daniel@ffwll.ch" <daniel@ffwll.ch>,
	"p.zabel@pengutronix.de" <p.zabel@pengutronix.de>,
	"maarten.lankhorst@linux.intel.com"
	<maarten.lankhorst@linux.intel.com>,
	"conor+dt@kernel.org" <conor+dt@kernel.org>,
	"kishon@kernel.org" <kishon@kernel.org>,
	"airlied@gmail.com" <airlied@gmail.com>,
	"krzysztof.kozlowski+dt@linaro.org"
	<krzysztof.kozlowski+dt@linaro.org>,
	"vkoul@kernel.org" <vkoul@kernel.org>,
	"matthias.bgg@gmail.com" <matthias.bgg@gmail.com>,
	"linux-phy@lists.infradead.org" <linux-phy@lists.infradead.org>,
	Project_Global_Chrome_Upstream_Group
	<Project_Global_Chrome_Upstream_Group@mediatek.com>,
	"angelogioacchino.delregno@collabora.com"
	<angelogioacchino.delregno@collabora.com>
Subject: Re: [PATCH v2 2/2] Add dp PHY dt-bindings
Date: Mon, 13 May 2024 14:06:09 +0000	[thread overview]
Message-ID: <b40f079823286b55e29c244a061f4afac17b9237.camel@mediatek.com> (raw)
In-Reply-To: <20240510124838.GA3916816-robh@kernel.org>

On Fri, 2024-05-10 at 07:48 -0500, Rob Herring wrote:
>  	 
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
>  On Fri, May 10, 2024 at 07:04:15PM +0800, Liankun Yang wrote:
> > Add dp PHY dt-bindings.
> > 
> > Changeds in v2:
> > - Add dp PHY dt-bindings.
> > https://patchwork.kernel.org/project/linux-mediatek/patch/
> > 20240403040517.3279-1-liankun.yang@mediatek.com/
> > 
> > Signed-off-by: Liankun Yang <liankun.yang@mediatek.com>
> > ---
> >  .../display/mediatek/mediatek.phy-dp.yaml     | 45
> +++++++++++++++++++
> >  1 file changed, 45 insertions(+)
> >  create mode 100644
> Documentation/devicetree/bindings/display/mediatek/mediatek.phy-
> dp.yaml
> > 
> > diff --git
> a/Documentation/devicetree/bindings/display/mediatek/mediatek.phy-
> dp.yaml
> b/Documentation/devicetree/bindings/display/mediatek/mediatek.phy-
> dp.yaml
> 
> git refuses to apply your patch because 'new file mode 100644' is 
> missing. You must have edited the patch or something.
> 
> If it did apply, you'd notice it fails testing.
> 

After checking patch,one warning is new file is 'new file mode 100644'.
I will pay attention to the problem in a later patch.

> > index 000000000000..476bc329363f
> > --- /dev/null
> > +++
> b/Documentation/devicetree/bindings/display/mediatek/mediatek.phy-
> dp.yaml
> > @@ -0,0 +1,45 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: 
> http://devicetree.org/schemas/display/mediatek/mediatek,phy-dp.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: MediaTek Display Port Controller
> > +
> > +maintainers:
> > +  - Mac shen <mac.shen@mediatek.com>
> > +  - Liankun yang <Liankun.yang@mediatek.com>
> > +
> > +description: |
> > +  Special settings need to be configured by MediaTek DP based on
> the actual
> > +  hardware situation. For example, when using a certain brand's
> docking
> > +  station for display projection, garbage may appear. Adjusting
> the specific
> > +  ssc value can resolve this issue.
> > +
> > +properties:
> > +  status: disabled
> > +    description: |
> > +      Since the DP driver has already registered the DP PHY device
> > +      through mtk_dp_register_phy(), so the status is disabled.
> 
> What!? Please show me any other binding that has 'status' in it. Go
> read 
> up on how to write bindings and what goes in them.
> 

Sorry,thank you for your comments.
I immediately learn how to write bindings.

> > +
> > +  dp-ssc-setting:
> > +    - ssc-delta-hbr
> > +    description: Specific values are set based on the actual HW
> situation.
> > +
> > +required:
> > +  - status
> > +  - dp-ssc-setting
> > +
> > +examples:
> > +  - |
> > +    soc {
> > +        #address-cells = <2>;
> > +        #size-cells = <2>;
> > +
> > +        phy-dp@1c600000 {
> > +          status = "disabled";
> > +          dp-ssc-setting {
> > +            ssc-delta-hbr = <0x01fe>;
> > +          }
> > +        };
> > +    };
> > -- 
> > 2.18.0
> > 

Best regards,
Liankun yang
-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy