From: Lorenzo Bianconi <lorenzo@kernel.org>
To: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Cc: linux-phy@lists.infradead.org, vkoul@kernel.org,
kishon@kernel.org, lorenzo.bianconi83@gmail.com,
conor@kernel.org, linux-arm-kernel@lists.infradead.org,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
conor+dt@kernel.org, devicetree@vger.kernel.org, nbd@nbd.name,
john@phrozen.org, dd@embedd.com, catalin.marinas@arm.com,
will@kernel.org, upstream@airoha.com
Subject: Re: [PATCH 1/3] dt-bindings: phy: airoha: Add binding doc for PCIe PHY driver
Date: Mon, 13 May 2024 18:54:51 +0200 [thread overview]
Message-ID: <ZkJF2w0f2L6nOtKP@lore-desk> (raw)
In-Reply-To: <b65a6290-1500-42bc-815c-d88dd52dd8ac@collabora.com>
[-- Attachment #1.1: Type: text/plain, Size: 2490 bytes --]
> Il 12/05/24 17:27, Lorenzo Bianconi ha scritto:
> > Introduce device-tree binding documentation for Airoha EN7581 PCIe PHY
> > driver.
> >
> > Tested-by: Zhengping Zhang <zhengping.zhang@airoha.com>
> > Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
> > ---
> > .../bindings/phy/airoha,pcie-phy.yaml | 55 +++++++++++++++++++
> > 1 file changed, 55 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/phy/airoha,pcie-phy.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/phy/airoha,pcie-phy.yaml b/Documentation/devicetree/bindings/phy/airoha,pcie-phy.yaml
> > new file mode 100644
> > index 000000000000..443d7e717296
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/phy/airoha,pcie-phy.yaml
>
> airoha,en7581-pcie-phy.yaml
ack, I will fix it.
>
> > @@ -0,0 +1,55 @@
> > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/phy/airoha,pcie-phy.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Airoha PCIe PHY
>
> title: Airoha EN7581 PCI-Express PHY
ack, I will fix it.
>
> > +
> > +maintainers:
> > + - Lorenzo Bianconi <lorenzo@kernel.org>
> > +
> > +description: |
> > + The PCIe PHY supports physical layer functionality for PCIe Gen2/Gen3 port.
> > +
> > +properties:
> > + compatible:
> > + const: airoha,en7581-pcie-phy
> > +
> > + reg:
> > + maxItems: 3
> > +
> > + reg-names:
> > + items:
> > + - const: csr_2l
> > + - const: pma0
> > + - const: pma1
> > +
> > + "#phy-cells":
> > + const: 0
> > +
> > +required:
> > + - compatible
> > + - reg
> > + - reg-names
> > + - "#phy-cells"
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > + - |
> > + #include <dt-bindings/phy/phy.h>
> > +
> > + bus {
>
> Shouldn't this realistically be 'soc' instead?
ack, I will fix it.
Regards,
Lorenzo
>
> Cheers,
> Angelo
>
> > + #address-cells = <2>;
> > + #size-cells = <2>;
> > +
> > + phy@11e80000 {
> > + compatible = "airoha,en7581-pcie-phy";
> > + #phy-cells = <0>;
> > + reg = <0x0 0x1fa5a000 0x0 0xfff>,
> > + <0x0 0x1fa5b000 0x0 0xfff>,
> > + <0x0 0x1fa5c000 0x0 0xfff>;
> > + reg-names = "csr_2l", "pma0", "pma1";
> > + };
> > + };
>
>
>
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 112 bytes --]
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
next prev parent reply other threads:[~2024-05-13 16:55 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-12 15:27 [PATCH 0/3] Introduce PCIe PHY driver for EN7581 SoC Lorenzo Bianconi
2024-05-12 15:27 ` [PATCH 1/3] dt-bindings: phy: airoha: Add binding doc for PCIe PHY driver Lorenzo Bianconi
2024-05-13 13:14 ` AngeloGioacchino Del Regno
2024-05-13 16:11 ` Conor Dooley
2024-05-13 16:55 ` Lorenzo Bianconi
2024-05-13 16:54 ` Lorenzo Bianconi [this message]
2024-05-12 15:27 ` [PATCH 2/3] arm64: dts: airoha: Add EN7581 pcie-phy node Lorenzo Bianconi
2024-05-13 13:15 ` AngeloGioacchino Del Regno
2024-05-12 15:27 ` [PATCH 3/3] phy: airoha: Add PCIe PHY driver for EN7581 SoC Lorenzo Bianconi
2024-05-12 16:07 ` Amit Singh Tomar
2024-05-13 16:56 ` Lorenzo Bianconi
2024-05-13 13:18 ` AngeloGioacchino Del Regno
2024-05-13 16:55 ` Lorenzo Bianconi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZkJF2w0f2L6nOtKP@lore-desk \
--to=lorenzo@kernel.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=catalin.marinas@arm.com \
--cc=conor+dt@kernel.org \
--cc=conor@kernel.org \
--cc=dd@embedd.com \
--cc=devicetree@vger.kernel.org \
--cc=john@phrozen.org \
--cc=kishon@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-phy@lists.infradead.org \
--cc=lorenzo.bianconi83@gmail.com \
--cc=nbd@nbd.name \
--cc=robh+dt@kernel.org \
--cc=upstream@airoha.com \
--cc=vkoul@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).