From: Johan Hovold <johan@kernel.org>
To: Stanley Chang <stanley_chang@realtek.com>
Cc: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Vinod Koul" <vkoul@kernel.org>,
"Kishon Vijay Abraham I" <kishon@kernel.org>,
"Geert Uytterhoeven" <geert+renesas@glider.be>,
"Rob Herring" <robh@kernel.org>,
"Jinjie Ruan" <ruanjinjie@huawei.com>,
"Alan Stern" <stern@rowland.harvard.edu>,
"Yang Yingliang" <yangyingliang@huawei.com>,
"Roy Luo" <royluo@google.com>,
"Ricardo Cañuelo" <ricardo.canuelo@collabora.com>,
"Heikki Krogerus" <heikki.krogerus@linux.intel.com>,
"Flavio Suligoi" <f.suligoi@asem.it>,
linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org,
linux-usb@vger.kernel.org
Subject: Re: [PATCH v3 2/4] phy: realtek: usb: add new driver for the Realtek RTD SoC USB 2.0 PHY
Date: Fri, 10 Nov 2023 08:47:41 +0100 [thread overview]
Message-ID: <ZU3gHcugq9FxBG4P@hovoldconsulting.com> (raw)
In-Reply-To: <20231110054738.23515-2-stanley_chang@realtek.com>
On Fri, Nov 10, 2023 at 01:45:13PM +0800, Stanley Chang wrote:
> Realtek DHC (digital home center) RTD SoCs support DWC3 XHCI USB
> controller. Added the driver to drive the USB 2.0 PHY transceivers.
>
> Note: New driver,remove the port status notification on legacy USB PHY.
> Use the generic PHY to notify the usb device connect and disconnect.
> To avoid using these PHYs would require describing the very same
> PHY using both the generic "phy" property and the deprecated "usb-phy"
> property.
>
> Signed-off-by: Stanley Chang <stanley_chang@realtek.com>
> ---
> v1 to v2 change:
> rebase the driver to include the revert part on
> 7a784bcdd7e54f0599da3b2360e472238412623e
> v2 to v3 change:
> remove MODULE_ALIAS
Don't send out a new version of a patch series immediately just to fix
something small like this.
In this case I'd suggest you wait at least until you've gotten feedback
on the new notification implementation.
Johan
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
next parent reply other threads:[~2023-11-10 7:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20231110054738.23515-1-stanley_chang@realtek.com>
[not found] ` <20231110054738.23515-2-stanley_chang@realtek.com>
2023-11-10 7:47 ` Johan Hovold [this message]
2023-11-21 5:47 ` [PATCH v3 1/4] phy: core: add notify_connect and notify_disconnect callback Kishon Vijay Abraham I
[not found] ` <20231110054738.23515-4-stanley_chang@realtek.com>
[not found] ` <4736a6933f3546c48f24a635c15a5e20@realtek.com>
2023-12-07 7:10 ` [PATCH v3 4/4] usb: core: add phy notify connect and disconnect Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZU3gHcugq9FxBG4P@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=f.suligoi@asem.it \
--cc=geert+renesas@glider.be \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=kishon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=ricardo.canuelo@collabora.com \
--cc=robh@kernel.org \
--cc=royluo@google.com \
--cc=ruanjinjie@huawei.com \
--cc=stanley_chang@realtek.com \
--cc=stern@rowland.harvard.edu \
--cc=vkoul@kernel.org \
--cc=yangyingliang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).