From: Johan Jonker <jbx6244@yandex.com>
To: Sebastian Reichel <sebastian.reichel@collabora.com>
Cc: Heiko Stuebner <heiko@sntech.de>, Vinod Koul <vkoul@kernel.org>,
Kishon Vijay Abraham I <kishon@kernel.org>,
linux-rockchip@lists.infradead.org,
linux-phy@lists.infradead.org, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Frank Wang <frank.wang@rock-chips.com>,
Kever Yang <kever.yang@rock-chips.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel@collabora.com
Subject: Re: [PATCH v1 06/10] arm64: dts: rockchip: add USBDP phys on rk3588
Date: Mon, 12 Feb 2024 23:44:37 +0100 [thread overview]
Message-ID: <9f8d39c1-66ca-4bb7-994e-de15cb516473@yandex.com> (raw)
In-Reply-To: <dsfne22iebd7mvyyskhpw3rkkfhlxpv32afht456vq3u52axyr@kgkxfzm5vn4c>
On 2/12/24 19:48, Sebastian Reichel wrote:
> Hi Johan,
>
> On Sun, Feb 11, 2024 at 08:24:36PM +0100, Johan Jonker wrote:
>>> + u2phy1: usb2-phy@4000 {
>>
>> "usb2phy@[0-9a-f]+$":
>
> Interesting. I would have expected that to pop up in dtbs_check, but
> it does not for some reason. I will fix it for all usb2phy instances
> in rk3588.
>
>>> + compatible = "rockchip,rk3588-usb2phy";
>>> + reg = <0x4000 0x10>;
>>> + interrupts = <GIC_SPI 394 IRQ_TYPE_LEVEL_HIGH 0>;
>>
>>> + resets = <&cru SRST_OTGPHY_U3_1>, <&cru SRST_P_USB2PHY_U3_1_GRF0>;
>>> + reset-names = "phy", "apb";
>>> + clocks = <&cru CLK_USB2PHY_HDPTXRXPHY_REF>;
>>> + clock-names = "phyclk";
>>> + clock-output-names = "usb480m_phy1";
>>> + #clock-cells = <0>;
>>
>> Align with the (new) documentation
>> about property ordering.
>>
>>> + status = "disabled";
>>> +
>>> + u2phy1_otg: otg-port {
>>> + #phy-cells = <0>;
>>> + status = "disabled";
>>> + };
>>> + };
>>> + };
>
> The above follows everything from [0], which does not specify an
> order for the "standard/common properties". For those this follows
> the order of existing usb2phy nodes. Did I miss any other new
> Documentation?
>
> [0] https://www.kernel.org/doc/html/next/devicetree/bindings/dts-coding-style.html#order-of-properties-in-device-node
While reading the text below I think it's in need for a clarification that the property order for common and vendor category is alpha-numerical as is for nodes.
For Rockchip DT in this case "reset*" below "clock*", so that the person after you can add properties in a sort list.
Johan
.===
The following order of properties in device nodes is preferred:
"compatible"
"reg"
"ranges"
Standard/common properties (defined by common bindings, e.g. without vendor-prefixes)
Vendor-specific properties
"status" (if applicable)
Child nodes, where each node is preceded with a blank line
The "status" property is by default "okay", thus it can be omitted.
>
> -- Sebastian
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
next prev parent reply other threads:[~2024-02-12 22:45 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-09 18:17 [PATCH v1 00/10] RK3588 USBDP support Sebastian Reichel
2024-02-09 18:17 ` [PATCH v1 01/10] dt-bindings: soc: rockchip: add clock to RK3588 VO grf Sebastian Reichel
2024-02-11 17:27 ` Conor Dooley
2024-02-09 18:17 ` [PATCH v1 02/10] dt-bindings: soc: rockchip: add rk3588 USB3 syscon Sebastian Reichel
2024-02-11 17:37 ` Conor Dooley
2024-02-09 18:17 ` [PATCH v1 03/10] dt-bindings: phy: add rockchip usbdp combo phy document Sebastian Reichel
2024-02-09 22:17 ` Heiko Stübner
2024-02-11 17:36 ` Conor Dooley
2024-02-09 18:17 ` [PATCH v1 04/10] phy: rockchip: add usbdp combo phy driver Sebastian Reichel
2024-02-11 20:45 ` Johan Jonker
2024-02-09 18:17 ` [PATCH v1 05/10] arm64: defconfig: enable Rockchip Samsung USBDP PHY Sebastian Reichel
2024-02-09 18:17 ` [PATCH v1 06/10] arm64: dts: rockchip: add USBDP phys on rk3588 Sebastian Reichel
2024-02-11 19:24 ` Johan Jonker
2024-02-12 18:48 ` Sebastian Reichel
2024-02-12 22:44 ` Johan Jonker [this message]
2024-02-09 18:17 ` [PATCH v1 07/10] arm64: dts: rockchip: add USB3 DRD controllers " Sebastian Reichel
2024-02-09 18:17 ` [PATCH v1 08/10] arm64: dts: rockchip: add USB3 to rk3588-evb1 Sebastian Reichel
2024-02-09 18:17 ` [PATCH v1 09/10] arm64: dts: rockchip: add upper USB3 port to rock-5a Sebastian Reichel
2024-02-09 18:17 ` [PATCH v1 10/10] arm64: dts: rockchip: add lower USB3 port to rock-5b Sebastian Reichel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9f8d39c1-66ca-4bb7-994e-de15cb516473@yandex.com \
--to=jbx6244@yandex.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=frank.wang@rock-chips.com \
--cc=heiko@sntech.de \
--cc=kernel@collabora.com \
--cc=kever.yang@rock-chips.com \
--cc=kishon@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robh+dt@kernel.org \
--cc=sebastian.reichel@collabora.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).