From: Dan Carpenter <dan.carpenter@linaro.org>
To: Vinod Koul <vkoul@kernel.org>
Cc: linux-phy@lists.infradead.org
Subject: [bug report] phy: qcom: Introduce M31 USB PHY driver
Date: Tue, 6 Feb 2024 13:22:42 +0300 [thread overview]
Message-ID: <88e2b874-b82d-4b6f-b1c5-761a8d066020@moroto.mountain> (raw)
The patch 08e49af50701: "phy: qcom: Introduce M31 USB PHY driver"
from Aug 14, 2023 (linux-next), leads to the following Smatch static
checker warning:
drivers/phy/qualcomm/phy-qcom-m31.c:302 m31usb_phy_probe()
warn: passing zero to 'PTR_ERR'
drivers/phy/qualcomm/phy-qcom-m31.c
294
295 qphy->phy = devm_phy_create(dev, NULL, &m31usb_phy_gen_ops);
296 if (IS_ERR(qphy->phy))
297 return dev_err_probe(dev, PTR_ERR(qphy->phy),
298 "failed to create phy\n");
299
300 qphy->vreg = devm_regulator_get(dev, "vdda-phy");
301 if (IS_ERR(qphy->vreg))
--> 302 return dev_err_probe(dev, PTR_ERR(qphy->phy),
^^^
This should have been "qphy->vreg".
303 "failed to get vreg\n");
304
I can't work out what happened here.
This was fixed in commit 5f7cd740a6b6 ("phy: qcom: phy-qcom-m31: fix
wrong pointer pass to PTR_ERR()") but somehow it got changed back. I've
looked at the git log and I don't see how that happened...
regards,
dan carpenter
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
next reply other threads:[~2024-02-06 10:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-06 10:22 Dan Carpenter [this message]
2024-02-07 9:10 ` [bug report] phy: qcom: Introduce M31 USB PHY driver Vinod Koul
-- strict thread matches above, loose matches on Subject: below --
2023-09-06 11:58 Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=88e2b874-b82d-4b6f-b1c5-761a8d066020@moroto.mountain \
--to=dan.carpenter@linaro.org \
--cc=linux-phy@lists.infradead.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).