From: "Chunfeng Yun (云春峰)" <Chunfeng.Yun@mediatek.com>
To: "vkoul@kernel.org" <vkoul@kernel.org>,
"krzysztof.kozlowski@linaro.org" <krzysztof.kozlowski@linaro.org>,
"Macpaul Lin (林智斌)" <Macpaul.Lin@mediatek.com>,
"robh+dt@kernel.org" <robh+dt@kernel.org>
Cc: "Pablo Sun (孫毓翔)" <pablo.sun@mediatek.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-mediatek@lists.infradead.org"
<linux-mediatek@lists.infradead.org>,
"Bear Wang (萩原惟德)" <bear.wang@mediatek.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"conor+dt@kernel.org" <conor+dt@kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"krzysztof.kozlowski+dt@linaro.org"
<krzysztof.kozlowski+dt@linaro.org>,
"matthias.bgg@gmail.com" <matthias.bgg@gmail.com>,
"linux-phy@lists.infradead.org" <linux-phy@lists.infradead.org>,
"angelogioacchino.delregno@collabora.com"
<angelogioacchino.delregno@collabora.com>
Subject: Re: [PATCH 1/2] dt-bindings: phy: mediatek: tphy: add a property for force-mode switch
Date: Sun, 10 Dec 2023 09:09:45 +0000 [thread overview]
Message-ID: <853a37c17a84a50866345481f4fd48ba82aa2b27.camel@mediatek.com> (raw)
In-Reply-To: <50e56220-8068-4e2e-a586-9d0474963085@linaro.org>
On Thu, 2023-11-30 at 09:03 +0100, Krzysztof Kozlowski wrote:
>
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
> On 30/11/2023 02:51, Chunfeng Yun (云春峰) wrote:
> >>> 3. How about we revise the description as follows for more
> >> precisely?
> >>>
> >>> mediatek,force-mode:
> >>> description:
> >>> The force mode is used to manually switch the shared PHY
> mode
> >>> between USB and PCIe. When force-mode is set, the USB 3.0
> mode
> >>> will be selected. This is typically required for older SoCs
> >>> that do not automatically manage PHY mode switching.
> >>> For newer SoCs that support it, it is preferable to use the
> >>> "mediatek,syscon-type" property instead.
> >>> type: boolean
> >>
> >> Again, what is force-mode?
> > Our DE describe this behavior as force-mode, as you see, the driver
>
> What is "DE"?
Hardware designer
>
> > power down controller and reset pipe to set the mode directly we
> want,
>
> So force-mode is driver behavior?
hardware supported, need software to set some registers
>
> > but usually the phy controller switch to the mode automatically
> > according to the external signal, e.g. trapping pin, efuse etc.
> >
> >> It looks like you wrote bindings for the
> >> driver behavior. Bindings describe hardware, not how the driver
> >> should
> >> behave. The property might be reasonable, but you must describe
> here
> >> hardware characteristics/issue/etc.
>
> You must address this, in such case.
OK, I'll modify the description
Thanks
>
>
>
> Best regards,
> Krzysztof
>
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
next prev parent reply other threads:[~2023-12-10 9:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-25 1:23 [PATCH 1/2] dt-bindings: phy: mediatek: tphy: add a property for force-mode switch Chunfeng Yun
2023-11-25 1:23 ` [PATCH 2/2] phy: mediatek: tphy: add support force phy mode switch Chunfeng Yun
2023-11-25 10:37 ` [PATCH 1/2] dt-bindings: phy: mediatek: tphy: add a property for force-mode switch Krzysztof Kozlowski
2023-11-27 7:09 ` Macpaul Lin
2023-11-27 7:21 ` Krzysztof Kozlowski
2023-11-27 13:37 ` AngeloGioacchino Del Regno
2023-11-30 2:00 ` Chunfeng Yun (云春峰)
2023-11-30 1:51 ` Chunfeng Yun (云春峰)
2023-11-30 8:03 ` Krzysztof Kozlowski
2023-12-10 9:09 ` Chunfeng Yun (云春峰) [this message]
2023-11-30 2:28 ` Chunfeng Yun (云春峰)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=853a37c17a84a50866345481f4fd48ba82aa2b27.camel@mediatek.com \
--to=chunfeng.yun@mediatek.com \
--cc=Macpaul.Lin@mediatek.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=bear.wang@mediatek.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-phy@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=pablo.sun@mediatek.com \
--cc=robh+dt@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).