From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
To: Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Lee Jones <lee@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Vinod Koul <vkoul@kernel.org>,
Kishon Vijay Abraham I <kishon@kernel.org>,
Jeffrey Hugo <quic_jhugo@quicinc.com>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-phy@lists.infradead.org,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Subject: [PATCH 0/6] phy: qcom: qmp-usbc: properly handle the clamping register
Date: Tue, 16 Jan 2024 03:08:26 +0200 [thread overview]
Message-ID: <20240116-usbc-phy-vls-clamp-v1-0-73b2da7691c5@linaro.org> (raw)
The USB-C PHY on the MSM8998, QCM2290, SM6115 and several other platforms
doesn't have built-in PCS_MISC_CLAMP_ENABLE register. Instead clamping
is handled separately via the register in the TCSR space. Make the new
phy-qcom-qmp-usbc driver correctly handle the clamp register.
For backwards compatibility the driver treats these registers as
optional. They are only required for the PHY suspend/resume. However the
schema declares corresponding property as required, it should be present
on all relevant platforms.
At this point I'm not sure whether having a single TCSR-based register
will be enough or whether we will have to add more TCSR registers in
future. In order to avoid repeating TCSR handle (and having multiple
instances of TCSR regmap in the driver) use qcom,tcsr-reg property
rather than someting more exact like qcom,vls-clamp-reg.
Dependecies: PHY-related changes of [1]
Note for the backporters: if the patch is packported to the kernel
before the phy-qocm-qmp-usbc split, the phy-qcom-qmp-usb driver needs to
handle both PCS_MISC_CLAMP_ENABLE and VLS_CLAMP registers as optional.
[1] https://lore.kernel.org/linux-arm-msm/20240113-pmi632-typec-v2-0-182d9aa0a5b3@linaro.org/
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
---
Dmitry Baryshkov (6):
dt-bindings: mfd: qcom,tcsr: Add compatibles for QCM2290 and SM6115
dt-bindings: phy: qcom,msm8998-qmp-usb3-phy: add TCSR registers
phy: qcom: qmp-usbc: handle CLAMP register in a correct way
arm64: dts: qcom: msm8998: declare VLS CLAMP register for USB3 PHY
arm64: dts: qcom: qcm2290: declare VLS CLAMP register for USB3 PHY
arm64: dts: qcom: sm6115: declare VLS CLAMP register for USB3 PHY
.../devicetree/bindings/mfd/qcom,tcsr.yaml | 2 +
.../bindings/phy/qcom,msm8998-qmp-usb3-phy.yaml | 11 +++++
arch/arm64/boot/dts/qcom/msm8998.dtsi | 2 +
arch/arm64/boot/dts/qcom/qcm2290.dtsi | 7 ++++
arch/arm64/boot/dts/qcom/sm6115.dtsi | 7 ++++
drivers/phy/qualcomm/phy-qcom-qmp-usbc.c | 48 +++++++++++++++++-----
6 files changed, 66 insertions(+), 11 deletions(-)
---
base-commit: d0f9c0b672a974d32c40d369f63e441a7dd66d74
change-id: 20240116-usbc-phy-vls-clamp-10189efdcf12
Best regards,
--
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
next reply other threads:[~2024-01-16 1:08 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-16 1:08 Dmitry Baryshkov [this message]
2024-01-16 1:08 ` [PATCH 1/6] dt-bindings: mfd: qcom,tcsr: Add compatibles for QCM2290 and SM6115 Dmitry Baryshkov
2024-01-16 8:11 ` Krzysztof Kozlowski
2024-01-25 13:32 ` (subset) " Lee Jones
2024-01-16 1:08 ` [PATCH 2/6] dt-bindings: phy: qcom,msm8998-qmp-usb3-phy: add TCSR registers Dmitry Baryshkov
2024-01-16 8:13 ` Krzysztof Kozlowski
2024-01-16 1:08 ` [PATCH 3/6] phy: qcom: qmp-usbc: handle CLAMP register in a correct way Dmitry Baryshkov
2024-01-16 11:59 ` Konrad Dybcio
2024-01-16 1:08 ` [PATCH 4/6] arm64: dts: qcom: msm8998: declare VLS CLAMP register for USB3 PHY Dmitry Baryshkov
2024-01-16 11:59 ` Konrad Dybcio
2024-01-16 1:08 ` [PATCH 5/6] arm64: dts: qcom: qcm2290: " Dmitry Baryshkov
2024-01-16 12:00 ` Konrad Dybcio
2024-01-16 1:08 ` [PATCH 6/6] arm64: dts: qcom: sm6115: " Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240116-usbc-phy-vls-clamp-v1-0-73b2da7691c5@linaro.org \
--to=dmitry.baryshkov@linaro.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kishon@kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lee@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=quic_jhugo@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).