From: Vinod Koul <vkoul@kernel.org>
To: "Kishon Vijay Abraham I" <kishon@kernel.org>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Lucas Stach <l.stach@pengutronix.de>,
Adam Ford <aford173@gmail.com>,
Marco Felsch <m.felsch@pengutronix.de>,
kernel@pengutronix.de, linux-phy@lists.infradead.org
Subject: Re: [PATCH] phy: freescale: fsl-samsung-hdmi: Convert to platform remove callback returning void
Date: Fri, 12 Apr 2024 17:06:06 +0530 [thread overview]
Message-ID: <171292176673.599803.15644867894293201983.b4-ty@kernel.org> (raw)
In-Reply-To: <20240409161505.66619-2-u.kleine-koenig@pengutronix.de>
On Tue, 09 Apr 2024 18:15:06 +0200, Uwe Kleine-König wrote:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is ignored (apart
> from emitting a warning) and this typically results in resource leaks.
>
> To improve here there is a quest to make the remove callback return
> void. In the first step of this quest all drivers are converted to
> .remove_new(), which already returns void. Eventually after all drivers
> are converted, .remove_new() will be renamed to .remove().
>
> [...]
Applied, thanks!
[1/1] phy: freescale: fsl-samsung-hdmi: Convert to platform remove callback returning void
commit: c49de54c6224103ab9c4b98464b03ab82721839a
Best regards,
--
~Vinod
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
prev parent reply other threads:[~2024-04-12 11:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-09 16:15 [PATCH] phy: freescale: fsl-samsung-hdmi: Convert to platform remove callback returning void Uwe Kleine-König
2024-04-12 11:36 ` Vinod Koul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=171292176673.599803.15644867894293201983.b4-ty@kernel.org \
--to=vkoul@kernel.org \
--cc=aford173@gmail.com \
--cc=kernel@pengutronix.de \
--cc=kishon@kernel.org \
--cc=l.stach@pengutronix.de \
--cc=linux-phy@lists.infradead.org \
--cc=m.felsch@pengutronix.de \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).