From: Adrian Hunter <adrian.hunter@intel.com>
To: Ian Rogers <irogers@google.com>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>,
Andi Kleen <ak@linux.intel.com>,
linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org
Subject: Re: [PATCH V2] perf scripts python: Add a script to run instances of perf script in parallel
Date: Tue, 23 Apr 2024 16:40:20 +0300 [thread overview]
Message-ID: <e082dabe-5d1c-4be0-baaa-5be30cff0016@intel.com> (raw)
In-Reply-To: <CAP-5=fW1bH8qQkD7LrO6_3fJ3NsqoW1GrX8=s-sfaTbrvk58+A@mail.gmail.com>
On 11/04/24 21:19, Ian Rogers wrote:
> On Wed, Mar 13, 2024 at 5:36 AM Adrian Hunter <adrian.hunter@intel.com> wrote:
>>
>> Add a Python script to run a perf script command multiple times in
>> parallel, using perf script options --cpu and --time so that each job
>> processes a different chunk of the data.
>>
>> The script supports the use of normal perf script options like
>> --dlfilter and --script, so that the benefit of running parallel jobs
>> naturally extends to them also. In addition, a command can be provided
>> (refer --pipe-to option) to pipe standard output to a custom command.
>>
>> Refer to the script's own help text at the end of the patch for more
>> details.
>>
>> The script is useful for Intel PT traces, that can be efficiently
>> decoded by perf script when split by CPU and/or time ranges. Running
>> jobs in parallel can decrease the overall decoding time.
>>
>> Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
>> +
>> + def __init__(self, cmd, pipe_to, output_dir="."):
>> + self.popen = None
>> + self.consumer = None
>> + self.cmd = cmd
>> + self.pipe_to = pipe_to
>> + self.output_dir = output_dir
>> + self.cmdout_name = output_dir + "/cmd.txt"
>> + self.stdout_name = output_dir + "/out.txt"
>> + self.stderr_name = output_dir + "/err.txt"
>
> Why use files here and not pipes?
There is an option to pipe to another command.
> Could using files cause the command
> to fail on a read-only file system?
The user chooses the output directory, so they will need the foresight
not to choose a read-only file system.
prev parent reply other threads:[~2024-04-23 13:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-13 12:36 [PATCH V2] perf scripts python: Add a script to run instances of perf script in parallel Adrian Hunter
2024-04-11 12:04 ` Adrian Hunter
2024-04-11 18:19 ` Ian Rogers
2024-04-12 6:07 ` Adrian Hunter
2024-04-23 13:40 ` Adrian Hunter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e082dabe-5d1c-4be0-baaa-5be30cff0016@intel.com \
--to=adrian.hunter@intel.com \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).