From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: James Clark <james.clark@arm.com>
Cc: Ian Rogers <irogers@google.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Namhyung Kim <namhyung@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>,
Adrian Hunter <adrian.hunter@intel.com>,
Kan Liang <kan.liang@linux.intel.com>,
Ravi Bangoria <ravi.bangoria@amd.com>,
Kajol Jain <kjain@linux.ibm.com>,
Athira Rajeev <atrajeev@linux.vnet.ibm.com>,
Oliver Upton <oliver.upton@linux.dev>,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 0/4] Add shellcheck beyond perf/tests
Date: Fri, 12 Apr 2024 16:38:55 -0300 [thread overview]
Message-ID: <ZhmNz00T1iAzuMiq@x1> (raw)
In-Reply-To: <4949d61b-6b25-4433-bd2b-a50b4f22ff42@arm.com>
On Tue, Apr 09, 2024 at 11:02:58AM +0100, James Clark wrote:
>
>
> On 09/04/2024 03:32, Ian Rogers wrote:
> > Add shellcheck to other locations of shell scripts, not just
> > tools/perf/tests. Fix issues detected by shellcheck.
> >
> > Ian Rogers (4):
> > perf build: Add shellcheck to tools/perf scripts
> > perf arch x86: Add shellcheck to build
> > perf util: Add shellcheck to generate-cmdlist.sh
> > perf trace beauty: Add shellcheck to scripts
> >
> > tools/perf/Build | 14 +++++++++++
> > tools/perf/arch/x86/Build | 14 +++++++++++
> > tools/perf/arch/x86/tests/Build | 14 +++++++++++
> > tools/perf/arch/x86/tests/gen-insn-x86-dat.sh | 2 +-
> > tools/perf/perf-archive.sh | 2 +-
> > tools/perf/perf-completion.sh | 23 +++++++++++++------
> > tools/perf/trace/beauty/Build | 14 +++++++++++
> > tools/perf/trace/beauty/arch_errno_names.sh | 8 ++++---
> > tools/perf/util/Build | 14 +++++++++++
> > 9 files changed, 93 insertions(+), 12 deletions(-)
> >
>
> Reviewed-by: James Clark <james.clark@arm.com>
Thanks, applied to perf-tools-next.
- Arnaldo
prev parent reply other threads:[~2024-04-12 19:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-09 2:32 [PATCH v1 0/4] Add shellcheck beyond perf/tests Ian Rogers
2024-04-09 2:32 ` [PATCH v1 1/4] perf build: Add shellcheck to tools/perf scripts Ian Rogers
2024-04-09 2:32 ` [PATCH v1 2/4] perf arch x86: Add shellcheck to build Ian Rogers
2024-04-09 2:32 ` [PATCH v1 3/4] perf util: Add shellcheck to generate-cmdlist.sh Ian Rogers
2024-04-09 2:32 ` [PATCH v1 4/4] perf trace beauty: Add shellcheck to scripts Ian Rogers
2024-04-09 10:02 ` [PATCH v1 0/4] Add shellcheck beyond perf/tests James Clark
2024-04-12 19:38 ` Arnaldo Carvalho de Melo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZhmNz00T1iAzuMiq@x1 \
--to=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=atrajeev@linux.vnet.ibm.com \
--cc=irogers@google.com \
--cc=james.clark@arm.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=kjain@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=oliver.upton@linux.dev \
--cc=peterz@infradead.org \
--cc=ravi.bangoria@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).