From: "Wang, Weilin" <weilin.wang@intel.com>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Ian Rogers <irogers@google.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>,
"Hunter, Adrian" <adrian.hunter@intel.com>,
Kan Liang <kan.liang@linux.intel.com>,
"linux-perf-users@vger.kernel.org"
<linux-perf-users@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Taylor, Perry" <perry.taylor@intel.com>,
"Alt, Samantha" <samantha.alt@intel.com>,
"Biggers, Caleb" <caleb.biggers@intel.com>
Subject: RE: [RFC PATCH v7 0/6] TPEBS counting mode support
Date: Tue, 23 Apr 2024 16:58:16 +0000 [thread overview]
Message-ID: <CO6PR11MB56354787D828B28C5824E4AFEE112@CO6PR11MB5635.namprd11.prod.outlook.com> (raw)
In-Reply-To: <CAM9d7cj2EbxWVLHU3XPf_F2OzWRVRfSV2TghNA+h8noDztrasQ@mail.gmail.com>
> -----Original Message-----
> From: Namhyung Kim <namhyung@kernel.org>
> Sent: Monday, April 22, 2024 12:10 PM
> To: Wang, Weilin <weilin.wang@intel.com>
> Cc: Ian Rogers <irogers@google.com>; Arnaldo Carvalho de Melo
> <acme@kernel.org>; Peter Zijlstra <peterz@infradead.org>; Ingo Molnar
> <mingo@redhat.com>; Alexander Shishkin
> <alexander.shishkin@linux.intel.com>; Jiri Olsa <jolsa@kernel.org>; Hunter,
> Adrian <adrian.hunter@intel.com>; Kan Liang <kan.liang@linux.intel.com>;
> linux-perf-users@vger.kernel.org; linux-kernel@vger.kernel.org; Taylor, Perry
> <perry.taylor@intel.com>; Alt, Samantha <samantha.alt@intel.com>; Biggers,
> Caleb <caleb.biggers@intel.com>
> Subject: Re: [RFC PATCH v7 0/6] TPEBS counting mode support
>
> Hello Weilin,
>
> On Tue, Apr 2, 2024 at 2:45 PM <weilin.wang@intel.com> wrote:
> >
> > From: Weilin Wang <weilin.wang@intel.com>
> >
> > Changes in v7:
> > - Update code and comments for better code quality [Namhyung]
> > - Add a separate commit for perf data [Namhyung]
> > - Update retire latency print function to improve alignment [Namhyung]
> >
> > v6: https://lore.kernel.org/all/20240329191224.1046866-1-
> weilin.wang@intel.com/
>
> In general, I think you need to explain what exactly TPEBS is and why
> you want to do this for TPEBS. Maybe somewhere in the documentation.
>
Hi Namhyung,
Ok, I will work on this. I had explanations in about TPEBS in the first version of
the code patch. I will add that in a more propriate place.
Thanks,
Weilin
> Thanks,
> Namhyung
>
> >
> > Weilin Wang (6):
> > perf stat: Parse and find tpebs events when parsing metrics to prepare
> > for perf record sampling
> > perf data: Allow to use given fd in data->file.fd
> > perf stat: Fork and launch perf record when perf stat needs to get
> > retire latency value for a metric.
> > perf stat: Add retire latency values into the expr_parse_ctx to
> > prepare for final metric calculation
> > perf stat: Add retire latency print functions to print out at the very
> > end of print out
> > perf vendor events intel: Add MTL metric json files
> >
> > tools/perf/builtin-stat.c | 249 +-
> > .../arch/x86/meteorlake/metricgroups.json | 127 +
> > .../arch/x86/meteorlake/mtl-metrics.json | 2551 +++++++++++++++++
> > tools/perf/util/data.c | 7 +-
> > tools/perf/util/metricgroup.c | 87 +-
> > tools/perf/util/metricgroup.h | 22 +-
> > tools/perf/util/stat-display.c | 69 +
> > tools/perf/util/stat-shadow.c | 19 +
> > tools/perf/util/stat.h | 4 +
> > 9 files changed, 3115 insertions(+), 20 deletions(-)
> > create mode 100644 tools/perf/pmu-
> events/arch/x86/meteorlake/metricgroups.json
> > create mode 100644 tools/perf/pmu-events/arch/x86/meteorlake/mtl-
> metrics.json
> >
> > --
> > 2.43.0
> >
> >
prev parent reply other threads:[~2024-04-23 16:58 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-02 21:44 [RFC PATCH v7 0/6] TPEBS counting mode support weilin.wang
2024-04-02 21:44 ` [RFC PATCH v7 1/6] perf stat: Parse and find tpebs events when parsing metrics to prepare for perf record sampling weilin.wang
2024-04-22 19:13 ` Namhyung Kim
2024-04-02 21:44 ` [RFC PATCH v7 2/6] perf data: Allow to use given fd in data->file.fd weilin.wang
2024-04-02 21:44 ` [RFC PATCH v7 3/6] perf stat: Fork and launch perf record when perf stat needs to get retire latency value for a metric weilin.wang
2024-04-22 19:45 ` Namhyung Kim
2024-04-02 21:44 ` [RFC PATCH v7 4/6] perf stat: Add retire latency values into the expr_parse_ctx to prepare for final metric calculation weilin.wang
2024-04-02 21:44 ` [RFC PATCH v7 5/6] perf stat: Add retire latency print functions to print out at the very end of print out weilin.wang
2024-04-22 19:55 ` Namhyung Kim
2024-04-22 20:02 ` Namhyung Kim
2024-04-02 21:44 ` [RFC PATCH v7 6/6] perf vendor events intel: Add MTL metric json files weilin.wang
2024-04-22 19:10 ` [RFC PATCH v7 0/6] TPEBS counting mode support Namhyung Kim
2024-04-23 16:58 ` Wang, Weilin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CO6PR11MB56354787D828B28C5824E4AFEE112@CO6PR11MB5635.namprd11.prod.outlook.com \
--to=weilin.wang@intel.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=caleb.biggers@intel.com \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=perry.taylor@intel.com \
--cc=peterz@infradead.org \
--cc=samantha.alt@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).