From: Ian Rogers <irogers@google.com>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>,
Adrian Hunter <adrian.hunter@intel.com>,
Kan Liang <kan.liang@linux.intel.com>,
James Clark <james.clark@arm.com>,
Athira Rajeev <atrajeev@linux.vnet.ibm.com>,
Colin Ian King <colin.i.king@gmail.com>,
Leo Yan <leo.yan@linux.dev>, Song Liu <song@kernel.org>,
Ilkka Koskinen <ilkka@os.amperecomputing.com>,
Ben Gainey <ben.gainey@arm.com>,
K Prateek Nayak <kprateek.nayak@amd.com>,
Yanteng Si <siyanteng@loongson.cn>,
Yicong Yang <yangyicong@hisilicon.com>,
Sun Haiyong <sunhaiyong@loongson.cn>,
Ravi Bangoria <ravi.bangoria@amd.com>,
Anne Macedo <retpolanne@posteo.net>,
Changbin Du <changbin.du@huawei.com>,
Andi Kleen <ak@linux.intel.com>,
Thomas Richter <tmricht@linux.ibm.com>,
Masami Hiramatsu <mhiramat@kernel.org>,
zhaimingbing <zhaimingbing@cmss.chinamobile.com>,
Li Dong <lidong@vivo.com>, Paran Lee <p4ranlee@gmail.com>,
elfring@users.sourceforge.net,
Markus Elfring <Markus.Elfring@web.de>,
Yang Jihong <yangjihong1@huawei.com>,
Chengen Du <chengen.du@canonical.com>,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
bpf@vger.kernel.org
Subject: Re: [PATCH v3 00/12] dso/dsos memory savings and clean up
Date: Mon, 22 Apr 2024 13:59:27 -0700 [thread overview]
Message-ID: <CAP-5=fXwkrPuWBTedUxjc=2GyDwPsTA75RAyN+nj4iHSFozRwg@mail.gmail.com> (raw)
In-Reply-To: <ZibOs-_ASLcZrnFa@x1>
On Mon, Apr 22, 2024 at 1:55 PM Arnaldo Carvalho de Melo
<acme@kernel.org> wrote:
>
> On Mon, Apr 22, 2024 at 01:06:46PM -0700, Namhyung Kim wrote:
> > On Thu, Apr 11, 2024 at 11:42 AM Arnaldo Carvalho de Melo
> > <acme@kernel.org> wrote:
> > >
> > > On Tue, Apr 09, 2024 at 11:42:02PM -0700, Ian Rogers wrote:
> > > > 12 more patches from:
> > > > https://lore.kernel.org/lkml/20240202061532.1939474-1-irogers@google.com/
> > > > a near half year old adventure in trying to lower perf's dynamic
> > > > memory use. Bits like the memory overhead of opendir are on the
> > > > sidelines for now, too much fighting over how
> > > > distributions/C-libraries present getdents. These changes are more
> > > > good old fashioned replace an rb-tree with a sorted array and add
> > > > reference count tracking.
> > > >
> > > > The changes migrate dsos code, the collection of dso structs, more
> > > > into the dsos.c/dsos.h files. As with maps and threads, this is done
> > > > so the internals can be changed - replacing a linked list (for fast
> > > > iteration) and an rb-tree (for fast finds) with a lazily sorted
> > > > array. The complexity of operations remain roughly the same, although
> > > > iterating an array is likely faster than iterating a linked list, the
> > > > memory usage is at least reduce by half.
> > >
> > > Got the first 5 patches, would be nice if more people could review it,
> > > I'll try and get back to is soon.
> >
> > For the series:
> >
> > Acked-by: Namhyung Kim <namhyung@kernel.org>
>
> It is not applying right now, I've just merged with torvalds/master and
> I'm running build tests now, will push to tmp.perf-tools-next right now.
Ok, do you want me to rebase on tmp.perf-tools-next?
Thanks,
Ian
> - Arnaldo
prev parent reply other threads:[~2024-04-22 20:59 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-10 6:42 [PATCH v3 00/12] dso/dsos memory savings and clean up Ian Rogers
2024-04-10 6:42 ` [PATCH v3 01/12] perf dsos: Attempt to better abstract dsos internals Ian Rogers
2024-04-10 6:42 ` [PATCH v3 02/12] perf dsos: Tidy reference counting and locking Ian Rogers
2024-04-10 6:42 ` [PATCH v3 03/12] perf dsos: Add dsos__for_each_dso Ian Rogers
2024-04-10 6:42 ` [PATCH v3 04/12] perf dso: Move dso functions out of dsos Ian Rogers
2024-04-10 6:42 ` [PATCH v3 05/12] perf dsos: Switch more loops to dsos__for_each_dso Ian Rogers
2024-04-10 6:42 ` [PATCH v3 06/12] perf dsos: Switch backing storage to array from rbtree/list Ian Rogers
2024-04-10 6:42 ` [PATCH v3 07/12] perf dsos: Remove __dsos__addnew Ian Rogers
2024-04-10 6:42 ` [PATCH v3 08/12] perf dsos: Remove __dsos__findnew_link_by_longname_id Ian Rogers
2024-04-10 6:42 ` [PATCH v3 09/12] perf dsos: Switch hand code to bsearch Ian Rogers
2024-04-10 6:42 ` [PATCH v3 10/12] perf dso: Add reference count checking and accessor functions Ian Rogers
2024-04-10 6:42 ` [PATCH v3 11/12] perf dso: Reference counting related fixes Ian Rogers
2024-04-14 11:43 ` Markus Elfring
2024-04-10 6:42 ` [PATCH v3 12/12] perf dso: Use container_of to avoid a pointer in dso_data Ian Rogers
2024-04-11 18:42 ` [PATCH v3 00/12] dso/dsos memory savings and clean up Arnaldo Carvalho de Melo
2024-04-22 20:06 ` Namhyung Kim
2024-04-22 20:55 ` Arnaldo Carvalho de Melo
2024-04-22 20:59 ` Ian Rogers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAP-5=fXwkrPuWBTedUxjc=2GyDwPsTA75RAyN+nj4iHSFozRwg@mail.gmail.com' \
--to=irogers@google.com \
--cc=Markus.Elfring@web.de \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=atrajeev@linux.vnet.ibm.com \
--cc=ben.gainey@arm.com \
--cc=bpf@vger.kernel.org \
--cc=changbin.du@huawei.com \
--cc=chengen.du@canonical.com \
--cc=colin.i.king@gmail.com \
--cc=elfring@users.sourceforge.net \
--cc=ilkka@os.amperecomputing.com \
--cc=james.clark@arm.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=kprateek.nayak@amd.com \
--cc=leo.yan@linux.dev \
--cc=lidong@vivo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mhiramat@kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=p4ranlee@gmail.com \
--cc=peterz@infradead.org \
--cc=ravi.bangoria@amd.com \
--cc=retpolanne@posteo.net \
--cc=siyanteng@loongson.cn \
--cc=song@kernel.org \
--cc=sunhaiyong@loongson.cn \
--cc=tmricht@linux.ibm.com \
--cc=yangjihong1@huawei.com \
--cc=yangyicong@hisilicon.com \
--cc=zhaimingbing@cmss.chinamobile.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).