From: Ian Rogers <irogers@google.com>
To: "Liang, Kan" <kan.liang@linux.intel.com>
Cc: Thomas Richter <tmricht@linux.ibm.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>,
Bjorn Helgaas <bhelgaas@google.com>,
Jonathan Corbet <corbet@lwn.net>,
Randy Dunlap <rdunlap@infradead.org>,
Jing Zhang <renyu.zj@linux.alibaba.com>,
James Clark <james.clark@arm.com>,
Ravi Bangoria <ravi.bangoria@amd.com>,
linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org
Subject: Re: [PATCH v4 0/6] Assume sysfs event names are always the same case
Date: Thu, 2 May 2024 11:19:24 -0700 [thread overview]
Message-ID: <CAP-5=fX9k91KRiXK18LHKoqTgwYvU3PB1qtfUWuMoPY4Xfffrw@mail.gmail.com> (raw)
In-Reply-To: <78a63434-c7b8-4ada-b59f-b6dd547b5b63@linux.intel.com>
On Thu, May 2, 2024 at 11:15 AM Liang, Kan <kan.liang@linux.intel.com> wrote:
>
>
>
> On 2024-05-02 12:01 a.m., Ian Rogers wrote:
> > By assuming sysfs events are either upper or lower case, the case
> > insensitive event parsing can probe for the existence of files rather
> > then loading all events in a directory. When the event is a json event
> > like inst_retired.any on Intel, this reduces the number of openat
> > calls on a Tigerlake laptop from 325 down to 255.
> >
> > v1 sent as an RFC:
> > https://lore.kernel.org/lkml/20240413040812.4042051-1-irogers@google.com/
> >
> > v2: addresses review feedback from Kan Liang, by updating
> > documentation and adding tests.
> >
> > v3: incorporate feedback from Thomas Richter <tmricht@linux.ibm.com>
> > that s390 event names are all upper case. Do a lower case probe
> > then an upper case probe, make documentation and tests also agree.
> >
> > v4: add checks to write (kernel test robot) and fix a typo.
> >
> > Ian Rogers (6):
> > perf test pmu-events: Make it clearer that pmu-events tests json
> > events
> > perf Document: Sysfs event names must be lower or upper case
> > perf test pmu: Refactor format test and exposed test APIs
> > perf test pmu: Add an eagerly loaded event test
> > perf test pmu: Test all sysfs PMU event names are the same case
> > perf pmu: Assume sysfs events are always the same case
> >
> > .../sysfs-bus-event_source-devices-events | 6 +
> > tools/perf/tests/pmu-events.c | 2 +-
> > tools/perf/tests/pmu.c | 468 ++++++++++++------
> > tools/perf/util/parse-events.c | 2 +-
> > tools/perf/util/parse-events.h | 2 +-
> > tools/perf/util/pmu.c | 111 +++--
> > tools/perf/util/pmu.h | 4 +-
> > tools/perf/util/pmus.c | 16 +-
> > tools/perf/util/pmus.h | 2 +
> > 9 files changed, 416 insertions(+), 197 deletions(-)
> >
>
> Except the warning for the uninitialized 'ret', the rest looks good to me.
Thanks Kan, I'll hunt that down to fix in v5 and add your reviewed-by.
Would be awesome to get Thomas or someone else's s390 thumbs up. The
differences between v3 to v5 should be very minor, so I'd accept a
check on any of them :-)
Ian
> Reviewed-by: Kan Liang <kan.liang@linux.intel.com>
>
> Thanks,
> Kan
prev parent reply other threads:[~2024-05-02 18:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-02 4:01 [PATCH v4 0/6] Assume sysfs event names are always the same case Ian Rogers
2024-05-02 4:01 ` [PATCH v4 1/6] perf test pmu-events: Make it clearer that pmu-events tests json events Ian Rogers
2024-05-02 4:01 ` [PATCH v4 2/6] perf Document: Sysfs event names must be lower or upper case Ian Rogers
2024-05-02 4:01 ` [PATCH v4 3/6] perf test pmu: Refactor format test and exposed test APIs Ian Rogers
2024-05-02 4:01 ` [PATCH v4 4/6] perf test pmu: Add an eagerly loaded event test Ian Rogers
2024-05-02 17:57 ` Liang, Kan
2024-05-02 4:01 ` [PATCH v4 5/6] perf test pmu: Test all sysfs PMU event names are the same case Ian Rogers
2024-05-02 4:01 ` [PATCH v4 6/6] perf pmu: Assume sysfs events are always " Ian Rogers
2024-05-02 18:15 ` [PATCH v4 0/6] Assume sysfs event names " Liang, Kan
2024-05-02 18:19 ` Ian Rogers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAP-5=fX9k91KRiXK18LHKoqTgwYvU3PB1qtfUWuMoPY4Xfffrw@mail.gmail.com' \
--to=irogers@google.com \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=bhelgaas@google.com \
--cc=corbet@lwn.net \
--cc=james.clark@arm.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=ravi.bangoria@amd.com \
--cc=rdunlap@infradead.org \
--cc=renyu.zj@linux.alibaba.com \
--cc=tmricht@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).