From: Ian Rogers <irogers@google.com>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: linux-kernel@vger.kernel.org,
Kan Liang <kan.liang@linux.intel.com>,
Arnaldo Carvalho de Melo <acme@redhat.com>,
linux-perf-users@vger.kernel.org
Subject: Re: [PATCH] perf Documentation: clarify sysfs event names characters
Date: Mon, 13 May 2024 17:44:41 -0700 [thread overview]
Message-ID: <CAP-5=fX020He2fdmm-tzFY383tSaaOB4q6OBzEtFHgXOW+S00w@mail.gmail.com> (raw)
In-Reply-To: <20240513192439.18473-1-rdunlap@infradead.org>
On Mon, May 13, 2024 at 12:24 PM Randy Dunlap <rdunlap@infradead.org> wrote:
>
> Specify that perf event names in sysfs must not contain mixed lower and
> upper case characters and that they may contain numbers, ".", "_",
> or "-" as well.
>
> Fixes: 785623ee855e ("perf Document: Sysfs event names must be lower or upper case")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Kan Liang <kan.liang@linux.intel.com>
> Cc: Ian Rogers <irogers@google.com>
> Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
> Cc: linux-perf-users@vger.kernel.org
Reviewed-by: Ian Rogers <irogers@google.com>
Looks good to me! Thanks,
Ian
> ---
> Documentation/ABI/testing/sysfs-bus-event_source-devices-events | 10 ++++++----
> 1 file changed, 6 insertions(+), 4 deletions(-)
>
> diff -- a/Documentation/ABI/testing/sysfs-bus-event_source-devices-events b/Documentation/ABI/testing/sysfs-bus-event_source-devices-events
> --- a/Documentation/ABI/testing/sysfs-bus-event_source-devices-events
> +++ b/Documentation/ABI/testing/sysfs-bus-event_source-devices-events
> @@ -37,11 +37,13 @@ Description: Per-pmu performance monitor
> performance monitoring event supported by the <pmu>. The name
> of the file is the name of the event.
>
> - As performance monitoring event names are case
> - insensitive in the perf tool, the perf tool only looks
> - for lower or upper case event names in sysfs to avoid
> + As performance monitoring event names are case insensitive
> + in the perf tool, the perf tool only looks for all lower
> + case or all upper case event names in sysfs to avoid
> scanning the directory. It is therefore required the
> - name of the event here is either lower or upper case.
> + name of the event here is either completely lower or upper
> + case, with no mixed-case characters. Numbers, '.', '_', and
> + '-' are also allowed.
>
> File contents:
>
prev parent reply other threads:[~2024-05-14 0:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-13 19:24 [PATCH] perf Documentation: clarify sysfs event names characters Randy Dunlap
2024-05-14 0:44 ` Ian Rogers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAP-5=fX020He2fdmm-tzFY383tSaaOB4q6OBzEtFHgXOW+S00w@mail.gmail.com' \
--to=irogers@google.com \
--cc=acme@redhat.com \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).