From: Ian Rogers <irogers@google.com>
To: arnaldo.melo@gmail.com
Cc: Yang Jihong <yangjihong1@huawei.com>,
Adrian Hunter <adrian.hunter@intel.com>,
Jiri Olsa <jolsa@kernel.org>,
Kan Liang <kan.liang@linux.intel.com>,
Namhyung Kim <namhyung@kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-perf-users@vger.kernel.org
Subject: Re: [PATCH 1/1] perf kwork: Use zfree() to avoid possibly accessing dangling pointers
Date: Wed, 8 May 2024 16:40:40 -0700 [thread overview]
Message-ID: <CAP-5=fV3T6G29Hrg3fGRnenjxUMjVfPK-zFGQgp9UgJn1JBA9g@mail.gmail.com> (raw)
In-Reply-To: <Zjmc5EiN6zmWZj4r@x1>
On Mon, May 6, 2024 at 8:15 PM <arnaldo.melo@gmail.com> wrote:
>
> When freeing a->b it is good practice to set a->b to NULL using
> zfree(&a->b) so that when we have a bug where a reference to a freed 'a'
> pointer is kept somewhere, we can more quickly cause a segfault if some
> code tries to use a->b.
>
> Convert one such case in the 'perf kwork' codebase.
>
> Cc: Adrian Hunter <adrian.hunter@intel.com>
> Cc: Ian Rogers <irogers@google.com>
> Cc: Jiri Olsa <jolsa@kernel.org>
> Cc: Kan Liang <kan.liang@linux.intel.com>
> Cc: Namhyung Kim <namhyung@kernel.org>
> Cc: Yang Jihong <yangjihong1@huawei.com>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Reviewed-by: Ian Rogers <irogers@google.com>
Thanks,
Ian
> ---
> tools/perf/builtin-kwork.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/builtin-kwork.c b/tools/perf/builtin-kwork.c
> index 0092b9b39611d7e9..56e3f3a5e03a2d66 100644
> --- a/tools/perf/builtin-kwork.c
> +++ b/tools/perf/builtin-kwork.c
> @@ -2230,7 +2230,7 @@ static int perf_kwork__top(struct perf_kwork *kwork)
> perf_kwork__top_report(kwork);
>
> out:
> - free(kwork->top_stat.cpus_runtime);
> + zfree(&kwork->top_stat.cpus_runtime);
> return ret;
> }
>
> --
> 2.44.0
>
prev parent reply other threads:[~2024-05-08 23:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-07 3:15 [PATCH 1/1] perf kwork: Use zfree() to avoid possibly accessing dangling pointers arnaldo.melo
2024-05-08 23:40 ` Ian Rogers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAP-5=fV3T6G29Hrg3fGRnenjxUMjVfPK-zFGQgp9UgJn1JBA9g@mail.gmail.com' \
--to=irogers@google.com \
--cc=adrian.hunter@intel.com \
--cc=arnaldo.melo@gmail.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=namhyung@kernel.org \
--cc=yangjihong1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).