Linux-perf-users Archive mirror
 help / color / mirror / Atom feed

From: Yabin Cui <yabinc@google.com>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>,
	 Arnaldo Carvalho de Melo <acme@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	 Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Jiri Olsa <jolsa@kernel.org>,  Ian Rogers <irogers@google.com>,
	Adrian Hunter <adrian.hunter@intel.com>,
	 linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
	 bpf <bpf@vger.kernel.org>
Subject: Re: [PATCH] perf/core: Trim dyn_size if raw data is absent
Date: Wed, 1 May 2024 17:10:23 -0700	[thread overview]
Message-ID: <CALJ9ZPP-6bB4f4UP0Ydtsfty-PMRti_MqjZz5uazDXjuFtQsRQ@mail.gmail.com> (raw)
In-Reply-To: <CAM9d7cjQQ3AU7LFXYHEYukwSB9CvFQPtSzg3anfVg=maCP56AA@mail.gmail.com>

Hi Namyung,

Thanks for reviewing the patch! Fixing the callsites is a better idea.
I have sent a v2 patch with name [PATCH v2] perf/core: Save raw sample
data conditionally based on sample type.
Rejecting tracepoint events without PERF_SAMPLE_RAW will break my use
case in Android. So I hope we don't do that.

Thanks,
Yabin






On Mon, Apr 29, 2024 at 2:59 PM Namhyung Kim <namhyung@kernel.org> wrote:
>
> Hello Yabin,
>
> CC-ing the bpf list.
>
> On Thu, Apr 25, 2024 at 3:05 PM Yabin Cui <yabinc@google.com> wrote:
> >
> > Currently, perf_tp_event() always allocates space for raw sample data,
> > even when the PERF_SAMPLE_RAW flag is not set. This leads to unused
> > spaces within generated sample records.
> >
> > This patch reduces dyn_size when PERF_SAMPLE_RAW is not present,
> > ensuring sample records use only the necessary amount of space.
>
> Right, it seems bpf-output and tracepoint events set the flags without
> checking PERF_SAMPLE_RAW.  Can you fix the callsites instead?
> Or we can add perf_event argument to perf_sample_save_raw_data()
> and check the flag inside.
>
> We might reject the output data when it's not opened with the flag.
> But I'm afraid it might break some existing BPF programs.
>
> Thanks,
> Namhyung
>
> >
> > Fixes: 0a9081cf0a11 ("perf/core: Add perf_sample_save_raw_data() helper")
> > Signed-off-by: Yabin Cui <yabinc@google.com>
> > ---
> >  kernel/events/core.c | 4 ++++
> >  1 file changed, 4 insertions(+)
> >
> > diff --git a/kernel/events/core.c b/kernel/events/core.c
> > index 724e6d7e128f..d68ecdc264d3 100644
> > --- a/kernel/events/core.c
> > +++ b/kernel/events/core.c
> > @@ -7688,6 +7688,10 @@ void perf_prepare_sample(struct perf_sample_data *data,
> >                 data->raw = NULL;
> >                 data->dyn_size += sizeof(u64);
> >                 data->sample_flags |= PERF_SAMPLE_RAW;
> > +       } else if ((data->sample_flags & ~sample_type) & PERF_SAMPLE_RAW) {
> > +               data->dyn_size -= data->raw->size + sizeof(u32);
> > +               data->raw = NULL;
> > +               data->sample_flags &= ~PERF_SAMPLE_RAW;
> >         }
> >
> >         if (filtered_sample_type & PERF_SAMPLE_BRANCH_STACK) {
> > --
> > 2.44.0.769.g3c40516874-goog
> >

     prev parent reply	other threads:[~2024-05-02  0:10 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-25 22:05 [PATCH] perf/core: Trim dyn_size if raw data is absent Yabin Cui
2024-04-29 21:59 ` Namhyung Kim
2024-05-02  0:10   ` Yabin Cui [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CALJ9ZPP-6bB4f4UP0Ydtsfty-PMRti_MqjZz5uazDXjuFtQsRQ@mail.gmail.com \
    --to=yabinc@google.com \
    --cc=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=bpf@vger.kernel.org \
    --cc=irogers@google.com \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).