From: Ravi Bangoria <ravi.bangoria@amd.com>
To: Chen Yu <yu.c.chen@intel.com>
Cc: peterz@infradead.org, mingo@redhat.com, acme@kernel.org,
namhyung@kernel.org, irogers@google.com, swapnil.sapkal@amd.com,
mark.rutland@arm.com, alexander.shishkin@linux.intel.com,
jolsa@kernel.org, rostedt@goodmis.org,
vincent.guittot@linaro.org, bristot@redhat.com,
adrian.hunter@intel.com, james.clark@arm.com,
kan.liang@linux.intel.com, gautham.shenoy@amd.com,
kprateek.nayak@amd.com, juri.lelli@redhat.com,
yangjihong@bytedance.com, linux-kernel@vger.kernel.org,
linux-perf-users@vger.kernel.org, santosh.shukla@amd.com,
ananth.narayan@amd.com, sandipan.das@amd.com,
Ravi Bangoria <ravi.bangoria@amd.com>
Subject: Re: [RFC 4/4] perf sched schedstat: Add support for report subcommand
Date: Mon, 13 May 2024 08:43:32 +0530 [thread overview]
Message-ID: <284a27be-bd63-d86c-885f-756bd2d37adc@amd.com> (raw)
In-Reply-To: <Zj8iMV9vhyGC3tT9@chenyu5-mobl2>
On 11-May-24 1:15 PM, Chen Yu wrote:
> On 2024-05-08 at 11:34:27 +0530, Ravi Bangoria wrote:
>> From: Swapnil Sapkal <swapnil.sapkal@amd.com>
>>
>> `perf sched schedstat record` captures two sets of samples. For workload
>> profile, first set right before workload starts and second set after
>> workload finishes. For the systemwide profile, first set at the beginning
>> of profile and second set on receiving SIGINT signal.
>>
>> Add `perf sched schedstat report` subcommand that will read both the set
>> of samples, get the diff and render a final report. Final report prints
>> scheduler stat at cpu granularity as well as sched domain granularity.
>>
>> Usage example:
>>
>> # perf sched schedstat record
>> # perf sched schedstat report
>>
>> Co-developed-by: Ravi Bangoria <ravi.bangoria@amd.com>
>> Signed-off-by: Swapnil Sapkal <swapnil.sapkal@amd.com>
>> Signed-off-by: Ravi Bangoria <ravi.bangoria@amd.com>
>>
>
> I've tested it on a 240 CPUs Xeon system and it looks very useful. Thanks!
Glad you found it useful!
> 1. Just to confirm, if we want to add new fields for debugging purpose,
> schedstat-domain-v1x.h and schedstat-cpu-v1x.h are the only files to
> be touched, right?
Correct.
> 2. Although we can filter the output, is it applicable to only track some
> CPUs? Like perf sched schedstat -C 4 record
Yes, adding filtering capabilities should be possible at both record and report
time.
Thanks,
Ravi
next prev parent reply other threads:[~2024-05-13 3:13 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-08 6:04 [RFC 0/4] perf sched: Introduce schedstat tool Ravi Bangoria
2024-05-08 6:04 ` [RFC 1/4] perf sched: Make `struct perf_sched sched` a global variable Ravi Bangoria
2024-05-08 6:04 ` [RFC 2/4] perf sched: Add template code for schedstat subcommand Ravi Bangoria
2024-05-08 6:04 ` [RFC 3/4] perf sched schedstat: Add record and rawdump support Ravi Bangoria
2024-05-08 6:04 ` [RFC 4/4] perf sched schedstat: Add support for report subcommand Ravi Bangoria
2024-05-11 7:45 ` Chen Yu
2024-05-13 3:13 ` Ravi Bangoria [this message]
2024-05-08 22:21 ` [RFC 0/4] perf sched: Introduce schedstat tool Ian Rogers
2024-05-09 5:09 ` Ravi Bangoria
2024-05-09 5:08 ` Namhyung Kim
2024-05-09 6:02 ` Ravi Bangoria
2024-05-09 22:33 ` Namhyung Kim
2024-05-10 4:46 ` Ravi Bangoria
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=284a27be-bd63-d86c-885f-756bd2d37adc@amd.com \
--to=ravi.bangoria@amd.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=ananth.narayan@amd.com \
--cc=bristot@redhat.com \
--cc=gautham.shenoy@amd.com \
--cc=irogers@google.com \
--cc=james.clark@arm.com \
--cc=jolsa@kernel.org \
--cc=juri.lelli@redhat.com \
--cc=kan.liang@linux.intel.com \
--cc=kprateek.nayak@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=sandipan.das@amd.com \
--cc=santosh.shukla@amd.com \
--cc=swapnil.sapkal@amd.com \
--cc=vincent.guittot@linaro.org \
--cc=yangjihong@bytedance.com \
--cc=yu.c.chen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).