From: weilin.wang@intel.com
To: weilin.wang@intel.com, Namhyung Kim <namhyung@kernel.org>,
Ian Rogers <irogers@google.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>,
Adrian Hunter <adrian.hunter@intel.com>,
Kan Liang <kan.liang@linux.intel.com>
Cc: linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
Perry Taylor <perry.taylor@intel.com>,
Samantha Alt <samantha.alt@intel.com>,
Caleb Biggers <caleb.biggers@intel.com>
Subject: [RFC PATCH v8 5/7] perf stat: Add retire latency print functions to print out at the very end of print out
Date: Wed, 15 May 2024 01:44:27 -0400 [thread overview]
Message-ID: <20240515054443.2824147-6-weilin.wang@intel.com> (raw)
In-Reply-To: <20240515054443.2824147-1-weilin.wang@intel.com>
From: Weilin Wang <weilin.wang@intel.com>
Add print out functions so that users could read retire latency values.
Example output:
Performance counter stats for 'system wide':
25,717 MEM_INST_RETIRED.SPLIT_STORES # 2.2 % tma_split_stores
28,365,080 CPU_CLK_UNHALTED.THREAD
24.00 MEM_INST_RETIRED.SPLIT_STORES:R # 96 4
2.054365083 seconds time elapsed
This output of retire latency data is in format:
<val> <event-name:R> # <sum> <count>.
Signed-off-by: Weilin Wang <weilin.wang@intel.com>
Reviewed-by: Ian Rogers <irogers@google.com>
---
tools/perf/util/stat-display.c | 69 ++++++++++++++++++++++++++++++++++
1 file changed, 69 insertions(+)
diff --git a/tools/perf/util/stat-display.c b/tools/perf/util/stat-display.c
index bfc1d705f437..b9c3978cc99c 100644
--- a/tools/perf/util/stat-display.c
+++ b/tools/perf/util/stat-display.c
@@ -21,6 +21,7 @@
#include "iostat.h"
#include "pmu.h"
#include "pmus.h"
+#include "intel-tpebs.h"
#define CNTR_NOT_SUPPORTED "<not supported>"
#define CNTR_NOT_COUNTED "<not counted>"
@@ -34,6 +35,7 @@
#define COMM_LEN 16
#define PID_LEN 7
#define CPUS_LEN 4
+#define RETIRE_LEN 8
static int aggr_header_lens[] = {
[AGGR_CORE] = 18,
@@ -426,6 +428,71 @@ static void print_metric_std(struct perf_stat_config *config,
fprintf(out, " %-*s", METRIC_LEN - n - 1, unit);
}
+static void print_retire_lat_std(struct perf_stat_config *config,
+ struct outstate *os)
+{
+ FILE *out = os->fh;
+ bool newline = os->newline;
+ struct tpebs_retire_lat *t;
+ struct list_head *retire_lats = &config->tpebs_results;
+
+ list_for_each_entry(t, retire_lats, nd) {
+ if (newline)
+ do_new_line_std(config, os);
+ fprintf(out, "%'*.2f ", COUNTS_LEN, t->val);
+ /* For print alignment */
+ fprintf(out, "%-*s ", config->unit_width, "");
+ fprintf(out, "%-*s", EVNAME_LEN, t->tpebs_name);
+ fprintf(out, " # ");
+ fprintf(out, "%*d %*ld\n", RETIRE_LEN, t->sum,
+ RETIRE_LEN, t->count);
+ }
+}
+
+static void print_retire_lat_csv(struct perf_stat_config *config,
+ struct outstate *os)
+{
+ FILE *out = os->fh;
+ struct tpebs_retire_lat *t;
+ struct list_head *retire_lats = &config->tpebs_results;
+ const char *sep = config->csv_sep;
+
+ list_for_each_entry(t, retire_lats, nd) {
+ fprintf(out, "%f%s%s%s%s%ld%s%d\n", t->val, sep, sep, t->tpebs_name, sep,
+ t->count, sep, t->sum);
+ }
+}
+
+static void print_retire_lat_json(struct perf_stat_config *config,
+ struct outstate *os)
+{
+ FILE *out = os->fh;
+ struct tpebs_retire_lat *t;
+ struct list_head *retire_lats = &config->tpebs_results;
+
+ fprintf(out, "{");
+ list_for_each_entry(t, retire_lats, nd) {
+ fprintf(out, "\"retire_latency-value\" : \"%f\", ", t->val);
+ fprintf(out, "\"name\" : \"%s\"", t->tpebs_name);
+ fprintf(out, "\"sample-counts\" : \"%ld\"", t->count);
+ fprintf(out, "\"retire_latency-sum\" : \"%d\"", t->sum);
+ }
+ fprintf(out, "}");
+}
+
+static void print_retire_lat(struct perf_stat_config *config,
+ struct outstate *os)
+{
+ if (!&config->tpebs_results)
+ return;
+ if (config->json_output)
+ print_retire_lat_json(config, os);
+ else if (config->csv_output)
+ print_retire_lat_csv(config, os);
+ else
+ print_retire_lat_std(config, os);
+}
+
static void new_line_csv(struct perf_stat_config *config, void *ctx)
{
struct outstate *os = ctx;
@@ -1609,6 +1676,8 @@ void evlist__print_counters(struct evlist *evlist, struct perf_stat_config *conf
break;
}
+ print_retire_lat(config, &os);
+
print_footer(config);
fflush(config->output);
--
2.43.0
next prev parent reply other threads:[~2024-05-15 5:44 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-15 5:44 [RFC PATCH v8 0/7] TPEBS counting mode support weilin.wang
2024-05-15 5:44 ` [RFC PATCH v8 1/7] perf Document: Add TPEBS to Documents weilin.wang
2024-05-16 16:10 ` Ian Rogers
2024-05-16 17:37 ` Wang, Weilin
2024-05-17 21:28 ` Namhyung Kim
2024-05-15 5:44 ` [RFC PATCH v8 2/7] perf data: Allow to use given fd in data->file.fd weilin.wang
2024-05-16 16:11 ` Ian Rogers
2024-05-15 5:44 ` [RFC PATCH v8 3/7] perf stat: Fork and launch perf record when perf stat needs to get retire latency value for a metric weilin.wang
2024-05-16 16:43 ` Ian Rogers
2024-05-16 17:38 ` Wang, Weilin
2024-05-16 18:07 ` Ian Rogers
2024-05-16 18:16 ` Wang, Weilin
2024-05-17 21:43 ` Namhyung Kim
2024-05-17 21:57 ` Wang, Weilin
2024-05-21 0:10 ` Wang, Weilin
2024-05-21 5:42 ` Namhyung Kim
2024-05-21 16:23 ` Wang, Weilin
2024-05-15 5:44 ` [RFC PATCH v8 4/7] perf stat: Add retire latency values into the expr_parse_ctx to prepare for final metric calculation weilin.wang
2024-05-16 16:44 ` Ian Rogers
2024-05-15 5:44 ` weilin.wang [this message]
2024-05-16 16:47 ` [RFC PATCH v8 5/7] perf stat: Add retire latency print functions to print out at the very end of print out Ian Rogers
2024-05-16 17:51 ` Wang, Weilin
2024-05-16 18:08 ` Ian Rogers
2024-05-15 5:44 ` [RFC PATCH v8 6/7] perf vendor events intel: Add MTL metric json files weilin.wang
2024-05-16 16:57 ` Ian Rogers
2024-05-16 17:44 ` Wang, Weilin
2024-05-15 5:44 ` [RFC PATCH v8 7/7] perf stat: Skip read retire_lat counters and plugin retire_lat data from sampled data weilin.wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240515054443.2824147-6-weilin.wang@intel.com \
--to=weilin.wang@intel.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=caleb.biggers@intel.com \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=perry.taylor@intel.com \
--cc=peterz@infradead.org \
--cc=samantha.alt@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).