From: Ian Rogers <irogers@google.com>
To: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>, Ian Rogers <irogers@google.com>,
Adrian Hunter <adrian.hunter@intel.com>,
Kan Liang <kan.liang@linux.intel.com>,
Oliver Upton <oliver.upton@linux.dev>,
James Clark <james.clark@arm.com>,
Tim Chen <tim.c.chen@linux.intel.com>,
Yicong Yang <yangyicong@hisilicon.com>,
K Prateek Nayak <kprateek.nayak@amd.com>,
Yanteng Si <siyanteng@loongson.cn>,
Sun Haiyong <sunhaiyong@loongson.cn>,
Kajol Jain <kjain@linux.ibm.com>,
Ravi Bangoria <ravi.bangoria@amd.com>, Li Dong <lidong@vivo.com>,
Paran Lee <p4ranlee@gmail.com>, Ben Gainey <ben.gainey@arm.com>,
Andi Kleen <ak@linux.intel.com>,
Athira Rajeev <atrajeev@linux.vnet.ibm.com>,
linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org
Subject: [PATCH v1 0/8] Address/leak sanitizer clean ups
Date: Tue, 7 May 2024 11:35:37 -0700 [thread overview]
Message-ID: <20240507183545.1236093-1-irogers@google.com> (raw)
Remove unnecessary reference counts for structs with no gets. Add
reference count checking to comm_str and mem_info. Fix memory leaks
and errors detected on "perf mem report" by address sanitizer and leak
sanitizer.
Ian Rogers (8):
perf ui browser: Don't save pointer to stack memory
perf annotate: Fix memory leak in annotated_source
perf block-info: Remove unused refcount
perf cpumap: Remove refcnt from cpu_aggr_map
perf comm: Add reference count checking to comm_str
perf mem-info: Move mem-info out of mem-events and symbol
perf mem-info: Add reference count checking
perf hist: Avoid hist_entry_iter mem_info memory leak
tools/perf/builtin-c2c.c | 13 +-
tools/perf/builtin-report.c | 3 +-
tools/perf/builtin-script.c | 12 +-
tools/perf/builtin-stat.c | 16 +-
tools/perf/tests/mem.c | 11 +-
tools/perf/ui/browser.c | 4 +-
tools/perf/ui/browser.h | 2 +-
tools/perf/util/Build | 1 +
tools/perf/util/annotate.c | 6 +
tools/perf/util/block-info.c | 22 +-
tools/perf/util/block-info.h | 15 +-
tools/perf/util/comm.c | 196 +++++++++++-------
tools/perf/util/cpumap.c | 2 -
tools/perf/util/cpumap.h | 2 -
tools/perf/util/hist.c | 62 +++---
tools/perf/util/hist.h | 8 +-
tools/perf/util/machine.c | 7 +-
tools/perf/util/mem-events.c | 36 ++--
tools/perf/util/mem-events.h | 29 +--
tools/perf/util/mem-info.c | 35 ++++
tools/perf/util/mem-info.h | 54 +++++
.../scripting-engines/trace-event-python.c | 12 +-
tools/perf/util/sort.c | 69 +++---
tools/perf/util/symbol.c | 26 +--
tools/perf/util/symbol.h | 12 --
25 files changed, 370 insertions(+), 285 deletions(-)
create mode 100644 tools/perf/util/mem-info.c
create mode 100644 tools/perf/util/mem-info.h
--
2.45.0.rc1.225.g2a3ae87e7f-goog
next reply other threads:[~2024-05-07 18:36 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-07 18:35 Ian Rogers [this message]
2024-05-07 18:35 ` [PATCH v1 1/8] perf ui browser: Don't save pointer to stack memory Ian Rogers
2024-05-07 20:20 ` Arnaldo Carvalho de Melo
2024-05-07 20:22 ` Arnaldo Carvalho de Melo
2024-05-07 20:48 ` Ian Rogers
2024-05-07 21:04 ` Arnaldo Carvalho de Melo
2024-05-07 21:07 ` Arnaldo Carvalho de Melo
2024-05-08 0:51 ` Ian Rogers
[not found] ` <CA+JHD90W7PLBx=SEL9+7-_=LkjaMu4YM1S3kJ2oSkAYoHE7hPw@mail.gmail.com>
2024-05-08 1:17 ` Ian Rogers
2024-05-07 18:35 ` [PATCH v1 2/8] perf annotate: Fix memory leak in annotated_source Ian Rogers
2024-05-07 18:35 ` [PATCH v1 3/8] perf block-info: Remove unused refcount Ian Rogers
2024-05-07 18:35 ` [PATCH v1 4/8] perf cpumap: Remove refcnt from cpu_aggr_map Ian Rogers
2024-05-07 18:35 ` [PATCH v1 5/8] perf comm: Add reference count checking to comm_str Ian Rogers
2024-05-07 18:35 ` [PATCH v1 6/8] perf mem-info: Move mem-info out of mem-events and symbol Ian Rogers
2024-05-07 18:35 ` [PATCH v1 7/8] perf mem-info: Add reference count checking Ian Rogers
2024-05-07 18:35 ` [PATCH v1 8/8] perf hist: Avoid hist_entry_iter mem_info memory leak Ian Rogers
2024-05-07 20:51 ` [PATCH v1 0/8] Address/leak sanitizer clean ups Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240507183545.1236093-1-irogers@google.com \
--to=irogers@google.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=atrajeev@linux.vnet.ibm.com \
--cc=ben.gainey@arm.com \
--cc=james.clark@arm.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=kjain@linux.ibm.com \
--cc=kprateek.nayak@amd.com \
--cc=lidong@vivo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=oliver.upton@linux.dev \
--cc=p4ranlee@gmail.com \
--cc=peterz@infradead.org \
--cc=ravi.bangoria@amd.com \
--cc=siyanteng@loongson.cn \
--cc=sunhaiyong@loongson.cn \
--cc=tim.c.chen@linux.intel.com \
--cc=yangyicong@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).