From: Xu Yang <xu.yang_2@nxp.com>
To: Frank Li <Frank.li@nxp.com>
Cc: Will Deacon <will@kernel.org>,
mark.rutland@arm.com, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
shawnguo@kernel.org, s.hauer@pengutronix.de,
kernel@pengutronix.de, festevam@gmail.com,
john.g.garry@oracle.com, jolsa@kernel.org, namhyung@kernel.org,
irogers@google.com, mike.leach@linaro.org, peterz@infradead.org,
mingo@redhat.com, acme@kernel.org,
alexander.shishkin@linux.intel.com, adrian.hunter@intel.com,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
imx@lists.linux.dev
Subject: Re: [PATCH v10 3/8] perf: imx_perf: let the driver manage the counter usage rather the user
Date: Tue, 23 Apr 2024 19:45:39 +0800 [thread overview]
Message-ID: <20240423114539.4jseauipidvwo7bh@hippo> (raw)
In-Reply-To: <ZiK6G3aM+K92lq0w@lizhi-Precision-Tower-5810>
Hi Frank,
On Fri, Apr 19, 2024 at 02:38:19PM -0400, Frank Li wrote:
> On Fri, Apr 19, 2024 at 04:49:13PM +0100, Will Deacon wrote:
> > On Mon, Apr 15, 2024 at 02:13:15PM +0800, Xu Yang wrote:
> > > In current design, the user of perf app needs to input counter ID to count
> > > events. However, this is not user-friendly since the user needs to lookup
> > > the map table to find the counter. Instead of letting the user to input
> > > the counter, let this driver to manage the counters in this patch.
> > >
> > > This will be implemented by:
> > > 1. allocate counter 0 for cycle event.
> > > 2. find unused counter from 1-10 for reference events.
> > > 3. allocate specific counter for counter-specific events.
> > >
> > > In this patch, counter attr will be kept for back-compatible but all the
> > > value passed down by counter=<n> will be ignored. To mark counter-specific
> > > events, counter ID will be encoded into perf_pmu_events_attr.id.
> > >
> > > Reviewed-by: Frank Li <Frank.Li@nxp.com>
> > > Signed-off-by: Xu Yang <xu.yang_2@nxp.com>
> > >
> > > ---
> > > Changes in v6:
> > > - new patch
> > > Changes in v7:
> > > - no changes
> > > Changes in v8:
> > > - add Rb tag
> > > Changes in v9:
> > > - keep 'counter' attr for back-compatible
> > > Changes in v10:
> > > - add some explanation about 'counter' attr in commit message
> > > ---
> > > drivers/perf/fsl_imx9_ddr_perf.c | 168 ++++++++++++++++++-------------
> > > 1 file changed, 100 insertions(+), 68 deletions(-)
> >
> > [...]
> >
> > > @@ -245,8 +249,8 @@ static const struct attribute_group ddr_perf_events_attr_group = {
> > > .attrs = ddr_perf_events_attrs,
> > > };
> > >
> > > -PMU_FORMAT_ATTR(event, "config:0-7");
> > > -PMU_FORMAT_ATTR(counter, "config:8-15");
> > > +PMU_FORMAT_ATTR(event, "config:0-15");
> > > +PMU_FORMAT_ATTR(counter, "config:16-23");
> >
> > Although these mappings are advertised in sysfs, I don't think we can
> > change them because userspace could be relying on them. I also can't
> > find any examples of other PMU drivers in the kernel changing these
> > mappings after being merged, so please keep tthem the same.
> >
> > If you need to expand the properties to be 16-bit, then you'll need to
> > split them into 2x8-bit fields.
>
> I just see tools/perf/tests/pmu.c: { "krava01", "config:0-1,62-63\n", }
> So I supposed "config:" supported below format
>
> PMU_FORMAT_ATTR(event, "config:0-7,16-19");
It works.
Thanks,
Xu Yang
>
> I just want to confim with you because I have not found other perf driver
> using such format yet.
>
> Frank
>
> >
> > Will
next prev parent reply other threads:[~2024-04-23 11:47 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-15 6:13 [PATCH v10 1/8] dt-bindings: perf: fsl-imx-ddr: Add i.MX95 compatible Xu Yang
2024-04-15 6:13 ` [PATCH v10 2/8] perf: imx_perf: add macro definitions for parsing config attr Xu Yang
2024-04-15 6:13 ` [PATCH v10 3/8] perf: imx_perf: let the driver manage the counter usage rather the user Xu Yang
2024-04-19 15:49 ` Will Deacon
2024-04-19 18:38 ` Frank Li
2024-04-22 16:51 ` Will Deacon
2024-04-23 11:43 ` Xu Yang
2024-04-23 11:45 ` Xu Yang [this message]
2024-04-15 6:13 ` [PATCH v10 4/8] perf: imx_perf: refactor driver for imx93 Xu Yang
2024-04-15 6:13 ` [PATCH v10 5/8] perf: imx_perf: fix counter start and config sequence Xu Yang
2024-04-15 6:13 ` [PATCH v10 6/8] perf: imx_perf: add support for i.MX95 platform Xu Yang
2024-04-15 6:13 ` [PATCH v10 7/8] perf vendor events arm64:: Add i.MX95 DDR Performance Monitor metrics Xu Yang
2024-04-15 6:13 ` [PATCH v10 8/8] perf vendor events arm64:: Add i.MX93 " Xu Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240423114539.4jseauipidvwo7bh@hippo \
--to=xu.yang_2@nxp.com \
--cc=Frank.li@nxp.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=irogers@google.com \
--cc=john.g.garry@oracle.com \
--cc=jolsa@kernel.org \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mike.leach@linaro.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).