From: vmolnaro@redhat.com
To: linux-perf-users@vger.kernel.org, acme@kernel.org, acme@redhat.com
Cc: mpetlan@redhat.com
Subject: [PATCH] perf test stat_all_pmu.sh: Parse return value of perf stat
Date: Tue, 9 Apr 2024 15:02:40 +0200 [thread overview]
Message-ID: <20240409130240.13973-1-vmolnaro@redhat.com> (raw)
From: Veronika Molnarova <vmolnaro@redhat.com>
With the MR a381bd3615de6 ('powerpc/hv-gpci: Fix the
H_GET_PERF_COUNTER_INFO hcall return value checks') the perf stat for
hv_gpci events without required permission set returns an error value
of -1 to differentiate the output from the unsupported events. The
stat_all_pmu test, however, exits immediately if any command exits with
a non-zero value due to 'set -e' option.
Remove the 'set -e' option from the test and rework the test case to log
the status of the event for better maintainability. Instead of exiting
immediately after 'perf stat' ends with a non-zero value, check the
return value and output of the 'perf stat' command with appriopriate action.
---
tools/perf/tests/shell/stat_all_pmu.sh | 36 ++++++++++++++++++--------
1 file changed, 25 insertions(+), 11 deletions(-)
diff --git a/tools/perf/tests/shell/stat_all_pmu.sh b/tools/perf/tests/shell/stat_all_pmu.sh
index c77955419173..d9f0d2100baa 100755
--- a/tools/perf/tests/shell/stat_all_pmu.sh
+++ b/tools/perf/tests/shell/stat_all_pmu.sh
@@ -2,21 +2,35 @@
# perf all PMU test
# SPDX-License-Identifier: GPL-2.0
-set -e
# Test all PMU events; however exclude parametrized ones (name contains '?')
for p in $(perf list --raw-dump pmu | sed 's/[[:graph:]]\+?[[:graph:]]\+[[:space:]]//g'); do
- echo "Testing $p"
- result=$(perf stat -e "$p" true 2>&1)
- if ! echo "$result" | grep -q "$p" && ! echo "$result" | grep -q "<not supported>" ; then
- # We failed to see the event and it is supported. Possibly the workload was
- # too small so retry with something longer.
- result=$(perf stat -e "$p" perf bench internals synthesize 2>&1)
- if ! echo "$result" | grep -q "$p" ; then
- echo "Event '$p' not printed in:"
- echo "$result"
- exit 1
+ echo -n "Testing event '$p' -- "
+ stat_output=$(perf stat -e "$p" true 2>&1)
+ stat_result=$?
+ if echo "$stat_output" | grep -q "$p"; then
+ # return value 0 if counters gets printed either if the event is supported or not
+ if [ $stat_result -eq 0 ] && ! echo "$stat_output" | grep -q "<not supported>"; then
+ echo "supported"
+ elif [ $stat_result -eq 0 ]; then
+ echo "not supported"
+ # return value 255 when the required pemission for the event is not set
+ elif [ $stat_result -eq 255 ] && echo "$stat_output" | grep -q "No permission"; then
+ echo "no permission to enable"
+ # return value 129 when trying to run 'perf stat' with a non-existent event
+ elif [ $stat_result -eq 129 ] && echo "$stat_output" | grep -q "Bad event name"; then
+ echo "Fail: Bad event name"
+ echo "$stat_output"
+ exit 1
+ else
+ echo "Fail: Unknown return value $stat_result"
+ echo "$stat_output"
+ exit 1
fi
+ else
+ echo "Fail: Event '$p' not printed in:"
+ echo "$stat_output"
+ exit 1
fi
done
--
2.43.0
next reply other threads:[~2024-04-09 13:03 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-09 13:02 vmolnaro [this message]
2024-04-11 18:18 ` [PATCH] perf test stat_all_pmu.sh: Parse return value of perf stat Arnaldo Carvalho de Melo
2024-04-15 9:42 ` [PATCH v2] " vmolnaro
2024-04-15 17:41 ` Arnaldo Carvalho de Melo
2024-04-16 14:33 ` Arnaldo Carvalho de Melo
2024-04-18 7:06 ` kajoljain
2024-04-23 8:01 ` kajoljain
2024-04-26 16:30 ` Veronika Molnarova
2024-04-16 15:03 ` [PATCH] " Ian Rogers
2024-04-16 15:28 ` Arnaldo Carvalho de Melo
2024-04-29 10:56 ` [PATCH v2] " vmolnaro
2024-05-03 20:25 ` Arnaldo Carvalho de Melo
2024-05-08 10:28 ` Veronika Molnarova
2024-04-26 16:19 ` [PATCH] " Veronika Molnarova
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240409130240.13973-1-vmolnaro@redhat.com \
--to=vmolnaro@redhat.com \
--cc=acme@kernel.org \
--cc=acme@redhat.com \
--cc=linux-perf-users@vger.kernel.org \
--cc=mpetlan@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).