From: Niklas Cassel <cassel@kernel.org>
To: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Cc: "Jingoo Han" <jingoohan1@gmail.com>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Heiko Stuebner" <heiko@sntech.de>,
"Kishon Vijay Abraham I" <kishon@kernel.org>,
"Arnd Bergmann" <arnd@arndb.de>,
"Damien Le Moal" <dlemoal@kernel.org>,
"Jon Lin" <jon.lin@rock-chips.com>,
"Shawn Lin" <shawn.lin@rock-chips.com>,
"Simon Xue" <xxm@rock-chips.com>,
linux-pci@vger.kernel.org, devicetree@vger.kernel.org,
linux-rockchip@lists.infradead.org
Subject: Re: [PATCH v2 08/14] PCI: dw-rockchip: Add rockchip_pcie_ltssm() helper
Date: Wed, 8 May 2024 01:55:24 +0200 [thread overview]
Message-ID: <Zjq_bEoFe-xR_hww@ryzen.lan> (raw)
In-Reply-To: <20240504171346.GE4315@thinkpad>
Hello Mani,
On Sat, May 04, 2024 at 10:43:46PM +0530, Manivannan Sadhasivam wrote:
> On Tue, Apr 30, 2024 at 02:01:05PM +0200, Niklas Cassel wrote:
> > Add a rockchip_pcie_ltssm() helper function that reads the LTSSM status.
> > This helper will be used in additional places in follow-up patches.
> >
>
> Please don't use 'patches' in commit logs. Once the patches get merged, they
> become commits.
Sure, will fix in V2.
>
> > Signed-off-by: Niklas Cassel <cassel@kernel.org>
> > ---
> > drivers/pci/controller/dwc/pcie-dw-rockchip.c | 7 ++++++-
> > 1 file changed, 6 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/pci/controller/dwc/pcie-dw-rockchip.c b/drivers/pci/controller/dwc/pcie-dw-rockchip.c
> > index 1993c430b90c..4023fd86176f 100644
> > --- a/drivers/pci/controller/dwc/pcie-dw-rockchip.c
> > +++ b/drivers/pci/controller/dwc/pcie-dw-rockchip.c
> > @@ -143,6 +143,11 @@ static int rockchip_pcie_init_irq_domain(struct rockchip_pcie *rockchip)
> > return 0;
> > }
> >
> > +static inline u32 rockchip_pcie_ltssm(struct rockchip_pcie *rockchip)
>
> rockchip_pcie_get_ltssm()?
Sure, will fix in V2.
>
> Also, no inline in C files, please. Compiler will inline functions with or
> without the keyword anyway.
Sure, will fix in V2.
Kind regards,
Niklas
next prev parent reply other threads:[~2024-05-07 23:55 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-30 12:00 [PATCH v2 00/14] PCI: dw-rockchip: Add endpoint mode support Niklas Cassel
2024-04-30 12:00 ` [PATCH v2 01/14] dt-bindings: PCI: snps,dw-pcie-ep: Add vendor specific reg-name Niklas Cassel
2024-04-30 12:00 ` [PATCH v2 02/14] dt-bindings: PCI: snps,dw-pcie-ep: Add vendor specific interrupt-names Niklas Cassel
2024-04-30 12:01 ` [PATCH v2 03/14] dt-bindings: PCI: snps,dw-pcie-ep: Add tx_int{a,b,c,d} legacy irqs Niklas Cassel
2024-04-30 12:01 ` [PATCH v2 04/14] dt-bindings: PCI: rockchip-dw-pcie: Prepare for Endpoint mode support Niklas Cassel
2024-05-07 15:48 ` Rob Herring (Arm)
2024-04-30 12:01 ` [PATCH v2 05/14] dt-bindings: PCI: rockchip-dw-pcie: Fix description of legacy irq Niklas Cassel
2024-05-07 15:49 ` Rob Herring (Arm)
2024-04-30 12:01 ` [PATCH v2 06/14] dt-bindings: rockchip: Add DesignWare based PCIe Endpoint controller Niklas Cassel
2024-05-07 15:49 ` Rob Herring (Arm)
2024-04-30 12:01 ` [PATCH v2 07/14] PCI: dw-rockchip: Fix weird indentation Niklas Cassel
2024-05-04 17:10 ` Manivannan Sadhasivam
2024-04-30 12:01 ` [PATCH v2 08/14] PCI: dw-rockchip: Add rockchip_pcie_ltssm() helper Niklas Cassel
2024-05-04 17:13 ` Manivannan Sadhasivam
2024-05-07 23:55 ` Niklas Cassel [this message]
2024-04-30 12:01 ` [PATCH v2 09/14] PCI: dw-rockchip: Refactor the driver to prepare for EP mode Niklas Cassel
2024-05-04 17:19 ` Manivannan Sadhasivam
2024-04-30 12:01 ` [PATCH v2 10/14] PCI: dw-rockchip: Add explicit rockchip,rk3588-pcie compatible Niklas Cassel
2024-05-04 17:20 ` Manivannan Sadhasivam
2024-04-30 12:01 ` [PATCH v2 11/14] PCI: dw-rockchip: Add endpoint mode support Niklas Cassel
2024-05-04 17:32 ` Manivannan Sadhasivam
2024-05-07 23:50 ` Niklas Cassel
2024-04-30 12:01 ` [PATCH v2 12/14] misc: pci_endpoint_test: Add support for rockchip rk3588 Niklas Cassel
2024-05-04 17:33 ` Manivannan Sadhasivam
2024-04-30 12:01 ` [PATCH v2 13/14] arm64: dts: rockchip: Add PCIe endpoint mode support Niklas Cassel
2024-05-04 17:34 ` Manivannan Sadhasivam
2024-05-07 23:51 ` Niklas Cassel
2024-04-30 12:01 ` [PATCH v2 14/14] arm64: dts: rockchip: Add rock5b overlays for PCIe endpoint mode Niklas Cassel
2024-05-04 17:37 ` Manivannan Sadhasivam
2024-05-05 12:14 ` Heiko Stübner
2024-05-07 23:52 ` Niklas Cassel
2024-05-04 17:05 ` [PATCH v2 00/14] PCI: dw-rockchip: Add endpoint mode support Manivannan Sadhasivam
2024-05-07 23:48 ` Niklas Cassel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zjq_bEoFe-xR_hww@ryzen.lan \
--to=cassel@kernel.org \
--cc=arnd@arndb.de \
--cc=bhelgaas@google.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlemoal@kernel.org \
--cc=heiko@sntech.de \
--cc=jingoohan1@gmail.com \
--cc=jon.lin@rock-chips.com \
--cc=kishon@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=kw@linux.com \
--cc=linux-pci@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=lpieralisi@kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=robh@kernel.org \
--cc=shawn.lin@rock-chips.com \
--cc=xxm@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).