From: "Dr. David Alan Gilbert" <linux@treblig.org>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
bhelgaas@google.com, dave.hansen@linux.intel.com, x86@kernel.org,
linux-pci@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86: ce4100: Remove unused struct 'sim_reg_op'
Date: Tue, 7 May 2024 23:24:25 +0000 [thread overview]
Message-ID: <Zjq4KWSh63P6Y_Zg@gallifrey> (raw)
In-Reply-To: <20240506152304.GA1699729@bhelgaas>
* Bjorn Helgaas (helgaas@kernel.org) wrote:
> On Mon, May 06, 2024 at 02:43:20PM +0000, Dr. David Alan Gilbert wrote:
> > * Ilpo Järvinen (ilpo.jarvinen@linux.intel.com) wrote:
> > > On Mon, 6 May 2024, linux@treblig.org wrote:
> > >
> > > > From: "Dr. David Alan Gilbert" <linux@treblig.org>
> > > >
> > > > This doesn't look like it was ever used.
> > >
> > > Don't start with "This" but spell what you're talking about out so it
> > > can be read and understood without shortlog in Subject (or looking into
> > > the code change).
> >
> > I'm of course happy to rework that if it helps you, although
> > I thought the subject line was sufficient.
>
> It's a minor point, to be sure. The way I think about this is "an
> essay title is not part of the essay itself," so the essay (commit
> log) should make sense all by itself.
OK, modified v2 sent.
Dave
> Bjorn
>
--
-----Open up your eyes, open up your mind, open up your code -------
/ Dr. David Alan Gilbert | Running GNU/Linux | Happy \
\ dave @ treblig.org | | In Hex /
\ _________________________|_____ http://www.treblig.org |_______/
prev parent reply other threads:[~2024-05-07 23:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-06 0:46 [PATCH] x86: ce4100: Remove unused struct 'sim_reg_op' linux
2024-05-06 14:17 ` Ilpo Järvinen
2024-05-06 14:43 ` Dr. David Alan Gilbert
2024-05-06 15:23 ` Bjorn Helgaas
2024-05-07 23:24 ` Dr. David Alan Gilbert [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zjq4KWSh63P6Y_Zg@gallifrey \
--to=linux@treblig.org \
--cc=bhelgaas@google.com \
--cc=dave.hansen@linux.intel.com \
--cc=helgaas@kernel.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).