From: Niklas Cassel <cassel@kernel.org>
To: Frank Li <Frank.li@nxp.com>
Cc: "Jingoo Han" <jingoohan1@gmail.com>,
"Manivannan Sadhasivam" <manivannan.sadhasivam@linaro.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Heiko Stuebner" <heiko@sntech.de>,
"Kishon Vijay Abraham I" <kishon@kernel.org>,
"Arnd Bergmann" <arnd@arndb.de>,
"Damien Le Moal" <dlemoal@kernel.org>,
"Jon Lin" <jon.lin@rock-chips.com>,
"Shawn Lin" <shawn.lin@rock-chips.com>,
"Simon Xue" <xxm@rock-chips.com>,
linux-pci@vger.kernel.org, devicetree@vger.kernel.org,
linux-rockchip@lists.infradead.org
Subject: Re: [PATCH 10/12] misc: pci_endpoint_test: Add support for rockchip rk3588
Date: Tue, 30 Apr 2024 13:42:41 +0200 [thread overview]
Message-ID: <ZjDZMeNGPA6rCr7O@ryzen.lan> (raw)
In-Reply-To: <ZiqsJZh5SV6q33Fz@lizhi-Precision-Tower-5810>
On Thu, Apr 25, 2024 at 03:16:53PM -0400, Frank Li wrote:
> On Wed, Apr 24, 2024 at 05:16:28PM +0200, Niklas Cassel wrote:
> > Rockchip rk3588 requires 64k alignment.
> > While there is an existing device_id:vendor_id in the driver with 64k
> > alignment, that device_id:vendor_id is am654, which uses BAR2 instead of
> > BAR0 as the test_reg_bar, and also has special is_am654_pci_dev() checks
> > in the driver to disallow BAR0. In order to allow testing all BARs, add a
> > new rk3588 entry in the driver.
> >
> > We intentionally do not add the vendor id to pci_ids.h, since the policy
> > for that file is that the vendor id has to be used by multiple drivers.
> >
> > Hopefully, this new entry will be short-lived, as there is a series on the
> > mailing list which intends to move the address alignment restrictions from
> > this driver to the endpoint side.
> >
> > Add a new entry for rk3588 in order to allow us to test all BARs.
> >
> > Signed-off-by: Niklas Cassel <cassel@kernel.org>
> > ---
> > drivers/misc/pci_endpoint_test.c | 11 +++++++++++
> > 1 file changed, 11 insertions(+)
> >
> > diff --git a/drivers/misc/pci_endpoint_test.c b/drivers/misc/pci_endpoint_test.c
> > index c38a6083f0a7..a7f593b4e3b3 100644
> > --- a/drivers/misc/pci_endpoint_test.c
> > +++ b/drivers/misc/pci_endpoint_test.c
> > @@ -84,6 +84,9 @@
> > #define PCI_DEVICE_ID_RENESAS_R8A774E1 0x0025
> > #define PCI_DEVICE_ID_RENESAS_R8A779F0 0x0031
> >
> > +#define PCI_VENDOR_ID_ROCKCHIP 0x1d87
> > +#define PCI_DEVICE_ID_ROCKCHIP_RK3588 0x3588
> > +
>
> Did you make sure 0x3588 will not used by other production with vendor id
> 0x1d87?
Hello Frank,
I do not fully understand your question.
Vendor ID 0x1d87 is rockchip:
https://admin.pci-ids.ucw.cz/read/PC/1d87
https://admin.pci-ids.ucw.cz/read/PC/1d87/3588
is RK3588.
This is the PCI device ID and the vendor ID that the device will have on
reset. So since rockchip has put these values as the reset values, and
they appear in the PCI IDE repository, I assume that they should be fine
to use.
I could not find any other Linux device driver using this PCI device and
vendor ID, if that was what you meant.
Kind regards,
Niklas
next prev parent reply other threads:[~2024-04-30 11:42 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-24 15:16 [PATCH 00/12] PCI: dw-rockchip: Add endpoint mode support Niklas Cassel
2024-04-24 15:16 ` [PATCH 01/12] dt-bindings: PCI: snps,dw-pcie-ep: Add vendor specific reg-name Niklas Cassel
2024-04-25 15:49 ` Rob Herring
2024-04-25 15:54 ` Rob Herring
2024-04-24 15:16 ` [PATCH 02/12] dt-bindings: PCI: snps,dw-pcie-ep: Add vendor specific interrupt-names Niklas Cassel
2024-04-25 15:55 ` Rob Herring
2024-04-24 15:16 ` [PATCH 03/12] dt-bindings: PCI: snps,dw-pcie-ep: Add tx_int{a,b,c,d} legacy irqs Niklas Cassel
2024-04-25 16:20 ` Rob Herring
2024-04-24 15:16 ` [PATCH 04/12] dt-bindings: rockchip: Add DesignWare based PCIe Endpoint controller Niklas Cassel
2024-04-25 16:08 ` Rob Herring
2024-04-30 11:34 ` Niklas Cassel
2024-04-24 15:16 ` [PATCH 05/12] PCI: dw-rockchip: Fix weird indentation Niklas Cassel
2024-04-24 15:16 ` [PATCH 06/12] PCI: dw-rockchip: Add rockchip_pcie_ltssm() helper Niklas Cassel
2024-04-24 15:16 ` [PATCH 07/12] PCI: dw-rockchip: Refactor the driver to prepare for EP mode Niklas Cassel
2024-04-24 15:16 ` [PATCH 08/12] PCI: dw-rockchip: Add explicit rockchip,rk3588-pcie compatible Niklas Cassel
2024-04-24 15:16 ` [PATCH 09/12] PCI: dw-rockchip: Add endpoint mode support Niklas Cassel
2024-04-24 15:16 ` [PATCH 10/12] misc: pci_endpoint_test: Add support for rockchip rk3588 Niklas Cassel
2024-04-25 19:16 ` Frank Li
2024-04-30 11:42 ` Niklas Cassel [this message]
2024-04-24 15:16 ` [PATCH 11/12] arm64: dts: rockchip: Add PCIe endpoint mode support Niklas Cassel
2024-04-24 15:16 ` [PATCH 12/12] arm64: dts: rockchip: Add rock5b overlays for PCIe endpoint mode Niklas Cassel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZjDZMeNGPA6rCr7O@ryzen.lan \
--to=cassel@kernel.org \
--cc=Frank.li@nxp.com \
--cc=arnd@arndb.de \
--cc=bhelgaas@google.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlemoal@kernel.org \
--cc=heiko@sntech.de \
--cc=jingoohan1@gmail.com \
--cc=jon.lin@rock-chips.com \
--cc=kishon@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=kw@linux.com \
--cc=linux-pci@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=lpieralisi@kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=robh@kernel.org \
--cc=shawn.lin@rock-chips.com \
--cc=xxm@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).