From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: linux-pci@vger.kernel.org, "Bjorn Helgaas" <bhelgaas@google.com>,
"Lorenzo Pieralisi" <lorenzo.pieralisi@arm.com>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Igor Mammedov" <imammedo@redhat.com>,
"Lukas Wunner" <lukas@wunner.de>,
"Mika Westerberg" <mika.westerberg@linux.intel.com>,
"Andy Shevchenko" <andriy.shevchenko@intel.com>,
"Rafael J . Wysocki" <rafael@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>
Subject: Re: [PATCH v2 2/7] resource: Rename find_resource() to find_empty_resource_slot()
Date: Mon, 6 May 2024 15:30:11 +0300 (EEST) [thread overview]
Message-ID: <1dbfc6c4-eeb1-92c1-3371-1b0afa5683ad@linux.intel.com> (raw)
In-Reply-To: <20240503204910.GA1602543@bhelgaas>
[-- Attachment #1: Type: text/plain, Size: 913 bytes --]
On Fri, 3 May 2024, Bjorn Helgaas wrote:
> On Thu, Dec 28, 2023 at 06:57:02PM +0200, Ilpo Järvinen wrote:
> > Rename find_resource() to find_empty_resource_slot() to better describe
> > what the functions does. This is a preparation for exposing it beyond
> > resource.c which is needed by PCI core. Also rename the __ variant to
> > match the names.
>
> I wonder if "find_resource_space()" or "find_available_resource()"
> would be better than "_slot"?
>
> "Slot" *is* already used a few times in kernel/resource.c, but in most
> cases I think it refers to a "resource", and find_resource() basically
> returns a filled-in struct resource.
>
> And of course "slot" suggests something entirely different in the PCI
> context.
I picked up it from the existing usage but I've no strong opinion on
this so I'll just rework the series to not add more "slot" wording into
there.
--
i.
next prev parent reply other threads:[~2024-05-06 12:30 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-28 16:57 [PATCH v2 0/7] PCI: Solve two bridge window sizing issues Ilpo Järvinen
2023-12-28 16:57 ` [PATCH v2 1/7] PCI: Fix resource double counting on remove & rescan Ilpo Järvinen
2023-12-28 16:57 ` [PATCH v2 2/7] resource: Rename find_resource() to find_empty_resource_slot() Ilpo Järvinen
2024-05-03 20:49 ` Bjorn Helgaas
2024-05-06 12:30 ` Ilpo Järvinen [this message]
2023-12-28 16:57 ` [PATCH v2 3/7] resource: Document find_empty_resource_slot() and resource_constraint Ilpo Järvinen
2024-05-03 20:51 ` Bjorn Helgaas
2023-12-28 16:57 ` [PATCH v2 4/7] resource: Use typedef for alignf callback Ilpo Järvinen
2023-12-28 16:57 ` [PATCH v2 5/7] resource: Handle simple alignment inside __find_empty_resource_slot() Ilpo Järvinen
2023-12-28 16:57 ` [PATCH v2 6/7] resource: Export find_empty_resource_slot() Ilpo Järvinen
2023-12-28 16:57 ` [PATCH v2 7/7] PCI: Relax bridge window tail sizing rules Ilpo Järvinen
2024-05-03 20:43 ` Bjorn Helgaas
2024-05-06 11:55 ` Ilpo Järvinen
2023-12-29 12:24 ` [PATCH v2 0/7] PCI: Solve two bridge window sizing issues Mika Westerberg
2024-01-04 12:12 ` Igor Mammedov
2024-01-04 12:18 ` Jonathan Woithe
2024-01-11 8:00 ` Jonathan Woithe
2024-01-18 6:48 ` Jonathan Woithe
2024-01-18 9:27 ` Ilpo Järvinen
2024-01-21 12:54 ` Andy Shevchenko
2024-01-21 22:20 ` Jonathan Woithe
2024-01-22 12:37 ` Ilpo Järvinen
2024-01-22 13:45 ` Igor Mammedov
2024-01-31 22:48 ` Jonathan Woithe
2024-02-01 14:47 ` Ilpo Järvinen
2024-03-15 10:33 ` Ilpo Järvinen
2024-03-15 14:39 ` Andy Shevchenko
2024-04-09 14:53 ` Jonathan Cameron
2024-04-11 10:41 ` Ilpo Järvinen
2024-04-11 11:16 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1dbfc6c4-eeb1-92c1-3371-1b0afa5683ad@linux.intel.com \
--to=ilpo.jarvinen@linux.intel.com \
--cc=andriy.shevchenko@intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bhelgaas@google.com \
--cc=helgaas@kernel.org \
--cc=imammedo@redhat.com \
--cc=kw@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=lukas@wunner.de \
--cc=mika.westerberg@linux.intel.com \
--cc=rafael@kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).