patches.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
From: "Luck, Tony" <tony.luck@intel.com>
To: "Chatre, Reinette" <reinette.chatre@intel.com>
Cc: "linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
	"Yu, Fenghua" <fenghua.yu@intel.com>,
	Peter Newman <peternewman@google.com>,
	James Morse <james.morse@arm.com>,
	Babu Moger <babu.moger@amd.com>,
	Drew Fustini <dfustini@baylibre.com>,
	"x86@kernel.org" <x86@kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"patches@lists.linux.dev" <patches@lists.linux.dev>
Subject: RE: [PATCH] Documentation/x86: Document resctrl bandwidth control units are MiB
Date: Tue, 2 Apr 2024 15:43:44 +0000	[thread overview]
Message-ID: <SJ1PR11MB6083119607EE3C8ECD939E10FC3E2@SJ1PR11MB6083.namprd11.prod.outlook.com> (raw)
In-Reply-To: <387a313b-9a1f-4997-acc7-932291f69ea7@intel.com>

> Changing the documentation does seem like the least controversial approach.
> The consequence is that resctrl documentation itself now switches back and
> forth between the units ... it uses MiBps for the software controller and
> GBps when referring to AMD and talking about memory bandwidth in general
> (see section Memory bandwidth Allocation and monitoring). I hope that it
> is clear enough that MiBps is just related to the software
> controller.

Babu,

In this section that Reinette refers to above:

  Reading/writing the schemata file (on AMD systems)
  --------------------------------------------------
  Reading the schemata file will show the current bandwidth limit on all
  domains. The allocated resources are in multiples of one eighth GB/s.
  When writing to the file, you need to specify what cache id you wish to
  configure the bandwidth limit. Reading the schemata file will show the current bandwidth limit on all
  domains. The allocated resources are in multiples of one eighth GB/s.
  When writing to the file, you need to specify what cache id you wish to
  configure the bandwidth limit.

Does "one eighth GB/s" mean 134217728 bytes/s or 125000000 bytes/s?

I.e. is the documentation accurate, or sloppily using GB/s when it should
have said GiB/s?

Thanks

-Tony

      reply	other threads:[~2024-04-02 15:43 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-22 18:20 [PATCH] Documentation/x86: Document resctrl bandwidth control units are MiB Tony Luck
2024-03-29  1:01 ` Reinette Chatre
2024-03-29 15:31   ` Tony Luck
2024-03-29 16:37     ` Reinette Chatre
2024-04-01 22:44       ` Reinette Chatre
2024-04-01 23:03         ` Luck, Tony
2024-04-02  2:26           ` Reinette Chatre
2024-04-02 15:43             ` Luck, Tony [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=SJ1PR11MB6083119607EE3C8ECD939E10FC3E2@SJ1PR11MB6083.namprd11.prod.outlook.com \
    --to=tony.luck@intel.com \
    --cc=babu.moger@amd.com \
    --cc=dfustini@baylibre.com \
    --cc=fenghua.yu@intel.com \
    --cc=james.morse@arm.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=patches@lists.linux.dev \
    --cc=peternewman@google.com \
    --cc=reinette.chatre@intel.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).