From: Brian Cain <bcain@quicinc.com>
To: Nathan Chancellor <nathan@kernel.org>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>
Cc: "ndesaulniers@google.com" <ndesaulniers@google.com>,
"morbo@google.com" <morbo@google.com>,
"justinstitt@google.com" <justinstitt@google.com>,
"linux-hexagon@vger.kernel.org" <linux-hexagon@vger.kernel.org>,
"llvm@lists.linux.dev" <llvm@lists.linux.dev>,
"patches@lists.linux.dev" <patches@lists.linux.dev>,
"stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: RE: [PATCH] hexagon: vmlinux.lds.S: Handle attributes section
Date: Wed, 20 Mar 2024 00:44:35 +0000 [thread overview]
Message-ID: <CH3PR02MB10247576D7A146AC35A025717B8332@CH3PR02MB10247.namprd02.prod.outlook.com> (raw)
In-Reply-To: <20240319-hexagon-handle-attributes-section-vmlinux-lds-s-v1-1-59855dab8872@kernel.org>
> -----Original Message-----
> From: Nathan Chancellor <nathan@kernel.org>
> Sent: Tuesday, March 19, 2024 7:38 PM
> To: akpm@linux-foundation.org; Brian Cain <bcain@quicinc.com>
> Cc: ndesaulniers@google.com; morbo@google.com; justinstitt@google.com;
> linux-hexagon@vger.kernel.org; llvm@lists.linux.dev; patches@lists.linux.dev;
> stable@vger.kernel.org; Nathan Chancellor <nathan@kernel.org>
> Subject: [PATCH] hexagon: vmlinux.lds.S: Handle attributes section
>
> WARNING: This email originated from outside of Qualcomm. Please be wary
> of any links or attachments, and do not enable macros.
>
> After the linked LLVM change, the build fails with
> CONFIG_LD_ORPHAN_WARN_LEVEL="error", which happens with
> allmodconfig:
>
> ld.lld: error: vmlinux.a(init/main.o):(.hexagon.attributes) is being placed in
> '.hexagon.attributes'
>
> Handle the attributes section in a similar manner as arm and riscv by
> adding it after the primary ELF_DETAILS grouping in vmlinux.lds.S, which
> fixes the error.
>
> Cc: stable@vger.kernel.org
> Fixes: 113616ec5b64 ("hexagon: select ARCH_WANT_LD_ORPHAN_WARN")
> Link: https://github.com/llvm/llvm-
> project/commit/31f4b329c8234fab9afa59494d7f8bdaeaefeaad
> Signed-off-by: Nathan Chancellor <nathan@kernel.org>
> ---
> arch/hexagon/kernel/vmlinux.lds.S | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/hexagon/kernel/vmlinux.lds.S
> b/arch/hexagon/kernel/vmlinux.lds.S
> index 1140051a0c45..1150b77fa281 100644
> --- a/arch/hexagon/kernel/vmlinux.lds.S
> +++ b/arch/hexagon/kernel/vmlinux.lds.S
> @@ -63,6 +63,7 @@ SECTIONS
> STABS_DEBUG
> DWARF_DEBUG
> ELF_DETAILS
> + .hexagon.attributes 0 : { *(.hexagon.attributes) }
>
> DISCARDS
> }
>
> ---
> base-commit: e8f897f4afef0031fe618a8e94127a0934896aba
> change-id: 20240319-hexagon-handle-attributes-section-vmlinux-lds-s-
> 2a14b14799c0
>
> Best regards,
> --
> Nathan Chancellor <nathan@kernel.org>
Reviewed-by: Brian Cain <bcain@quicinc.com>
prev parent reply other threads:[~2024-03-20 0:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-20 0:37 [PATCH] hexagon: vmlinux.lds.S: Handle attributes section Nathan Chancellor
2024-03-20 0:44 ` Brian Cain [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CH3PR02MB10247576D7A146AC35A025717B8332@CH3PR02MB10247.namprd02.prod.outlook.com \
--to=bcain@quicinc.com \
--cc=akpm@linux-foundation.org \
--cc=justinstitt@google.com \
--cc=linux-hexagon@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=morbo@google.com \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=patches@lists.linux.dev \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).